pwm: intel: Add PWM driver for a new SoC
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v15 Latest2 patches 3 repliesIn review
- v142 patches 0 repliesSuperseded
- v132 patches 8 repliesSuperseded
Earlier versions · 12
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v12 | 2 patches | 1 reply | Superseded | |
| v11 | 2 patches | 2 replies | Superseded | |
| v10 | 2 patches | 3 replies | Superseded | |
| v9 | 2 patches | 3 replies | Superseded | |
| v8 | 2 patches | 5 replies | Superseded | |
| v7 | 2 patches | 4 replies | Superseded | |
| v6 | 2 patches | 5 replies | Superseded | |
| v5 | 2 patches | 6 replies | Superseded | |
| v4 | 2 patches | 7 replies | Superseded | |
| v3 | 2 patches | 3 replies | Superseded | |
| v2 | 2 patches | 8 replies | Superseded | |
| v1 | 2 patches | 7 replies | Superseded |
Changes in v15 from the cover letter
- Rebase to latest linux 5.10-rc2
Patches in v15 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Add DT bindings YAML schema for PWM fan controller of LGM SoCDocumentation/ | +44 | 0 replies | |
| 2/2 | Add PWM fan controller driver for LGM SoCdrivers/ drivers/ drivers/ | +256 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Rob Herring | Andy Shevchenko | Uwe Kleine-König |
|---|---|---|---|
| 1/2 | R-b | ||
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC
Patch 1 adds dt binding document in YAML format. Patch 2 add PWM fan controller driver for LGM SoC.
v15:
- Rebase to latest linux 5.10-rc2
v14:
- Address below review concerns from Uwe Kleine-K�nig.
* Add limitations info about fixed 2-wire mode support.
* Rename clk/reset _disable function names to _release.
* Remove clk & rst from driver data structure. Instead use them as arguments.
* Add pwm_chip.base = -1.
- Resolve missing MODULE_LICENSE warning.
v13:
- Address below review concerns (Philipp Zabel)
* Make unnecessary 2 line comment as 1 line comment.
* Move reset_deassert at the last after clk_enable.
* Remove unnecessary return ret statement from .remove()
- Move platform_set_drvdata() at the top of probe.
v12:
- Rebase to linux 5.9-rc4
- Add Reviewed-by tags from Andy Shevchenko & Rob Herring.
v11:
- Address below review concerns (Andy Shevchenko)
* Fix a issue with dev_err_probe() usage & improve the usage.
* Fix & improve a ordering issue with clk_enable/disable & reset_control assert/deassert.
v10:
- Removed unused of_device.h and added platform_device.h & mod_devicetable.h
v9:
- Address code quality related review concerns (Andy Shevchenko)
- Use devm_add_action_or_reset() instead of explicit unwind calls.
v8:
- Remove fan related optional properties usage, keep them as default. If needed, change pwm-fan driver separately in future to add them as generic properties.
v7:
- Address code quality related review concerns.
- Rename fan related property to pwm-*.
- Fix one make dt_binding_check reported error.
v6:
- Readjust .apply op as per review feedback.
- Add back pwm-cells property to resolve make dt_binding_check error. pwm-cells is a required property for PWM driver.
- Add back fan related optional properties.
v5:
- Address below review concerns from Uwe Kleine-K�nig.
* Improve comments about Limitations.
* Use return value of regmap_update_bits if container function returns error code.
* Modify .apply op to have strict checking for fixed period supported by PWM HW.
* Use u64 as type when use min_t for duty_cycle.
* Add reset_control_assert() in failure case in probe where it was missing earlier.
- Remove fan specific optional properties from pwm dt binding document (Rob Herring)
v4:
- Address below review concerns from Uwe Kleine-K�nig.
* Improve notes and limitations comments.
* Add common prefixes for all #defines.
* Modify/Improve logic in .apply & .get_state ops as advised.
* Skip error messages in probe when error is -EPROBE_DEFER.
* Add dependencies in Kconfig (OF & HAS_IOMEM) and add select REGMAP_MMIO.
* Address other code quality related review concerns.
- Fix make dt_binding_check reported error in YAML file.
v3:
- Address below review concerns from Uwe Kleine-K�nig.
* Remove fan rpm calibration task from the driver.
* Modify apply op as per the review feedback.
* Add roundup & round down where necessary.
* Address other misc code quality related review concerns.
* Use devm_reset_control_get_exclusive(). (Philipp Zabel)
* Improve dt binding document.
v2:
- Address below review concerns from Uwe Kleine-K�nig.
* Add notes and limitations about PWM HW.
* Rename all functions and structure to lgm_pwm_*
* Readjust space aligninment in structure fields to single space.
* Switch to using apply instead of config/enable/disable.
* Address other code quality related concerns.
* Rebase to 5.8-rc1.
- Address review concerns in dt binding YAML from Rob Herring.
v1:
- Initial version.
Rahul Tanwar (2):
Add DT bindings YAML schema for PWM fan controller of LGM SoC Add PWM fan controller driver for LGM SoC
.../devicetree/bindings/pwm/intel,lgm-pwm.yaml | 44 ++++ drivers/pwm/Kconfig | 11 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-intel-lgm.c | 244 +++++++++++++++++++++ 4 files changed, 300 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.yaml create mode 100644 drivers/pwm/pwm-intel-lgm.c
Signature · 1 line
2.11.0