Skip to content

riscv: Add vector ISA support

Greentime Hu linux-riscv lkml llvm 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest16 patches 3 repliesIn review
  2. v917 patches 14 repliesSuperseded
  3. v8 RFC21 patches 33 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v7 RFC21 patches0 repliesSuperseded
v613 patches0 repliesSuperseded
v5 RFC13 patches1 replySuperseded
v4 RFC13 patches20 repliesSuperseded

Changelog V9 from the cover letter

- Rebase to v5.15
- Merge several patches
- Refine codes
- Fix a kernel panic issue

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16riscv: Rename __switch_to_aux -> fpuarch/riscv/include/asm/switch_to.h+3 -30 replies
2/16riscv: Extending cpufeature.c to detect V-extensionarch/riscv/include/uapi/asm/hwcap.h arch/riscv/kernel/cpufeature.c+2 -00 replies
3/16riscv: Add new csr defines related to vector extensionarch/riscv/include/asm/csr.h+14 -20 replies
4/16riscv: Add vector feature to compilearch/riscv/Kconfig arch/riscv/Makefile+11 -00 replies
5/16riscv: Add has_vector/riscv_vsize to save vector features.arch/riscv/include/asm/vector.h arch/riscv/kernel/cpufeature.c arch/riscv/kernel/riscv_ksyms.c +1 more+130 -02 replies
6/16riscv: Reset vector registerarch/riscv/kernel/entry.S arch/riscv/kernel/head.S+32 -90 replies
7/16riscv: Add vector struct and assembler definitionsarch/riscv/include/asm/processor.h arch/riscv/include/uapi/asm/ptrace.h arch/riscv/kernel/asm-offsets.c+24 -00 replies
8/16riscv: Add task switch support for vectorarch/riscv/include/asm/switch_to.h arch/riscv/kernel/Makefile arch/riscv/kernel/process.c+110 -00 replies
9/16riscv: Add ptrace vector supportarch/riscv/include/uapi/asm/ptrace.h arch/riscv/kernel/ptrace.c include/uapi/linux/elf.h+78 -00 replies
10/16riscv: Add sigcontext save/restore for vectorarch/riscv/include/uapi/asm/sigcontext.h arch/riscv/kernel/asm-offsets.c arch/riscv/kernel/setup.c +1 more+191 -40 replies
11/16riscv: signal: Report signal frame size to userspace via auxvarch/riscv/include/asm/elf.h arch/riscv/include/asm/processor.h arch/riscv/include/uapi/asm/auxvec.h +1 more+36 -160 replies
12/16riscv: Add support for kernel mode vectorarch/riscv/include/asm/vector.h arch/riscv/kernel/Makefile arch/riscv/kernel/kernel_mode_vector.c +1 more+145 -00 replies
13/16riscv: Add vector extension XOR implementationarch/riscv/include/asm/xor.h arch/riscv/lib/Makefile arch/riscv/lib/xor.S+164 -00 replies
14/16riscv: Fix a kernel panic issue if $s2 is set to a specific value before entering Linuxarch/riscv/kernel/head.S+2 -01 reply
15/16riscv: Add V extension to KVM ISA allow listarch/riscv/include/asm/hwcap.h arch/riscv/kvm/vcpu.c+3 -10 replies
16/16riscv: KVM: Add vector lazy save/restore supportarch/riscv/include/asm/kvm_host.h arch/riscv/include/asm/kvm_vcpu_vector.h arch/riscv/include/uapi/asm/kvm.h +5 more+353 -00 replies

Reviews trailers per patch

4 of 16 patches have a Reviewed-by or Acked-by.

PatchAnup PatelPalmer DabbeltGreentime HuGuo Ren
1/16R-b R-b
2/16R-b R-b R-b
3/16R-b A-b
4/16
5/16
6/16R-b
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v10 thread

Cover letter [PATCH v10 00/16] riscv: Add vector ISA support

This patchset is implemented based on vector 1.0 spec to add vector support in riscv Linux kernel. There are some assumptions for this implementations.

1. We assume all harts has the same ISA in the system.
2. We use vector like FPU in some ways instead of using vector like a specific IP.
3. We disable vector in kernel space by default unless kernel uses kernel mode vector kernel_rvv_begin()/kernel_rvv_end().
4. We detect "riscv,isa" to determine whether vector is support or not.

We defined a new structure __riscv_v_state in struct thread_struct to save /restore the vector related registers. It is used for both kernel space and user space.

- In kernel space, the datap pointer in __riscv_v_state will be allocated to save vector registers.
- In user space,
- In signal handler of user space, datap will point to the address of the __riscv_v_state data structure to save vector registers in stack. We also create a __reserved[] array in sigcontext for future extensions.
- In ptrace, the data will be put in ubuf in which we use riscv_vr_get()/riscv_vr_set() to get or set the __riscv_v_state data structure from/to it, datap pointer would be zeroed and vector registers will be copied to the address right after the __riscv_v_state structure in ubuf.

This patchset also adds support for kernel mode vector, kernel XOR implementation with vector ISA and includes several bug fixes and code refinement.

This patchset is rebased to v5.18-rc6 and it is tested by running several vector programs simultaneously. It also can get the correct ucontext_t in signal handler and restore correct context after sigreturn. It is also tested with ptrace() syscall to use PTRACE_GETREGSET/PTRACE_SETREGSET to get/set the vector registers.

TODO
1. Refine the __riscv_v_state allocation in start_thread()
2. Refine the vector context switching functions by lazy save/restore
3. Add AMP support. To support harts with different ISA

[1] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc

---
Chnagelog V10
- Rebase to v5.18-rc6
- Merge several patches
- Refine codes
- Fix bugs
- Add kvm vector support

Changelog V9
- Rebase to v5.15
- Merge several patches
- Refine codes
- Fix a kernel panic issue

Changelog V8
- Rebase to v5.14
- Refine struct __riscv_v_state with struct __riscv_ctx_hdr
- Refine has_vector into a static key
- Defined __reserved space in struct sigcontext for vector and future extensions

Changelog V7
- Add support for kernel mode vector
- Add vector extension XOR implementation
- Optimize task switch codes of vector
- Allocate space for vector registers in start_thread()
- Fix an illegal instruction exception when accessing vlenb
- Optimize vector registers initialization
- Initialize vector registers with proper vsetvli then it can work normally
- Refine ptrace porting due to generic API changed
- Code clean up

Changelog V6
- Replace vle.v/vse.v instructions with vle8.v/vse8.v based on 0.9 spec
- Add comments based on mailinglist feedback
- Fix rv32 build error

Changelog V5
- Using regset_size() correctly in generic ptrace
- Fix the ptrace porting
- Fix compile warning

Changelog V4
- Support dynamic vlen
- Fix bugs: lazy save/resotre, not saving vtype
- Update VS bit offset based on latest vector spec
- Add new vector csr based on latest vector spec
- Code refine and removed unused macros

Changelog V3
- Rebase linux-5.6-rc3 and tested with qemu
- Seperate patches with Anup's advice
- Give out a ABI puzzle with unlimited vlen

Changelog V2
- Fixup typo "vecotr, fstate_save->vstate_save".
- Fixup wrong saved registers' length in vector.S.
- Seperate unrelated patches from this one.

Greentime Hu (9):
riscv: Add new csr defines related to vector extension
riscv: Add has_vector/riscv_vsize to save vector features.
riscv: Add vector struct and assembler definitions
riscv: Add task switch support for vector
riscv: Add ptrace vector support
riscv: Add sigcontext save/restore for vector
riscv: Add support for kernel mode vector
riscv: Add vector extension XOR implementation
riscv: Fix a kernel panic issue if $s2 is set to a specific value
before entering Linux

Guo Ren (4):
riscv: Rename __switch_to_aux -> fpu
riscv: Extending cpufeature.c to detect V-extension
riscv: Add vector feature to compile
riscv: Reset vector register

Vincent Chen (3):
riscv: signal: Report signal frame size to userspace via auxv
riscv: Add V extension to KVM ISA allow list
riscv: KVM: Add vector lazy save/restore support

 arch/riscv/Kconfig                       |  10 ++
 arch/riscv/Makefile                      |   1 +
 arch/riscv/include/asm/csr.h             |  16 ++-
 arch/riscv/include/asm/elf.h             |  41 +++---
 arch/riscv/include/asm/hwcap.h           |   1 +
 arch/riscv/include/asm/kvm_host.h        |   2 +
 arch/riscv/include/asm/kvm_vcpu_vector.h |  65 +++++++++
 arch/riscv/include/asm/processor.h       |   3 +
 arch/riscv/include/asm/switch_to.h       |  72 +++++++++-
 arch/riscv/include/asm/vector.h          |  17 +++
 arch/riscv/include/asm/xor.h             |  82 +++++++++++
 arch/riscv/include/uapi/asm/auxvec.h     |   1 +
 arch/riscv/include/uapi/asm/hwcap.h      |   1 +
 arch/riscv/include/uapi/asm/kvm.h        |   6 +
 arch/riscv/include/uapi/asm/ptrace.h     |  23 +++
 arch/riscv/include/uapi/asm/sigcontext.h |  24 ++++
 arch/riscv/kernel/Makefile               |   2 +
 arch/riscv/kernel/asm-offsets.c          |  15 ++
 arch/riscv/kernel/cpufeature.c           |  18 +++
 arch/riscv/kernel/entry.S                |   6 +-
 arch/riscv/kernel/head.S                 |  37 ++++-
 arch/riscv/kernel/kernel_mode_vector.c   | 132 +++++++++++++++++
 arch/riscv/kernel/process.c              |  43 ++++++
 arch/riscv/kernel/ptrace.c               |  71 ++++++++++
 arch/riscv/kernel/riscv_ksyms.c          |   6 +
 arch/riscv/kernel/setup.c                |   4 +
 arch/riscv/kernel/signal.c               | 173 ++++++++++++++++++++++-
 arch/riscv/kernel/vector.S               | 102 +++++++++++++
 arch/riscv/kvm/Makefile                  |   1 +
 arch/riscv/kvm/vcpu.c                    |  33 ++++-
 arch/riscv/kvm/vcpu_switch.S             |  69 +++++++++
 arch/riscv/kvm/vcpu_vector.c             | 173 +++++++++++++++++++++++
 arch/riscv/lib/Makefile                  |   1 +
 arch/riscv/lib/xor.S                     |  81 +++++++++++
 include/uapi/linux/elf.h                 |   1 +
 35 files changed, 1298 insertions(+), 35 deletions(-)
 create mode 100644 arch/riscv/include/asm/kvm_vcpu_vector.h
 create mode 100644 arch/riscv/include/asm/vector.h
 create mode 100644 arch/riscv/include/asm/xor.h
 create mode 100644 arch/riscv/kernel/kernel_mode_vector.c
 create mode 100644 arch/riscv/kernel/vector.S
 create mode 100644 arch/riscv/kvm/vcpu_vector.c
 create mode 100644 arch/riscv/lib/xor.S
Signature · 7 lines
2.17.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv