Skip to content

Fix the Hypervisor access functions

Alistair Francis qemu-devel qemu-riscv 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesIn review
  2. v37 patches 6 repliesSuperseded
  3. v25 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Consolidate the inline helper to a helper function
- Actually don't have a virtualised MMU index

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5target/riscv: Add a virtualised MMU Modetarget/riscv/cpu-param.h target/riscv/cpu.h target/riscv/cpu_helper.c+14 -31 reply
2/5target/riscv: Set the virtualised MMU mode when doing hyp accessestarget/riscv/op_helper.c+17 -130 replies
3/5target/riscv: Remove the HS_TWO_STAGE flagtarget/riscv/cpu.h target/riscv/cpu_bits.h target/riscv/cpu_helper.c +1 more+25 -510 replies
4/5target/riscv: Remove the hyp load and store functionstarget/riscv/cpu.h target/riscv/helper.h target/riscv/insn_trans/trans_rvh.c.inc +2 more+59 -1661 reply
5/5target/riscv: Split the Hypervisor execute load helperstarget/riscv/helper.h target/riscv/insn_trans/trans_rvh.c.inc target/riscv/op_helper.c+17 -420 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Fix the Hypervisor access functions

Richard pointed out that the Hypervisor access functions don't work correctly, see:
https://www.mail-archive.com/[email protected]/msg751540.html.
This seris fixes them up by adding a new MMU index for the virtualised state.
v4:
- Consolidate the inline helper to a helper function
- Actually don't have a virtualised MMU index
v3:
- Don't use an external helper
v2:
- Use only 6 MMU modes instead of 8

Alistair Francis (5):
target/riscv: Add a virtualised MMU Mode
target/riscv: Set the virtualised MMU mode when doing hyp accesses target/riscv: Remove the HS_TWO_STAGE flag target/riscv: Remove the hyp load and store functions target/riscv: Split the Hypervisor execute load helpers

 target/riscv/cpu-param.h                |  11 +-
 target/riscv/cpu.h                      |  19 +++-
 target/riscv/cpu_bits.h                 |   1 -
 target/riscv/helper.h                   |   5 +-
 target/riscv/cpu_helper.c               |  62 +++++-----
 target/riscv/op_helper.c                | 124 +-------------------
 target/riscv/translate.c                |   2 +
 target/riscv/insn_trans/trans_rvh.c.inc | 143 +++++++++---------------
 8 files changed, 112 insertions(+), 255 deletions(-)
Signature · 1 line
2.28.0