Skip to content

ASoC: wcd9335: Firx some resources leak in the probe and remove function

Christophe JAILLET alsa-devel kernel-janitors lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ASoC: wcd9335: Fix a double irq free in the remove functionsound/soc/codecs/wcd9335.c+0 -10 replies
2/3ASoC: wcd9335: Fix a memory leak in the error handling path of the probe functionsound/soc/codecs/wcd9335.c+10 -10 replies
3/3ASoC: wcd9335: Disable irq on slave ports in the remove functionsound/soc/codecs/wcd9335.c+11 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] ASoC: wcd9335: Firx some resources leak in the probe and remove function

The first 2 patches are sraightforward and look logical to me.

However, the 3rd one in purely speculative. It is based on the fact that a comment states that we enable some irqs on some slave ports. That said, it writes 0xFF in some registers.

So, I guess that we should disable these irqs when the driver is removed. That said, writing 0x00 at the same place looks logical to me.

This cis untested and NOT based on any documentation. Just a blind fix. Review with care.
You'll be warned :)

Christophe JAILLET (3):
ASoC: wcd9335: Fix a double irq free in the remove function
ASoC: wcd9335: Fix a memory leak in the error handling path of the
probe function
ASoC: wcd9335: Disable irq on slave ports in the remove function

 sound/soc/codecs/wcd9335.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)
Signature · 1 line
2.30.2