configure: add support for libdir option
Status from this message: applied to net-next. Thanks for working on this.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 5 repliesApplied
- v45 patches 5 repliesSuperseded
- v33 patches 4 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 2 replies | Superseded | |
| v1 | 2 patches | 3 replies | Superseded |
Changes in v5 from the cover letter
- bail out when multiple values are provided with a single option
- simplify option parsing and reduce code duplication, as suggested by Phil Sutter
- remove a nasty eval on libdir option processing
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | configure: fix parsing issue on include_dir optionconfigure | +6 | 0 replies | |
| 2/7 | configure: fix parsing issue on libbpf_dir optionconfigure | +7 | 0 replies | |
| 3/7 | configure: fix parsing issue with more than one value per optionconfigure | +3 | 0 replies | |
| 4/7 | configure: simplify options parsingconfigure | +18 | 0 replies | |
| 5/7 | configure: support --param=value styleconfigure | +6 | 0 replies | |
| 6/7 | configure: add the --prefix optionconfigure | +8 | 0 replies | |
| 7/7 | configure: add the --libdir optionMakefile configure | +22 | 3 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by.
| Patch | Phil Sutter |
|---|---|
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH iproute2 v5 0/7] configure: add support for libdir option
This series add support for the libdir parameter in iproute2 configure script. The idea is to make use of the fact that packaging systems may assume that 'configure' comes from autotools allowing a syntax similar to the autotools one, and using it to tell iproute2 where the distro expects to find its lib files.
Patches 1-2 fix a parsing issue on current configure options, that may trigger an endless loop when no value is provided with some options;
Patch 3 fixes a parsing issue bailing out when more than one value is provided for a single option;
Patch 4 simplifies options parsing, moving semantic checks out of the while loop processing options;
Patch 5 introduces support for the --opt=value style on current options, for uniformity;
Patch 6 adds the --prefix option, that may be used by some packaging systems when calling the configure script;
Patch 7 finally adds the --libdir option, and also drops the static LIBDIR var from the Makefile.
Changelog:
----------
v4 -> v5
- bail out when multiple values are provided with a single option
- simplify option parsing and reduce code duplication, as suggested by Phil Sutter
- remove a nasty eval on libdir option processing
v3 -> v4
- fix parsing issue on '--include_dir' and '--libbpf_dir'
- split '--opt value' and '--opt=value' use cases, avoid code duplication moving semantic checks on value to dedicated functions
v2 -> v3
- fix parsing error on prefix and libdir options.
v1 -> v2
- consolidate '--opt value' and '--opt=value' use cases, as suggested by David Ahern.
- added patch 2 to manage the --prefix option, used by the Debian packaging system, as reported by Luca Boccassi, and use it when setting lib directory.
Andrea Claudi (7):
configure: fix parsing issue on include_dir option
configure: fix parsing issue on libbpf_dir option
configure: fix parsing issue with more than one value per option
configure: simplify options parsing
configure: support --param=value style
configure: add the --prefix option
configure: add the --libdir option
Makefile | 7 ++--- configure | 78 +++++++++++++++++++++++++++++++++++++++++-------------- 2 files changed, 63 insertions(+), 22 deletions(-)
Signature · 1 line
2.31.1