Skip to content

RFC Strict disable implicit fallthrough

Emmanouil Pitsidianakis kvm qemu-arm qemu-devel qemu-riscv xen-devel 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest78 patches 25 repliesIn review
  2. v2 RFC78 patches 13 repliesSuperseded
  3. v1 RFC57 of 78 patches 19 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/78include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthroughaudio/pwaudio.c hw/arm/smmuv3.c include/qemu/compiler.h +4 more+37 -211 reply
2/78block: add fallthrough pseudo-keywordblock/block-copy.c block/file-posix.c block/io.c +3 more+21 -51 reply
3/78fpu/softfloat: add fallthrough pseudo-keywordfpu/softfloat-parts.c.inc fpu/softfloat.c+8 -71 reply
4/78qapi/opts-visitor: add fallthrough pseudo-keywordqapi/opts-visitor.c qapi/string-input-visitor.c+3 -20 replies
5/78qobject/json: add fallthrough pseudo-keywordqobject/json-lexer.c qobject/json-parser.c+5 -40 replies
6/78tcg: add fallthrough pseudo-keywordtarget/i386/tcg/translate.c tcg/aarch64/tcg-target.c.inc tcg/arm/tcg-target.c.inc +11 more+93 -480 replies
7/78hw/virtio/virtio-balloon.c: add fallthrough pseudo-keywordhw/virtio/virtio-balloon.c+1 -00 replies
8/78hw/block: add fallthrough pseudo-keywordhw/block/dataplane/xen-block.c hw/block/m25p80.c hw/block/onenand.c +2 more+9 -61 reply
9/78hw/acpi/aml-build.c: add fallthrough pseudo-keywordhw/acpi/aml-build.c+3 -31 reply
10/78hw/ide/atapi.c: add fallthrough pseudo-keywordhw/ide/atapi.c+1 -00 replies
11/78hw/timer: add fallthrough pseudo-keywordhw/timer/a9gtimer.c hw/timer/aspeed_timer.c hw/timer/pxa2xx_timer.c +2 more+57 -560 replies
12/78hw/usb: add fallthrough pseudo-keywordhw/usb/dev-mtp.c hw/usb/dev-wacom.c hw/usb/hcd-ehci.c +3 more+10 -80 replies
13/78hw/adc: add fallthrough pseudo-keywordhw/adc/aspeed_adc.c hw/adc/zynq-xadc.c+7 -70 replies
14/78util/error-report.c: add fallthrough pseudo-keywordutil/error-report.c+1 -10 replies
15/78accel/tcg: add fallthrough pseudo-keywordaccel/tcg/cputlb.c accel/tcg/ldst_atomicity.c.inc accel/tcg/plugin-gen.c+4 -40 replies
16/78audio: add fallthrough pseudo-keywordaudio/audio.c audio/jackaudio.c audio/pwaudio.c+12 -120 replies
17/78ui/sdl2.c: add fallthrough pseudo-keywordui/sdl2.c+1 -10 replies
18/78ui/win32-kbd-hook.c: add fallthrough pseudo-keywordui/win32-kbd-hook.c+0 -70 replies
19/78target/hppa: add fallthrough pseudo-keywordtarget/hppa/translate.c+5 -50 replies
20/78target/mips: add fallthrough pseudo-keywordtarget/mips/sysemu/physaddr.c target/mips/tcg/micromips_translate.c.inc target/mips/tcg/mips16e_translate.c.inc +4 more+66 -631 reply
21/78target/sparc: add fallthrough pseudo-keywordtarget/sparc/ldst_helper.c target/sparc/mmu_helper.c target/sparc/translate.c +1 more+8 -60 replies
22/78target/ppc: add fallthrough pseudo-keywordtarget/ppc/cpu_init.c target/ppc/excp_helper.c target/ppc/mmu-radix64.c +2 more+19 -190 replies
23/78target/arm: add fallthrough pseudo-keywordtarget/arm/helper.c target/arm/ptw.c target/arm/tcg/psci.c +4 more+68 -660 replies
24/78target/alpha: add fallthrough pseudo-keywordtarget/alpha/helper.c target/alpha/translate.c+6 -40 replies
25/78target/i386: add fallthrough pseudo-keywordtarget/i386/cpu.c target/i386/hvf/x86_decode.c target/i386/kvm/kvm.c +3 more+11 -121 reply
26/78target/s390x: add fallthrough pseudo-keywordtarget/s390x/cpu.c target/s390x/kvm/kvm.c target/s390x/mmu_helper.c +2 more+18 -140 replies
27/78target/riscv: add fallthrough pseudo-keywordtarget/riscv/insn_trans/trans_rvi.c.inc target/riscv/insn_trans/trans_rvzce.c.inc target/riscv/translate.c+14 -142 replies
28/78target/avr: add fallthrough pseudo-keywordtarget/avr/translate.c+2 -20 replies
29/78target/cris: add fallthrough pseudo-keywordtarget/cris/translate.c+2 -20 replies
30/78target/nios2: add fallthrough pseudo-keywordtarget/nios2/helper.c target/nios2/translate.c+4 -40 replies
31/78target/xtensa: add fallthrough pseudo-keywordtarget/xtensa/op_helper.c target/xtensa/translate.c+5 -50 replies
32/78target/m68k: add fallthrough pseudo-keywordtarget/m68k/op_helper.c target/m68k/translate.c+7 -60 replies
33/78target/rx: add fallthrough pseudo-keywordtarget/rx/translate.c+1 -10 replies
34/78target/tricore: add fallthrough pseudo-keywordtarget/tricore/translate.c+2 -21 reply
35/78target/sh4: add fallthrough pseudo-keywordtarget/sh4/helper.c+1 -10 replies
36/78target/openrisc: add fallthrough pseudo-keywordtarget/openrisc/mmu.c target/openrisc/translate.c+2 -20 replies
37/78target/hexagon: add fallthrough pseudo-keywordtarget/hexagon/idef-parser/parser-helpers.c+3 -21 reply
38/78system/rtc.c: add fallthrough pseudo-keywordsystem/rtc.c+1 -10 replies
39/78hw/scsi: add fallthrough pseudo-keywordhw/scsi/esp.c hw/scsi/megasas.c hw/scsi/scsi-bus.c +1 more+5 -50 replies
40/78hw/sd/sdhci.c: add fallthrough pseudo-keywordhw/sd/sdhci.c+4 -41 reply
41/78linux-user: add fallthrough pseudo-keywordlinux-user/mips/cpu_loop.c linux-user/mmap.c linux-user/syscall.c+6 -60 replies
42/78hw/i386: add fallthrough pseudo-keywordhw/i386/intel_iommu.c hw/i386/kvm/xen_evtchn.c hw/i386/x86.c+4 -41 reply
43/78hw/misc: add fallthrough pseudo-keywordhw/misc/a9scu.c hw/misc/aspeed_scu.c hw/misc/bcm2835_property.c +1 more+11 -90 replies
44/78hw/m68k/mcf_intc.c: add fallthrough pseudo-keywordhw/m68k/mcf_intc.c+1 -10 replies
45/78hw/dma: add fallthrough pseudo-keywordhw/dma/omap_dma.c hw/dma/pxa2xx_dma.c hw/dma/sparc32_dma.c+19 -190 replies
46/78disas: add fallthrough pseudo-keyworddisas/hppa.c disas/m68k.c disas/sh4.c +1 more+7 -70 replies
47/78contrib/rdmacm-mux: add fallthrough pseudo-keywordcontrib/rdmacm-mux/main.c+5 -50 replies
48/78contrib/vhost-user-scsi: add fallthrough pseudo-keywordcontrib/vhost-user-scsi/vhost-user-scsi.c+2 -10 replies
49/78hw/arm: add fallthrough pseudo-keywordhw/arm/omap1.c hw/arm/pxa2xx.c hw/arm/stellaris.c+8 -70 replies
50/78hw/audio: add fallthrough pseudo-keywordhw/audio/asc.c hw/audio/cs4231a.c hw/audio/gusemu_hal.c+3 -30 replies
51/78chardev: add fallthrough pseudo-keywordchardev/char-socket.c+1 -10 replies
52/78hw/char: add fallthrough pseudo-keywordhw/char/nrf51_uart.c+2 -20 replies
53/78nbd: add fallthrough pseudo-keywordnbd/client.c nbd/common.c qemu-nbd.c+5 -50 replies
54/78hw/core: add fallthrough pseudo-keywordhw/core/loader.c+1 -10 replies
55/78hw/display: add fallthrough pseudo-keywordhw/display/cg3.c hw/display/cirrus_vga.c hw/display/tcx.c+4 -40 replies
56/78hw/input: add fallthrough pseudo-keywordhw/input/hid.c hw/input/tsc2005.c hw/input/tsc210x.c+5 -40 replies
57/78hw/net: add fallthrough pseudo-keywordhw/net/cadence_gem.c hw/net/can/can_sja1000.c hw/net/igb_core.c +6 more+14 -122 replies
58/78hw/ppc: add fallthrough pseudo-keywordhw/ppc/pnv_bmc.c hw/ppc/spapr_events.c+2 -10 replies
59/78hw/intc: add fallthrough pseudo-keywordhw/intc/apic.c hw/intc/arm_gicv3_kvm.c hw/intc/armv7m_nvic.c +1 more+16 -160 replies
60/78qga: add fallthrough pseudo-keywordqga/main.c qga/vss-win32/requester.cpp+2 -11 reply
61/78semihosting: add fallthrough pseudo-keywordsemihosting/arm-compat-semi.c+1 -10 replies
62/78hw/gpio: add fallthrough pseudo-keywordhw/gpio/omap_gpio.c hw/i2c/bitbang_i2c.c+2 -20 replies
63/78hw/ipmi: add fallthrough pseudo-keywordhw/ipmi/ipmi_bmc_extern.c hw/ipmi/smbus_ipmi.c+3 -30 replies
64/78hw/mips: add fallthrough pseudo-keywordhw/mips/boston.c+6 -61 reply
65/78hw/nvme: add fallthrough pseudo-keywordhw/nvme/ctrl.c hw/nvme/dif.c+14 -141 reply
66/78hw/nvram/eeprom_at24c.c: add fallthrough pseudo-keywordhw/nvram/eeprom_at24c.c+1 -10 replies
67/78hw/pci-host/pnv_phb3.c: add fallthrough pseudo-keywordhw/pci-host/pnv_phb3.c+1 -11 reply
68/78hw/pci: add fallthrough pseudo-keywordhw/pci/pcie_aer.c hw/pci/pcie_doe.c+3 -20 replies
69/78hw/rdma/rdma_backend.c: add fallthrough pseudo-keywordhw/rdma/rdma_backend.c+1 -10 replies
70/78hw/rtc: add fallthrough pseudo-keywordhw/rtc/aspeed_rtc.c hw/rtc/mc146818rtc.c+4 -41 reply
71/78hw/s390x: add fallthrough pseudo-keywordhw/s390x/ipl.c hw/s390x/s390-pci-inst.c hw/s390x/sclp.c+5 -40 replies
72/78hw/ssi: add fallthrough pseudo-keywordhw/ssi/npcm7xx_fiu.c hw/ssi/omap_spi.c+31 -310 replies
73/78hw/watchdog/wdt_diag288.c: add fallthrough pseudo-keywordhw/watchdog/wdt_diag288.c+1 -10 replies
74/78hw/cxl/cxl-device-utils.c: add fallthrough pseudo-keywordhw/cxl/cxl-device-utils.c+2 -21 reply
75/78migration: add fallthrough pseudo-keywordmigration/migration.c+1 -11 reply
76/78qemu-img.c: add fallthrough pseudo-keywordqemu-img.c+1 -10 replies
77/78tests/unit/test-char.c: add fallthrough pseudo-keywordtests/unit/test-char.c+1 -10 replies
78/78meson.build: increase -Wimplicit-fallthrough to 5docs/devel/style.rst meson.build+24 -10 replies

Reviews trailers per patch

27 of 78 patches have a Reviewed-by or Acked-by.

PatchCédric Le GoaterDavid HildenbrandMax FilippovHarsh Prateek BoraSong GaoBastian KoppelmannDaniel Henrique BarbozaAlistair FrancisJonathan CameronFabiano RosasStefan HajnocziPhilippe Mathieu-DaudéAlex BennéeAnton JohanssonKonstantin KostiukAni SinhaPaul DurrantZhao LiuKlaus Jensen
1/78R-b
2/78R-b
3/78A-b
4/78
5/78
6/78
7/78R-b
8/78R-b
9/78R-b
10/78
11/78
12/78
13/78R-b
14/78
15/78
16/78
17/78
18/78
19/78
20/78R-b
21/78
22/78R-b
23/78
24/78
25/78R-b
26/78R-b
27/78R-b A-b
28/78
29/78
30/78
31/78R-b
32/78
33/78
34/78R-b
35/78
36/78
37/78R-b
38/78
39/78
40/78R-b
41/78
42/78R-b
43/78R-b
44/78
45/78
46/78
47/78
48/78
49/78
50/78
51/78
52/78
53/78
54/78
55/78
56/78
57/78
58/78R-b
59/78
60/78R-b
61/78
62/78
63/78
64/78R-b
65/78R-b
66/78
67/78R-b
68/78
69/78
70/78R-b
71/78R-b
72/78
73/78
74/78A-b
75/78R-b
76/78
77/78
78/78

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 19 reviewers.

Read the v3 thread

Cover letter [RFC PATCH v3 00/78] Strict disable implicit fallthrough

--
Resending because --function-context was accidentally used in the previous version. Sincere apologies for the noise.
--

Hello,

This RFC is inspired by the kernel's move to -Wimplicit-fallthrough=3 back in 2019.[0]
We take one step (or two) further by increasing it to 5 which rejects fall through comments and requires an attribute statement.

[0]:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a035d552a93b

The line differences are not many, but they spread all over different subsystems, architectures and devices. An attempt has been made to split them in cohesive patches to aid post-RFC review. Part of the RFC is to determine whether these patch divisions needs improvement.

Main questions this RFC poses
=============================

- Is this change desirable and net-positive.
- Should the fallthrough; pseudo-keyword be defined like in the Linux kernel, or use glib's G_GNUC_FALLTHROUGH, or keep the already existing QEMU_FALLTHROUGH macro.
- Should fallthrough comments be removed if they do not include extra information.

Some external resources
=======================

See the RFC discussion in the kernel:

https://lore.kernel.org/lkml/1d2830aadbe9d8151728a7df5b88528fc72a0095.1564549413.git.joe@perches.com/

The fallthrough; pseudo-keyword in the kernel source code:

https://elixir.bootlin.com/linux/latest/C/ident/fallthrough

In summary, I quote the doc comment and definition:

/*
* Add the pseudo keyword 'fallthrough' so case statement blocks
* must end with any of these keywords:
* break;
* fallthrough;
* continue;
* goto <label>;
* return [expression];
*
* gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes
*/
#if __has_attribute(__fallthrough__)
# define fallthrough __attribute__((__fallthrough__))
#else
# define fallthrough do {} while (0) /* fallthrough */
#endif

Background - Motivation
=======================

The C switch statement allows you to conditionally goto different labels depending on a value. A break; statement conveniently goto's the end of the switch. If a "case" does not end in a break, we say that the control flow falls through the next case label, if any, implicitly. This can lead to bugs and QEMU uses the GCC warning -Wimplicit-fallthrough to prevent this.

Currently, QEMU is built with -Wimplicit-fallthrough=2. This makes GCC's static analyzer check for a case-insensitive matches of the .*falls?[ \t-]*thr(ough|u).* regular expression. This means the following list of comments taken from QEMU all disable the implicit fallthrough warning:

- /* FALLTHRU */
- /* fall through */
- /* Fall through. */
- /* Fall through... */
- /* fall through if hEventTimeout is signaled */
- /* FALL THROUGH */

To keep a constistent code style, this commit adds a macro fallthrough that looks like a C keyword but expands to an attribute statement in supported compilers (GCC at the moment).

Note: there was already such a macro, QEMU_FALLTHROUGH, and it was used only around 7 times in the code base. The first commit replaces it.

Emmanouil Pitsidianakis (78):
include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough
block: add fallthrough pseudo-keyword
fpu/softfloat: add fallthrough pseudo-keyword qapi/opts-visitor: add fallthrough pseudo-keyword qobject/json: add fallthrough pseudo-keyword
tcg: add fallthrough pseudo-keyword hw/virtio/virtio-balloon.c: add fallthrough pseudo-keyword hw/block: add fallthrough pseudo-keyword hw/acpi/aml-build.c: add fallthrough pseudo-keyword hw/ide/atapi.c: add fallthrough pseudo-keyword hw/timer: add fallthrough pseudo-keyword
hw/usb: add fallthrough pseudo-keyword
hw/adc: add fallthrough pseudo-keyword util/error-report.c: add fallthrough pseudo-keyword accel/tcg: add fallthrough pseudo-keyword
audio: add fallthrough pseudo-keyword
ui/sdl2.c: add fallthrough pseudo-keyword ui/win32-kbd-hook.c: add fallthrough pseudo-keyword target/hppa: add fallthrough pseudo-keyword target/mips: add fallthrough pseudo-keyword target/sparc: add fallthrough pseudo-keyword target/ppc: add fallthrough pseudo-keyword
target/arm: add fallthrough pseudo-keyword target/alpha: add fallthrough pseudo-keyword target/i386: add fallthrough pseudo-keyword target/s390x: add fallthrough pseudo-keyword target/riscv: add fallthrough pseudo-keyword target/avr: add fallthrough pseudo-keyword
target/cris: add fallthrough pseudo-keyword target/nios2: add fallthrough pseudo-keyword target/xtensa: add fallthrough pseudo-keyword target/m68k: add fallthrough pseudo-keyword
target/rx: add fallthrough pseudo-keyword target/tricore: add fallthrough pseudo-keyword target/sh4: add fallthrough pseudo-keyword target/openrisc: add fallthrough pseudo-keyword target/hexagon: add fallthrough pseudo-keyword system/rtc.c: add fallthrough pseudo-keyword
hw/scsi: add fallthrough pseudo-keyword
hw/sd/sdhci.c: add fallthrough pseudo-keyword
linux-user: add fallthrough pseudo-keyword
hw/i386: add fallthrough pseudo-keyword
hw/misc: add fallthrough pseudo-keyword hw/m68k/mcf_intc.c: add fallthrough pseudo-keyword hw/dma: add fallthrough pseudo-keyword
disas: add fallthrough pseudo-keyword contrib/rdmacm-mux: add fallthrough pseudo-keyword contrib/vhost-user-scsi: add fallthrough pseudo-keyword hw/arm: add fallthrough pseudo-keyword
hw/audio: add fallthrough pseudo-keyword
chardev: add fallthrough pseudo-keyword
hw/char: add fallthrough pseudo-keyword
nbd: add fallthrough pseudo-keyword
hw/core: add fallthrough pseudo-keyword
hw/display: add fallthrough pseudo-keyword
hw/input: add fallthrough pseudo-keyword
hw/net: add fallthrough pseudo-keyword
hw/ppc: add fallthrough pseudo-keyword
hw/intc: add fallthrough pseudo-keyword
qga: add fallthrough pseudo-keyword
semihosting: add fallthrough pseudo-keyword
hw/gpio: add fallthrough pseudo-keyword
hw/ipmi: add fallthrough pseudo-keyword
hw/mips: add fallthrough pseudo-keyword
hw/nvme: add fallthrough pseudo-keyword hw/nvram/eeprom_at24c.c: add fallthrough pseudo-keyword hw/pci-host/pnv_phb3.c: add fallthrough pseudo-keyword hw/pci: add fallthrough pseudo-keyword hw/rdma/rdma_backend.c: add fallthrough pseudo-keyword hw/rtc: add fallthrough pseudo-keyword
hw/s390x: add fallthrough pseudo-keyword
hw/ssi: add fallthrough pseudo-keyword hw/watchdog/wdt_diag288.c: add fallthrough pseudo-keyword hw/cxl/cxl-device-utils.c: add fallthrough pseudo-keyword
migration: add fallthrough pseudo-keyword
qemu-img.c: add fallthrough pseudo-keyword tests/unit/test-char.c: add fallthrough pseudo-keyword meson.build: increase -Wimplicit-fallthrough to 5

 accel/tcg/cputlb.c                          |  4 +-
 accel/tcg/ldst_atomicity.c.inc              |  2 +-
 accel/tcg/plugin-gen.c                      |  2 +-
 audio/audio.c                               | 16 ++--
 audio/jackaudio.c                           |  4 +-
 audio/pwaudio.c                             | 12 +--
 block/block-copy.c                          |  1 +
 block/file-posix.c                          |  1 +
 block/io.c                                  |  1 +
 block/iscsi.c                               |  1 +
 block/qcow2-cluster.c                       |  5 +-
 block/vhdx.c                                | 17 +++-
 chardev/char-socket.c                       |  2 +-
 contrib/rdmacm-mux/main.c                   | 10 +--
 contrib/vhost-user-scsi/vhost-user-scsi.c   |  3 +-
 disas/hppa.c                                |  4 +-
 disas/m68k.c                                |  2 +-
 disas/sh4.c                                 |  6 +-
 disas/sparc.c                               |  2 +-
 docs/devel/style.rst                        | 23 +++++
 fpu/softfloat-parts.c.inc                   |  8 +-
 fpu/softfloat.c                             |  7 +-
 hw/acpi/aml-build.c                         |  6 +-
 hw/adc/aspeed_adc.c                         | 12 +--
 hw/adc/zynq-xadc.c                          |  2 +-
 hw/arm/omap1.c                              |  8 +-
 hw/arm/pxa2xx.c                             |  6 +-
 hw/arm/smmuv3.c                             |  2 +-
 hw/arm/stellaris.c                          |  1 +
 hw/audio/asc.c                              |  2 +-
 hw/audio/cs4231a.c                          |  2 +-
 hw/audio/gusemu_hal.c                       |  2 +-
 hw/block/dataplane/xen-block.c              |  4 +-
 hw/block/m25p80.c                           |  2 +-
 hw/block/onenand.c                          |  2 +-
 hw/block/pflash_cfi01.c                     |  1 +
 hw/block/pflash_cfi02.c                     |  6 +-
 hw/char/nrf51_uart.c                        |  4 +-
 hw/core/loader.c                            |  2 +-
 hw/cxl/cxl-device-utils.c                   |  4 +-
 hw/display/cg3.c                            |  2 +-
 hw/display/cirrus_vga.c                     |  2 +-
 hw/display/tcx.c                            |  4 +-
 hw/dma/omap_dma.c                           | 32 +++----
 hw/dma/pxa2xx_dma.c                         |  4 +-
 hw/dma/sparc32_dma.c                        |  2 +-
 hw/gpio/omap_gpio.c                         |  2 +-
 hw/i2c/bitbang_i2c.c                        |  2 +-
 hw/i386/intel_iommu.c                       |  4 +-
 hw/i386/kvm/xen_evtchn.c                    |  2 +-
 hw/i386/x86.c                               |  2 +-
 hw/ide/atapi.c                              |  1 +
 hw/input/hid.c                              |  3 +-
 hw/input/tsc2005.c                          |  4 +-
 hw/input/tsc210x.c                          |  2 +-
 hw/intc/apic.c                              |  2 +-
 hw/intc/arm_gicv3_kvm.c                     | 16 ++--
 hw/intc/armv7m_nvic.c                       | 12 +--
 hw/intc/xilinx_intc.c                       |  2 +-
 hw/ipmi/ipmi_bmc_extern.c                   |  2 +-
 hw/ipmi/smbus_ipmi.c                        |  4 +-
 hw/m68k/mcf_intc.c                          |  2 +-
 hw/mips/boston.c                            | 12 +--
 hw/misc/a9scu.c                             |  2 +
 hw/misc/aspeed_scu.c                        |  2 +-
 hw/misc/bcm2835_property.c                  | 12 +--
 hw/misc/mos6522.c                           |  4 +-
 hw/net/cadence_gem.c                        |  4 +-
 hw/net/can/can_sja1000.c                    |  4 +-
 hw/net/igb_core.c                           |  2 +-
 hw/net/igbvf.c                              |  2 +-
 hw/net/imx_fec.c                            |  2 +-
 hw/net/net_rx_pkt.c                         |  2 +-
 hw/net/pcnet.c                              |  2 +-
 hw/net/rtl8139.c                            |  6 +-
 hw/net/xilinx_ethlite.c                     |  2 +-
 hw/nvme/ctrl.c                              | 24 +++---
 hw/nvme/dif.c                               |  4 +-
 hw/nvram/eeprom_at24c.c                     |  2 +-
 hw/pci-host/pnv_phb3.c                      |  2 +-
 hw/pci/pcie_aer.c                           |  3 +-
 hw/pci/pcie_doe.c                           |  2 +-
 hw/ppc/pnv_bmc.c                            |  2 +-
 hw/ppc/spapr_events.c                       |  1 +
 hw/rdma/rdma_backend.c                      |  2 +-
 hw/rtc/aspeed_rtc.c                         |  4 +-
 hw/rtc/mc146818rtc.c                        |  4 +-
 hw/s390x/ipl.c                              |  1 +
 hw/s390x/s390-pci-inst.c                    |  4 +-
 hw/s390x/sclp.c                             |  4 +-
 hw/scsi/esp.c                               |  2 +-
 hw/scsi/megasas.c                           |  2 +-
 hw/scsi/scsi-bus.c                          |  4 +-
 hw/scsi/scsi-disk.c                         |  2 +-
 hw/sd/sdhci.c                               |  8 +-
 hw/ssi/npcm7xx_fiu.c                        | 14 +--
 hw/ssi/omap_spi.c                           | 48 +++++------
 hw/timer/a9gtimer.c                         |  8 +-
 hw/timer/aspeed_timer.c                     |  1 +
 hw/timer/pxa2xx_timer.c                     | 94 ++++++++++-----------
 hw/timer/renesas_tmr.c                      |  2 +-
 hw/timer/sh_timer.c                         |  8 +-
 hw/usb/dev-mtp.c                            |  2 +-
 hw/usb/dev-wacom.c                          |  2 +-
 hw/usb/hcd-ehci.c                           |  4 +-
 hw/usb/hcd-xhci.c                           |  4 +-
 hw/usb/redirect.c                           |  4 +-
 hw/usb/tusb6010.c                           |  2 +-
 hw/virtio/virtio-balloon.c                  |  1 +
 hw/watchdog/wdt_diag288.c                   |  2 +-
 include/qemu/compiler.h                     | 30 +++++--
 include/qemu/osdep.h                        |  4 +-
 linux-user/mips/cpu_loop.c                  |  8 +-
 linux-user/mmap.c                           |  2 +-
 linux-user/syscall.c                        |  2 +-
 meson.build                                 |  2 +-
 migration/migration.c                       |  2 +-
 nbd/client.c                                |  4 +-
 nbd/common.c                                |  2 +-
 qapi/opts-visitor.c                         |  1 +
 qapi/string-input-visitor.c                 |  4 +-
 qemu-img.c                                  |  2 +-
 qemu-nbd.c                                  |  4 +-
 qga/main.c                                  |  2 +-
 qga/vss-win32/requester.cpp                 |  1 +
 qobject/json-lexer.c                        |  4 +-
 qobject/json-parser.c                       |  5 +-
 semihosting/arm-compat-semi.c               |  2 +-
 system/rtc.c                                |  2 +-
 target/alpha/helper.c                       |  6 +-
 target/alpha/translate.c                    |  4 +-
 target/arm/helper.c                         | 34 ++++----
 target/arm/ptw.c                            | 10 +--
 target/arm/tcg/psci.c                       |  2 +-
 target/arm/tcg/translate-a64.c              | 76 ++++++++---------
 target/arm/tcg/translate-m-nocp.c           |  2 +-
 target/arm/tcg/translate-vfp.c              |  2 +-
 target/arm/tcg/translate.c                  |  8 +-
 target/avr/translate.c                      |  4 +-
 target/cris/translate.c                     |  4 +-
 target/hexagon/idef-parser/parser-helpers.c |  5 +-
 target/hppa/translate.c                     | 10 +--
 target/i386/cpu.c                           |  2 +-
 target/i386/hvf/x86_decode.c                |  1 +
 target/i386/kvm/kvm.c                       |  4 +-
 target/i386/tcg/decode-new.c.inc            |  6 +-
 target/i386/tcg/emit.c.inc                  |  2 +-
 target/i386/tcg/translate.c                 | 11 +--
 target/loongarch/cpu.c                      |  4 +-
 target/loongarch/translate.c                |  2 +-
 target/m68k/op_helper.c                     |  3 +-
 target/m68k/translate.c                     | 10 +--
 target/mips/sysemu/physaddr.c               |  2 +-
 target/mips/tcg/micromips_translate.c.inc   |  4 +-
 target/mips/tcg/mips16e_translate.c.inc     | 30 +++----
 target/mips/tcg/mxu_translate.c             |  8 +-
 target/mips/tcg/nanomips_translate.c.inc    |  4 +-
 target/mips/tcg/op_helper.c                 |  2 +-
 target/mips/tcg/translate.c                 | 79 ++++++++---------
 target/nios2/helper.c                       |  6 +-
 target/nios2/translate.c                    |  2 +-
 target/openrisc/mmu.c                       |  2 +-
 target/openrisc/translate.c                 |  2 +-
 target/ppc/cpu_init.c                       |  8 +-
 target/ppc/excp_helper.c                    |  6 +-
 target/ppc/mmu-radix64.c                    |  6 +-
 target/ppc/mmu_common.c                     | 12 +--
 target/ppc/translate.c                      |  6 +-
 target/riscv/insn_trans/trans_rvi.c.inc     |  2 +-
 target/riscv/insn_trans/trans_rvzce.c.inc   | 22 ++---
 target/riscv/translate.c                    |  4 +-
 target/rx/translate.c                       |  2 +-
 target/s390x/cpu.c                          |  4 +-
 target/s390x/kvm/kvm.c                      |  2 +-
 target/s390x/mmu_helper.c                   |  6 +-
 target/s390x/tcg/translate.c                | 18 ++--
 target/s390x/tcg/translate_vx.c.inc         |  2 +-
 target/sh4/helper.c                         |  2 +-
 target/sparc/ldst_helper.c                  |  4 +-
 target/sparc/mmu_helper.c                   |  6 +-
 target/sparc/translate.c                    |  3 +-
 target/sparc/win_helper.c                   |  1 +
 target/tricore/translate.c                  |  4 +-
 target/xtensa/op_helper.c                   |  8 +-
 target/xtensa/translate.c                   |  2 +-
 tcg/aarch64/tcg-target.c.inc                | 15 +++-
 tcg/arm/tcg-target.c.inc                    |  5 +-
 tcg/i386/tcg-target.c.inc                   | 20 +++--
 tcg/loongarch64/tcg-target.c.inc            |  4 +-
 tcg/mips/tcg-target.c.inc                   |  8 +-
 tcg/optimize.c                              |  8 +-
 tcg/ppc/tcg-target.c.inc                    | 19 +++--
 tcg/riscv/tcg-target.c.inc                  |  5 +-
 tcg/s390x/tcg-target.c.inc                  |  8 +-
 tcg/tcg-op-gvec.c                           | 24 +++---
 tcg/tcg-op-ldst.c                           |  2 +-
 tcg/tcg.c                                   | 24 +++---
 tcg/tci.c                                   |  2 +-
 tcg/tci/tcg-target.c.inc                    |  2 +-
 tests/unit/test-char.c                      |  2 +-
 ui/sdl2.c                                   |  2 +-
 ui/win32-kbd-hook.c                         |  7 --
 util/error-report.c                         |  2 +-
 203 files changed, 747 insertions(+), 618 deletions(-)

base-commit: cea3ea670fe265421131aad90c36fbb87bc4d206

Signature · 1 line
2.39.2