Skip to content

address violations of MISRA C Rule 20.7

Nicola Vetrini xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/26 patches 14 repliesIn review
  2. v2 posting 1/23 patches 8 repliesSuperseded
  3. v110 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing list

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6automation/eclair: address violations of MISRA C Rule 20.7automation/eclair_analysis/ECLAIR/deviations.ecl+8 -04 replies
2/6xen/self-tests: address violations of MISRA rule 20.7xen/include/xen/self-tests.h+4 -40 replies
3/6xen/guest_access: address violations of MISRA rule 20.7xen/include/xen/guest_access.h+2 -20 replies
4/6automation/eclair_analysis: address violations of MISRA C Rule 20.7automation/eclair_analysis/ECLAIR/deviations.ecl docs/misra/deviations.rst+6 -32 replies
5/6x86/irq: address violations of MISRA C Rule 20.7xen/include/xen/irq.h+1 -10 replies
6/6automation/eclair_analysis: clean ECLAIR configuration scriptsautomation/eclair_analysis/ECLAIR/analyze.sh+1 -22 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJan BeulichStefano StabelliniOleksii Kurochko
SeriesRelease-Acked-by
1/6A-b
2/6R-b
3/6A-b
4/6R-b R-b
5/6A-b
6/6A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [XEN PATCH v2 0/6][RESEND] address violations of MISRA C Rule 20.7

Hi all,

this series addresses several violations of Rule 20.7, as well as a small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.

Note that by applying this series the rule has a few leftover violations. Most of those are in x86 code in xen/arch/x86/include/asm/msi.h .
I did send a patch [1] to deal with those, limited only to addressing the MISRA violations, but in the end it was dropped in favour of a more general cleanup of the file upon agreement, so this is why those changes are not included here.

[1] https://lore.kernel.org/xen-devel/2f2c865f20d0296e623f1d65bed25c083f5dd497.1711700095.git.nicola.vetrini@bugseng.com/

Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing list

Nicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7 x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scripts

 automation/eclair_analysis/ECLAIR/analyze.sh     |  3 +--
 automation/eclair_analysis/ECLAIR/deviations.ecl | 14 ++++++++++++--
 docs/misra/deviations.rst                        |  3 ++-
 xen/include/xen/guest_access.h                   |  4 ++--
 xen/include/xen/irq.h                            |  2 +-
 xen/include/xen/self-tests.h                     |  8 ++++----
 6 files changed, 22 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1