address violations of MISRA C Rule 20.7
v2 cover address violations of MISRA C Rule 20.7
Hi all,
this series addresses several violations of Rule 20.7, as well as a small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.
Note that by applying this series the rule has a few leftover violations. Most of those are in x86 code in xen/arch/x86/include/asm/msi.h .
I did send a patch [1] to deal with those, limited only to addressing the MISRA violations, but in the end it was dropped in favour of a more general cleanup of the file upon agreement, so this is why those changes are not included here.
Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing list
Nicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7 x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scripts
automation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- automation/eclair_analysis/ECLAIR/deviations.ecl | 14 ++++++++++++-- docs/misra/deviations.rst | 3 ++- xen/include/xen/guest_access.h | 4 ++-- xen/include/xen/irq.h | 2 +- xen/include/xen/self-tests.h | 8 ++++---- 6 files changed, 22 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1
PATCH RESEND v2 1/6 automation/eclair: address violations of MISRA C Rule 20.7
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The helper macro bitmap_switch has parameters that cannot be parenthesized in order to comply with the rule, as that would break its functionality. Moreover, the risk of misuse due developer confusion is deemed not substantial enough to warrant a more involved refactor, thus the macro is deviated for this rule.
No functional change.
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ 1 file changed, 8 insertions(+)
automation/eclair_analysis/ECLAIR/deviations.ecl +8 -0
@@ -463,6 +463,14 @@ of this macro do not lead to developer confusion, and can thus be deviated." -config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(^count_args_$))))"} -doc_end +-doc_begin="The arguments of macro bitmap_switch macro can't be parenthesized as +the rule would require, without breaking the functionality of the macro. This is +a specialized local helper macro only used within the bitmap.h header, so it is +less likely to lead to developer confusion and it is deemed better to deviate it." +-file_tag+={xen_bitmap_h, "^xen/include/xen/bitmap\\.h$"} +-config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(loc(file(xen_bitmap_h))&&^bitmap_switch$))))"} +-doc_end + -doc_begin="Uses of variadic macros that have one of their arguments defined as a macro and used within the body for both ordinary parameter expansion and as an operand to the # or ## operators have a behavior that is well-understood and
Signature · 1 line
2.34.1
Re: [XEN PATCH v2 1/6][RESEND] automation/eclair: address violations of MISRA C Rule 20.7
Quoted 9 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The helper macro
bitmap_switchhas parameters that cannot be parenthesized in order to comply with the rule, as that would break its functionality. Moreover, the risk of misuse due developer confusion is deemed not substantial enough to warrant a more involved refactor, thus the macro is deviated for this rule.
Quoted 3 lines
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
If possible, I would prefer we used a SAF in-code comment deviation. If that doesn't work for any reason this patch is fine and I'd ack it.
Quoted 26 lines
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ 1 file changed, 8 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +8
-0@@ -463,6 +463,14 @@ of this macro do not lead to developer confusion, and can thus be deviated." -config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(^count_args_$))))"} -doc_end +-doc_begin="The arguments of macro bitmap_switch macro can't be parenthesized as +the rule would require, without breaking the functionality of the macro. This is +a specialized local helper macro only used within the bitmap.h header, so it is +less likely to lead to developer confusion and it is deemed better to deviate it." +-file_tag+={xen_bitmap_h, "^xen/include/xen/bitmap\\.h$"} +-config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(loc(file(xen_bitmap_h))&&^bitmap_switch$))))"} +-doc_end + -doc_begin="Uses of variadic macros that have one of their arguments defined as a macro and used within the body for both ordinary parameter expansion and as an operand to the # or ## operators have a behavior that is well-understood andSignature · 1 line
2.34.1
Re: [XEN PATCH v2 1/6][RESEND] automation/eclair: address violations of MISRA C Rule 20.7
Quoted 10 lines · Stefano Stabellini
Quoted 9 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The helper macro
bitmap_switchhas parameters that cannot be parenthesized in order to comply with the rule, as that would break its functionality. Moreover, the risk of misuse due developer confusion is deemed not substantial enough to warrant a more involved refactor, thus the macro is deviated for this rule.
Quoted 7 lines
Quoted 3 lines
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>If possible, I would prefer we used a SAF in-code comment deviation. If that doesn't work for any reason this patch is fine and I'd ack it.
Would that be an improvement for safety in your opinion?
Quoted 37 lines
Quoted 37 lines
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ 1 file changed, 8 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -463,6 +463,14 @@ of this macro do not lead to developer confusion,and can thus be deviated."
-config=MC3R1.R20.7,reports+={safe,
"any_area(any_loc(any_exp(macro(^count_args_$))))"}
-doc_end+-doc_begin="The arguments of macro
bitmap_switchmacro can't be parenthesized as
+the rule would require, without breaking the functionality of the macro. This is
+a specialized local helper macro only used within thebitmap.hheader, so it is
+less likely to lead to developer confusion and it is deemed better to deviate it."+-file_tag+={xen_bitmap_h, "^xen/include/xen/bitmap\\.h$"} +-config=MC3R1.R20.7,reports+={safe,"any_area(any_loc(any_exp(macro(loc(file(xen_bitmap_h))&&^bitmap_switch$))))"} +-doc_end
+
-doc_begin="Uses of variadic macros that have one of their arguments
defined as
a macro and used within the body for both ordinary parameter
expansion and as an
operand to the # or ## operators have a behavior that is
well-understood and
--
2.34.1
Signature · 2 lines
Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH v2 1/6][RESEND] automation/eclair: address violations of MISRA C Rule 20.7
Quoted 13 lines · Nicola Vetrini
Quoted 12 lines · Stefano Stabellini
Quoted 11 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The helper macro
bitmap_switchhas parameters that cannot be parenthesized in order to comply with the rule, as that would break its functionality. Moreover, the risk of misuse due developer confusion is deemed not substantial enough to warrant a more involved refactor, thus the macro is deviated for this rule.No functional change.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Nicola Vetrini <[email protected]>If possible, I would prefer we used a SAF in-code comment deviation. If that doesn't work for any reason this patch is fine and I'd ack it.
Would that be an improvement for safety in your opinion?
Not for safety, as they both achieve the same result, but for maintainability. The deviations under deviations.ecl are project-wide so in my opinion should only be used for project-wide global deviations from a rule. Specific deviations for functions should be done with SAF. Another reason for this is that deviations under deviations.ecl need to be manually ported to any other static analyzer one by one while SAF is meant to support multiple automatically.
More importantly if we change deviations.ecl, deviations.rst should also be changed the same way. I would say that this is required at a minimum as deviations.ecl and deviations.rst should be in sync.
Quoted 42 lines
Quoted 37 lines
Quoted 37 lines
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ 1 file changed, 8 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +0
-0@@ -463,6 +463,14 @@ of this macro do not lead to developer confusion, andcan thus be deviated."
-config=MC3R1.R20.7,reports+={safe,
"any_area(any_loc(any_exp(macro(^count_args_$))))"}
-doc_end+-doc_begin="The arguments of macro
bitmap_switchmacro can't be parenthesized as
+the rule would require, without breaking the functionality of the macro. This is
+a specialized local helper macro only used within thebitmap.hheader, so it is
+less likely to lead to developer confusion and it is deemed better to deviate it."+-file_tag+={xen_bitmap_h, "^xen/include/xen/bitmap\\.h$"} +-config=MC3R1.R20.7,reports+={safe,"any_area(any_loc(any_exp(macro(loc(file(xen_bitmap_h))&&^bitmap_switch$))))"} +-doc_end
+
-doc_begin="Uses of variadic macros that have one of their arguments
defined as
a macro and used within the body for both ordinary parameter expansion
and as an
operand to the # or ## operators have a behavior that is well-understood
and
--
2.34.1Signature · 2 lines
Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH v2 1/6][RESEND] automation/eclair: address violations of MISRA C Rule 20.7
In reply to Nicola VetriniQuoted 9 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The helper macro
bitmap_switchhas parameters that cannot be parenthesized in order to comply with the rule, as that would break its functionality. Moreover, the risk of misuse due developer confusion is deemed not substantial enough to warrant a more involved refactor, thus the macro is deviated for this rule.
Quoted 3 lines
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
I would have preferred a SAF tag instead but it can be done later
Quoted 26 lines
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 8 ++++++++ 1 file changed, 8 insertions(+)automation/eclair_analysis/ECLAIR/deviations.ecl +8
-0@@ -463,6 +463,14 @@ of this macro do not lead to developer confusion, and can thus be deviated." -config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(^count_args_$))))"} -doc_end +-doc_begin="The arguments of macro bitmap_switch macro can't be parenthesized as +the rule would require, without breaking the functionality of the macro. This is +a specialized local helper macro only used within the bitmap.h header, so it is +less likely to lead to developer confusion and it is deemed better to deviate it." +-file_tag+={xen_bitmap_h, "^xen/include/xen/bitmap\\.h$"} +-config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(any_exp(macro(loc(file(xen_bitmap_h))&&^bitmap_switch$))))"} +-doc_end + -doc_begin="Uses of variadic macros that have one of their arguments defined as a macro and used within the body for both ordinary parameter expansion and as an operand to the # or ## operators have a behavior that is well-understood andSignature · 1 line
2.34.1
PATCH RESEND v2 2/6 xen/self-tests: address violations of MISRA rule 20.7
In reply to Nicola VetriniMISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter.
No functional change.
---
In this case the use of parentheses can detect misuses of the COMPILE_CHECK macro for the fn argument that happen to pass the compile-time check (see e.g. https://godbolt.org/z/n4zTdz595).
An alternative would be to deviate these macros, but since they are used to check the correctness of other code it seemed the better alternative to futher ensure that all usages of the macros are safe.
--- xen/include/xen/self-tests.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
xen/include/xen/self-tests.h +4 -4
@@ -19,11 +19,11 @@#if !defined(CONFIG_CC_IS_CLANG ) ||CONFIG_CLANG_VERSION >=80000 #define COMPILE_CHECK (fn, val, res) \ do { \ - typeof(fn(val)) real = fn(val); \ + typeof((fn)(val)) real = (fn)(val); \ \ if ( !__builtin_constant_p(real) ) \ asm ( ".error \"'" STR(fn(val)) "' not compile-time constant\"" ); \ - else if ( real != res ) \ + else if ( real != (res) ) \ asm ( ".error \"Compile time check '" STR(fn(val) == res) "' failed\"" ); \ } while ( 0 )#else
@@ -37,9 +37,9 @@*/ #define RUNTIME_CHECK (fn, val, res) \ do { \ - typeof(fn(val)) real = fn(HIDE(val)); \ + typeof((fn)(val)) real = (fn)(HIDE(val)); \ \ - if ( real != res ) \ + if ( real != (res) ) \ panic("%s: %s(%s) expected %u, got %u\n", \ __func__, #fn, #val, real, res); \ } while ( 0 )
Signature · 1 line
2.34.1
PATCH RESEND v2 3/6 xen/guest_access: address violations of MISRA rule 20.7
In reply to Nicola VetriniMISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter.
No functional change.
--- xen/include/xen/guest_access.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
xen/include/xen/guest_access.h +2 -2
@@ -49,9 +49,9 @@ ((XEN_GUEST_HANDLE(type)) { &(hnd).p->fld })#define guest_handle_from_ptr (ptr, type) \ - ((XEN_GUEST_HANDLE_PARAM(type)) { (type *)ptr }) + ((XEN_GUEST_HANDLE_PARAM(type)) { (type *)(ptr) })#define const_guest_handle_from_ptr (ptr, type) \ - ((XEN_GUEST_HANDLE_PARAM(const_##type)) { (const type *)ptr }) + ((XEN_GUEST_HANDLE_PARAM(const_##type)) { (const type *)(ptr) })/* * Copy an array of objects to guest context via a guest handle,
Signature · 1 line
2.34.1
PATCH RESEND v2 4/6 automation/eclair_analysis: address violations of MISRA C Rule 20.7
In reply to Nicola VetriniMISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The local helpers GRP2 and XADD in the x86 emulator use their first argument as the constant expression for a case label. This pattern is deviated project-wide, because it is very unlikely to induce developer confusion and result in the wrong control flow being carried out.
No functional change.
---
Changes in v2:
- Introduce a deviation instead of adding parentheses
--- automation/eclair_analysis/ECLAIR/deviations.ecl | 6 ++++-- docs/misra/deviations.rst | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-)
automation/eclair_analysis/ECLAIR/deviations.ecl +4 -2
@@ -428,13 +428,15 @@ unexpected result when the structure is given as argument to a sizeof() operator -doc_begin="Code violating Rule 20.7 is safe when macro parameters are used: (1) as function arguments; (2) as macro arguments; (3) as array indices; (4) as lhs -in assignments; (5) as initializers, possibly designated, in initalizer lists." +in assignments; (5) as initializers, possibly designated, in initalizer lists; +(6) as the constant expression in a switch clause label." -config=MC3R1.R20.7,expansion_context= {safe, "context(__call_expr_arg_contexts)"}, {safe, "left_right(^[(,\\[]$,^[),\\]]$)"}, {safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(array_subscript_expr), subscript)))"}, {safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(operator(assign), lhs)))"}, -{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(init_list_expr||designated_init_expr), init)))"} +{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(init_list_expr||designated_init_expr), init)))"}, +{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(case_stmt), lower||upper)))"} -doc_end -doc_begin="Violations involving the __config_enabled macros cannot be fixed without
docs/misra/deviations.rst +2 -1
@@ -376,7 +376,8 @@ Deviations related to MISRA C:2012 Rules: (2) as macro arguments; (3) as array indices; (4) as lhs in assignments; - (5) as initializers, possibly designated, in initalizer lists. + (5) as initializers, possibly designated, in initalizer lists; + (6) as constant expressions of switch case labels. - Tagged as `safe` for ECLAIR. * - R20.7
Signature · 1 line
2.34.1
Re: [XEN PATCH v2 4/6][RESEND] automation/eclair_analysis: address violations of MISRA C Rule 20.7
Quoted 9 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The local helpers GRP2 and XADD in the x86 emulator use their first argument as the constant expression for a case label. This pattern is deviated project-wide, because it is very unlikely to induce developer confusion and result in the wrong control flow being carried out.
Quoted 3 lines
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
Re: [XEN PATCH v2 4/6][RESEND] automation/eclair_analysis: address violations of MISRA C Rule 20.7
In reply to Nicola VetriniQuoted 9 lines · Nicola Vetrini
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses".
The local helpers GRP2 and XADD in the x86 emulator use their first argument as the constant expression for a case label. This pattern is deviated project-wide, because it is very unlikely to induce developer confusion and result in the wrong control flow being carried out.
Quoted 3 lines
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
Quoted 47 lines
---
Changes in v2:
- Introduce a deviation instead of adding parentheses--- automation/eclair_analysis/ECLAIR/deviations.ecl | 6 ++++-- docs/misra/deviations.rst | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-)automation/eclair_analysis/ECLAIR/deviations.ecl +4
-2@@ -428,13 +428,15 @@ unexpected result when the structure is given as argument to a sizeof() operator -doc_begin="Code violating Rule 20.7 is safe when macro parameters are used: (1) as function arguments; (2) as macro arguments; (3) as array indices; (4) as lhs -in assignments; (5) as initializers, possibly designated, in initalizer lists." +in assignments; (5) as initializers, possibly designated, in initalizer lists; +(6) as the constant expression in a switch clause label." -config=MC3R1.R20.7,expansion_context= {safe, "context(__call_expr_arg_contexts)"}, {safe, "left_right(^[(,\\[]$,^[),\\]]$)"}, {safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(array_subscript_expr), subscript)))"}, {safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(operator(assign), lhs)))"}, -{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(init_list_expr||designated_init_expr), init)))"} +{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(init_list_expr||designated_init_expr), init)))"}, +{safe, "context(skip_to(__expr_non_syntactic_contexts, stmt_child(node(case_stmt), lower||upper)))"} -doc_end -doc_begin="Violations involving the __config_enabled macros cannot be fixed withoutdocs/misra/deviations.rst +2
-1@@ -376,7 +376,8 @@ Deviations related to MISRA C:2012 Rules: (2) as macro arguments; (3) as array indices; (4) as lhs in assignments; - (5) as initializers, possibly designated, in initalizer lists. + (5) as initializers, possibly designated, in initalizer lists; + (6) as constant expressions of switch case labels. - Tagged as `safe` for ECLAIR. * - R20.7Signature · 1 line
2.34.1
PATCH RESEND v2 5/6 x86/irq: address violations of MISRA C Rule 20.7
In reply to Nicola VetriniMISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter.
No functional change.
---
Note that the rule does not apply to f because that parameter is not used as an expression in the macro, but rather as an identifier.
--- xen/include/xen/irq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
xen/include/xen/irq.h +1 -1
@@ -178,7 +178,7 @@ extern struct pirq *pirq_get_info(struct domain *d, int pirq);#define pirq_field (d, p, f, def) ({ \ const struct pirq *__pi = pirq_info(d, p); \ - __pi ? __pi->f : def; \ + __pi ? __pi->f : (def); \ })#define pirq_to_evtchn (d, pirq) pirq_field(d, pirq, evtchn, 0)#define pirq_masked (d, pirq) pirq_field(d, pirq, masked, 0)
Signature · 1 line
2.34.1
PATCH RESEND v2 6/6 automation/eclair_analysis: clean ECLAIR configuration scripts
In reply to Nicola VetriniRemove from the ECLAIR integration scripts an unused option, which was already ignored, and make the help texts consistent with the rest of the scripts.
No functional change.
--- automation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
automation/eclair_analysis/ECLAIR/analyze.sh +1 -2
@@ -11,7 +11,7 @@ fatal() { } usage() { - fatal "Usage: ${script_name} <ARM64|X86_64> <Set0|Set1|Set2|Set3>" + fatal "Usage: ${script_name} <ARM64|X86_64> <accepted|monitored>" } if [[ $# -ne 2 ]]; then
@@ -40,7 +40,6 @@ ECLAIR_REPORT_LOG=${ECLAIR_OUTPUT_DIR}/REPORT.log if [[ "$1" = "X86_64" ]]; then export CROSS_COMPILE= export XEN_TARGET_ARCH=x86_64 - EXTRA_ECLAIR_ENV_OPTIONS=-disable=MC3R1.R20.7 elif [[ "$1" = "ARM64" ]]; then export CROSS_COMPILE=aarch64-linux-gnu- export XEN_TARGET_ARCH=arm64
Signature · 1 line
2.34.1
Re: [XEN PATCH v2 6/6][RESEND] automation/eclair_analysis: clean ECLAIR configuration scripts
Quoted 7 lines · Nicola Vetrini
Remove from the ECLAIR integration scripts an unused option, which was already ignored, and make the help texts consistent with the rest of the scripts.
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
Quoted 28 lines
--- automation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)automation/eclair_analysis/ECLAIR/analyze.sh +1
-2@@ -11,7 +11,7 @@ fatal() { } usage() { - fatal "Usage: ${script_name} <ARM64|X86_64> <Set0|Set1|Set2|Set3>" + fatal "Usage: ${script_name} <ARM64|X86_64> <accepted|monitored>" } if [[ $# -ne 2 ]]; then@@ -40,7 +40,6 @@ ECLAIR_REPORT_LOG=${ECLAIR_OUTPUT_DIR}/REPORT.log if [[ "$1" = "X86_64" ]]; then export CROSS_COMPILE= export XEN_TARGET_ARCH=x86_64 - EXTRA_ECLAIR_ENV_OPTIONS=-disable=MC3R1.R20.7 elif [[ "$1" = "ARM64" ]]; then export CROSS_COMPILE=aarch64-linux-gnu- export XEN_TARGET_ARCH=arm64Signature · 1 line
2.34.1
Re: [XEN PATCH v2 6/6][RESEND] automation/eclair_analysis: clean ECLAIR configuration scripts
In reply to Nicola VetriniQuoted 7 lines · Nicola Vetrini
Remove from the ECLAIR integration scripts an unused option, which was already ignored, and make the help texts consistent with the rest of the scripts.
No functional change.
Signed-off-by Nicola Vetrini <[email protected]>
Quoted 28 lines
--- automation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)automation/eclair_analysis/ECLAIR/analyze.sh +1
-2@@ -11,7 +11,7 @@ fatal() { } usage() { - fatal "Usage: ${script_name} <ARM64|X86_64> <Set0|Set1|Set2|Set3>" + fatal "Usage: ${script_name} <ARM64|X86_64> <accepted|monitored>" } if [[ $# -ne 2 ]]; then@@ -40,7 +40,6 @@ ECLAIR_REPORT_LOG=${ECLAIR_OUTPUT_DIR}/REPORT.log if [[ "$1" = "X86_64" ]]; then export CROSS_COMPILE= export XEN_TARGET_ARCH=x86_64 - EXTRA_ECLAIR_ENV_OPTIONS=-disable=MC3R1.R20.7 elif [[ "$1" = "ARM64" ]]; then export CROSS_COMPILE=aarch64-linux-gnu- export XEN_TARGET_ARCH=arm64Signature · 1 line
2.34.1
Hi Oleksii,
I would like to ask for a release-ack as the patch series makes very few changes outside of the static analysis configuration. The few changes to the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.
Quoted 38 lines · Nicola Vetrini
Hi all,
this series addresses several violations of Rule 20.7, as well as a small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.
Note that by applying this series the rule has a few leftover violations. Most of those are in x86 code in
xen/arch/x86/include/asm/msi.h.
I did send a patch [1] to deal with those, limited only to addressing the MISRA violations, but in the end it was dropped in favour of a more general cleanup of the file upon agreement, so this is why those changes are not included here.Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing listNicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7 x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scriptsautomation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- automation/eclair_analysis/ECLAIR/deviations.ecl | 14 ++++++++++++-- docs/misra/deviations.rst | 3 ++- xen/include/xen/guest_access.h | 4 ++-- xen/include/xen/irq.h | 2 +- xen/include/xen/self-tests.h | 8 ++++---- 6 files changed, 22 insertions(+), 12 deletions(-)Signature · 1 line
2.34.1
Quoted 4 lines · Stefano Stabellini
I would like to ask for a release-ack as the patch series makes very few changes outside of the static analysis configuration. The few changes to the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.
While continuing to touch automation/ may be okay, I really think time has passed for further Misra changes in 4.19, unless they're fixing actual bugs of course. Just my personal view though ...
Jan
Quoted 39 lines · Nicola Vetrini
Quoted 38 lines
Hi all,
this series addresses several violations of Rule 20.7, as well as a small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.
Note that by applying this series the rule has a few leftover violations. Most of those are in x86 code in
xen/arch/x86/include/asm/msi.h.
I did send a patch [1] to deal with those, limited only to addressing the MISRA violations, but in the end it was dropped in favour of a more general cleanup of the file upon agreement, so this is why those changes are not included here.Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing listNicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7 x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scriptsautomation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- automation/eclair_analysis/ECLAIR/deviations.ecl | 14 ++++++++++++-- docs/misra/deviations.rst | 3 ++- xen/include/xen/guest_access.h | 4 ++-- xen/include/xen/irq.h | 2 +- xen/include/xen/self-tests.h | 8 ++++---- 6 files changed, 22 insertions(+), 12 deletions(-)Signature · 1 line
2.34.1
Quoted 8 lines · Jan Beulich
Quoted 6 lines · Stefano Stabellini
I would like to ask for a release-ack as the patch series makes very few
changes outside of the static analysis configuration. The few changes to
the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.
Quoted 5 lines
While continuing to touch automation/ may be okay, I really think time has
passed for further Misra changes in 4.19, unless they're fixing actual bugs
of course. Just my personal view though ...
I am not quite sure I understand the concern. From my perspective, the patch series addresses several MISRA violations without introducing any functional changes. It seems safe to incorporate these MISRA changes even at this stage of the release.
~ Oleksii
Quoted 53 lines
Jan
Quoted 49 lines · Nicola Vetrini
Quoted 48 lines
Hi all,
this series addresses several violations of Rule 20.7, as well as a
small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.Note that by applying this series the rule has a few leftover violations.
Most of those are in x86 code inxen/arch/x86/include/asm/msi.h. I did send a patch [1] to deal with those, limited only to addressing the MISRA
violations, but in the end it was dropped in favour of a more general cleanup of
the file upon agreement, so this is why those changes are not included here.Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing listNicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7
x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scriptsautomation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- automation/eclair_analysis/ECLAIR/deviations.ecl | 14
++++++++++++--
docs/misra/deviations.rst | 3 ++- xen/include/xen/guest_access.h | 4 ++-- xen/include/xen/irq.h | 2 +- xen/include/xen/self-tests.h | 8 ++++----6 files changed, 22 insertions(+), 12 deletions(-)Signature · 1 line
2.34.1
Quoted 14 lines · On Wed, 26 Jun 2024, [email protected] wrote:
Quoted 8 lines · Jan Beulich
Quoted 6 lines · Stefano Stabellini
I would like to ask for a release-ack as the patch series makes very few
changes outside of the static analysis configuration. The few changes to
the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.Quoted 5 lines
While continuing to touch automation/ may be okay, I really think time has
passed for further Misra changes in 4.19, unless they're fixing actual bugs
of course. Just my personal view though ...
Quoted 4 lines
I am not quite sure I understand the concern. From my perspective, the patch series addresses several MISRA violations without introducing any functional changes. It seems safe to incorporate these MISRA changes even at this stage of the release.
I agree with you but I guess Jan's point is that every change even small could introduce a regression. This is your decision.
This is the updated version:
https://marc.info/?l=xen-devel&m=171940854121984
Quoted 14 lines · On 26.06.2024 19:42, [email protected] wrote:
Quoted 8 lines · Jan Beulich
Quoted 6 lines · Stefano Stabellini
I would like to ask for a release-ack as the patch series makes very few
changes outside of the static analysis configuration. The few changes to
the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.Quoted 5 lines
While continuing to touch automation/ may be okay, I really think time has
passed for further Misra changes in 4.19, unless they're fixing actual bugs
of course. Just my personal view though ...
Quoted 4 lines
I am not quite sure I understand the concern. From my perspective, the patch series addresses several MISRA violations without introducing any functional changes. It seems safe to incorporate these MISRA changes even at this stage of the release.
It's your call in the end. Seeing we're not even at RC1 yet (which I had long expected us to be past), perhaps I'm overly concerned.
Jan
Quoted 8 lines · Stefano Stabellini
Hi Oleksii,
I would like to ask for a release-ack as the patch series makes very few
changes outside of the static analysis configuration. The few changes to
the Xen code are very limited, straightforward and makes the code better, see patch #3 and #5.
~ Oleksii
Quoted 50 lines · Nicola Vetrini
Quoted 47 lines
Hi all,
this series addresses several violations of Rule 20.7, as well as a small fix to the ECLAIR integration scripts that do not influence the current behaviour, but were mistakenly part of the upstream configuration.
Note that by applying this series the rule has a few leftover violations.
Most of those are in x86 code inxen/arch/x86/include/asm/msi.h. I did send a patch [1] to deal with those, limited only to addressing the MISRA
violations, but in the end it was dropped in favour of a more general cleanup of
the file upon agreement, so this is why those changes are not included here.Changes in v2:
- refactor patch 4 to deviate the pattern, instead of fixing the violations
- The series has been resent because I forgot to properly Cc the mailing listNicola Vetrini (6):
automation/eclair: address violations of MISRA C Rule 20.7 xen/self-tests: address violations of MISRA rule 20.7 xen/guest_access: address violations of MISRA rule 20.7 automation/eclair_analysis: address violations of MISRA C Rule 20.7
x86/irq: address violations of MISRA C Rule 20.7 automation/eclair_analysis: clean ECLAIR configuration scriptsautomation/eclair_analysis/ECLAIR/analyze.sh | 3 +-- automation/eclair_analysis/ECLAIR/deviations.ecl | 14
++++++++++++--
docs/misra/deviations.rst | 3 ++- xen/include/xen/guest_access.h | 4 ++-- xen/include/xen/irq.h | 2 +- xen/include/xen/self-tests.h | 8 ++++----6 files changed, 22 insertions(+), 12 deletions(-)Signature · 1 line
2.34.1