net: stmmac: Refactor FPE as a separate module
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest8 patches 2 repliesApplied 8/8
- v78 patches 3 repliesSuperseded
- v66 patches 3 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 6 patches | 2 replies | Superseded | |
| v4 | 6 patches | 0 replies | Superseded | |
| v3 | 6 patches | 2 replies | Superseded | |
| v2 | 8 patches | 5 replies | Superseded | |
| v1 | 5 patches | 12 replies | Superseded |
Changes in v8 from the cover letter
1. Reorder functions in their natural calling order
2. Unexport stmmac_fpe_configure() and make it static
3. Swap 3rd patch and 4th patch in V7
Patches in v8 All 8 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | net: stmmac: Introduce separate files for FPE implementationdrivers/ drivers/ drivers/ +8 more | +405 | 0 replies | Applied |
| 2/8 | net: stmmac: Rework macro definitions for gmac4 and xgmacdrivers/ | +39 | 0 replies | Applied |
| 3/8 | net: stmmac: Introduce stmmac_fpe_supported()drivers/ drivers/ drivers/ +1 more | +12 | 0 replies | Applied |
| 4/8 | net: stmmac: Refactor FPE functions to generic versiondrivers/ drivers/ drivers/ +8 more | +105 | 0 replies | Applied |
| 5/8 | net: stmmac: Get the TC number of net_device by netdev_get_num_tc()drivers/ | +1 | 0 replies | Applied |
| 6/8 | net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQdrivers/ drivers/ | +2 | 0 replies | Applied |
| 7/8 | net: stmmac: xgmac: Complete FPE supportdrivers/ drivers/ drivers/ | +47 | 0 replies | Applied |
| 8/8 | net: stmmac: xgmac: Enable FPE for tc-mqprio/tc-tapriodrivers/ | +2 | 0 replies | Applied |
Reviews trailers per patch
3 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Simon Horman | Vladimir Oltean |
|---|---|---|
| Series | R-b | |
| 1/8 | R-b | R-b |
| 2/8 | R-b | |
| 3/8 | ||
| 4/8 | ||
| 5/8 | ||
| 6/8 | R-b | |
| 7/8 | ||
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v8 0/8] net: stmmac: Refactor FPE as a separate module
Refactor FPE implementation by moving common code for DWMAC4 and DWXGMAC into a separate FPE module.
FPE implementation for DWMAC4 and DWXGMAC differs only for:
1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS
2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1
3) Bit offset of Frame Preemption Interrupt Enable
Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a
Changes in v8:
1. Reorder functions in their natural calling order
2. Unexport stmmac_fpe_configure() and make it static
3. Swap 3rd patch and 4th patch in V7
V7:
https://patchwork.kernel.org/project/netdevbpf/list/?series=905021&state=%2A&archive=both
Changes in v7:
1. Split stmmac_fpe_supported() changes into a separate patch
2. Unexport stmmac_fpe_send_mpacket() and make it static
3. Convert to netdev_get_num_tc()
4. Commit message update for the 3rd patch
V6:
https://patchwork.kernel.org/project/netdevbpf/list/?series=904502&state=%2A&archive=both
Changes in v6:
1. Introduce stmmac_fpe_supported() to improve compatibility
2. Remove redundant fpesel check
3. Remove redundant parameters of stmmac_fpe_configure()
V5:
https://patchwork.kernel.org/project/netdevbpf/list/?series=903628&state=%2A&archive=both
Changes in v5:
1. Fix build errors reported by kernel test robot:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
Changes in v4:
1. Update FPE IRQ handling
2. Check fpesel bit and stmmac_fpe_reg pointer to guarantee that driver does not crash on a certain platform that FPE is to be implemented
Changes in v3:
1. Drop stmmac_fpe_ops and refactor FPE functions to generic version to avoid function pointers
2. Drop the _SHIFT macro definitions
Changes in v2:
1. Split patches to easily review
2. Use struct as function param to keep param list short
3. Typo fixes in commit message and title
Furong Xu (8):
net: stmmac: Introduce separate files for FPE implementation
net: stmmac: Rework macro definitions for gmac4 and xgmac
net: stmmac: Introduce stmmac_fpe_supported()
net: stmmac: Refactor FPE functions to generic version
net: stmmac: Get the TC number of net_device by netdev_get_num_tc()
net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ
net: stmmac: xgmac: Complete FPE support
net: stmmac: xgmac: Enable FPE for tc-mqprio/tc-taprio
drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 - .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 11 +- drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 150 ------- drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 26 -- .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 6 +- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 31 +- drivers/net/ethernet/stmicro/stmmac/hwif.c | 7 + drivers/net/ethernet/stmicro/stmmac/hwif.h | 20 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 11 +- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 8 +- .../net/ethernet/stmicro/stmmac/stmmac_fpe.c | 413 ++++++++++++++++++ .../net/ethernet/stmicro/stmmac/stmmac_fpe.h | 33 ++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 165 +------ .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 4 +- 15 files changed, 476 insertions(+), 412 deletions(-) create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
Signature · 1 line
2.34.1