Skip to content

delayed_node leak bug

Leo Martins linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- combine warn and if statement

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: fix refcount leak in debug assertionfs/btrfs/delayed-inode.c+4 -10 replies
2/2btrfs: warn if leaking delayed_nodesfs/btrfs/disk-io.c+2 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchFilipe MananaQu Wenruo
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] delayed_node leak bug

Currently investigating a bug I believe is caused by leaked delayed_nodes. The following patches fix a potential delayed_node leak in an assert function (I don't believe this is the cause of the bug) and add a warning if a root still contains delayed_nodes when it is freed.

A little more on the bug I'm investigating in case anyone has seen something similar...

Started seeing soft lockups in btrfs_kill_all_delayed_nodes due to an infinte loop. Further investigation showed that there was a delayed_node that was not being erased from the root->delayed_nodes xarray. The delayed_node had a reference count of one meaning that it is failing to be released somewhere.

V2 CHANGES:
- combine warn and if statement

Leo Martins (2):
btrfs: fix refcount leak in debug assertion
btrfs: warn if leaking delayed_nodes

 fs/btrfs/delayed-inode.c | 5 ++++-
 fs/btrfs/disk-io.c       | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.47.1