delayed_node leak bug
v2 cover delayed_node leak bug
Currently investigating a bug I believe is caused by leaked delayed_nodes. The following patches fix a potential delayed_node leak in an assert function (I don't believe this is the cause of the bug) and add a warning if a root still contains delayed_nodes when it is freed.
A little more on the bug I'm investigating in case anyone has seen something similar...
Started seeing soft lockups in btrfs_kill_all_delayed_nodes due to an infinte loop. Further investigation showed that there was a delayed_node that was not being erased from the root->delayed_nodes xarray. The delayed_node had a reference count of one meaning that it is failing to be released somewhere.
V2 CHANGES:
- combine warn and if statement
Leo Martins (2):
btrfs: fix refcount leak in debug assertion
btrfs: warn if leaking delayed_nodes
fs/btrfs/delayed-inode.c | 5 ++++- fs/btrfs/disk-io.c | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.47.1
PATCH v2 1/2 btrfs: fix refcount leak in debug assertion
If the delayed_root is not empty we are increasing the number of references to a delayed_node without decreasing it, causing a leak. Fix by decrementing the delayed_node reference count.
V2 CHANGES:
- combine warn and if statement
--- fs/btrfs/delayed-inode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/btrfs/delayed-inode.c +4 -1
@@ -1377,7 +1377,10 @@ static int btrfs_wq_run_delayed_node(struct btrfs_delayed_root *delayed_root,void btrfs_assert_delayed_root_empty (struct btrfs_fs_info *fs_info) { -WARN_ON (btrfs_first_delayed_node (fs_info->delayed_root)); +struct btrfs_delayed_node *node =btrfs_first_delayed_node (fs_info->delayed_root); + +if (WARN_ON (node)) +refcount_dec (&node->refs); }static bool could_end_wait (struct btrfs_delayed_root *delayed_root,int seq)
Signature · 1 line
2.47.1
PATCH v2 2/2 btrfs: warn if leaking delayed_nodes
In reply to Leo MartinsAdd a warning for leaked delayed_nodes when putting a root. We currently do this for inodes, but not delayed_nodes.
V2 CHANGES:
- no changes
--- fs/btrfs/disk-io.c | 2 ++ 1 file changed, 2 insertions(+)
fs/btrfs/disk-io.c +2 -0
@@ -1835,6 +1835,8 @@ void btrfs_put_root(struct btrfs_root *root)if (refcount_dec_and_test (&root->refs)) {if (WARN_ON (!xa_empty (&root->inodes)))xa_destroy (&root->inodes); +if (WARN_ON (!xa_empty (&root->delayed_nodes))) +xa_destroy (&root->delayed_nodes);WARN_ON (test_bit (BTRFS_ROOT_DEAD_RELOC_TREE , &root->state));if (root->anon_dev)free_anon_bdev (root->anon_dev);
Signature · 1 line
2.47.1
Quoted 8 lines · Leo Martins
Currently investigating a bug I believe is caused by leaked
delayed_nodes. The following patches fix a potentialdelayed_nodeleak in an assert function (I don't believe this is the cause of the bug) and add a warning if a root still containsdelayed_nodeswhen it is freed.A little more on the bug I'm investigating in case anyone has seen something similar...
Quoted 8 lines
Started seeing soft lockups in
btrfs_kill_all_delayed_nodesdue to an infinte loop. Further investigation showed that there was adelayed_nodethat was not being erased from theroot->delayed_nodesxarray. Thedelayed_nodehad a reference count of one meaning that it is failing to be released somewhere.V2 CHANGES:
- combine warn and if statement
For the changelog, if you have one in the cover letter, there is no need to put changelog into every patch.
And even if you want to add a changelog to each patch, please add them after the "---" line, so git-am will discard the changelog.
No need to send the patches again, such a small problem will be corrected when I merge them into for-next branch. Just a small reminder for future patches.
Thanks,
Qu
Quoted 9 lines
Leo Martins (2):
btrfs: fix refcount leak in debug assertion
btrfs: warn if leakingdelayed_nodesfs/btrfs/delayed-inode.c | 5 ++++- fs/btrfs/disk-io.c | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-)