Skip to content

mptcp: improve ADD_ADDR timeout handling

Geliang Tang mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 5 repliesIn review
  2. v33 patches 15 repliesSuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- rollback to v2, just use icsk->icsk_rto.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mptcp: make ADD_ADDR retransmission timeout adaptiveDocumentation/networking/mptcp-sysctl.rst net/mptcp/pm.c+26 -61 reply
2/2selftests: mptcp: remove add_addr_timeout settingstools/testing/selftests/net/mptcp/mptcp_join.sh+0 -31 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph PaaschMatthieu Baerts (NGI0)
SeriesR-b
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH mptcp-next v4 0/2] mptcp: improve ADD_ADDR timeout handling

From: Geliang Tang <[email protected]>

v4:
- rollback to v2, just use icsk->icsk_rto.

Depends on:
- mptcp: disable add_addr retrans, v2

Based-on: <[email protected]>

v3:
- a new patch, remove duplicate sk_reset_timer call
- use __tcp_set_rto() * 2 instead of icsk->icsk_rto
- update selftests.
- https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

v2:
- do not rename add_addr_timeout
- use icsk->icsk_rto instead of tp->srtt_us
- increase the time after each retransmission
- https://patchwork.kernel.org/project/mptcp/patch/40706ad511220729207ccd7cf48e320e4d0d7dea.1754028199.git.tanggeliang@kylinos.cn/

v1:
- https://patchwork.kernel.org/project/mptcp/cover/[email protected]/

Geliang Tang (2):
mptcp: make ADD_ADDR retransmission timeout adaptive
selftests: mptcp: remove add_addr_timeout settings

 Documentation/networking/mptcp-sysctl.rst     |  4 +--
 net/mptcp/pm.c                                | 28 ++++++++++++++++---
 .../testing/selftests/net/mptcp/mptcp_join.sh |  3 --
 3 files changed, 26 insertions(+), 9 deletions(-)
Signature · 1 line
2.48.1