Skip to content

firmware: stratix10-rsu: expose QSPI flash size and erase size from firmware

[email protected] lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesIn review
  2. v33 patches 0 repliesSuperseded
  3. v23 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Rebased onto dinguyen/socfpga_svc_fixes_for_v7.2 (for v7.2
integration), instead of torvalds/master.
- Probe error-path teardown from v3 patch 3/3 is dropped; that is
already in dinguyen's tree in commit
bfd2eb9bba54 ("firmware: stratix10-rsu: Fix NULL deref on rsu_send_msg() timeout in probe"), which centralizes probe cleanup with goto labels.
- Patch 3/3 is narrowed to stratix10_rsu_remove() only (1 line); probe
paths and return 0 on success are no longer in this series.
- Patch 2/3 wires COMMAND_RSU_GET_DEVICE_INFO probe errors into the
rebased goto remove_async_client path.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Documentation: ABI: add stratix10-rsu QSPI size and erase_size sysfsDocumentation/ABI/testing/sysfs-devices-platform-stratix10-rsu+58 -00 replies
2/3firmware: stratix10-rsu: Add flash device info retrieval via SMCdrivers/firmware/stratix10-rsu.c drivers/firmware/stratix10-svc.c include/linux/firmware/intel/stratix10-smc.h +1 more+314 -170 replies
3/3firmware: stratix10-rsu: remove async client before freeing channel in remove()drivers/firmware/stratix10-rsu.c+1 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] firmware: stratix10-rsu: expose QSPI flash size and erase size from firmware

From: Tze Yee Ng <[email protected]>

This series lets user space read per-device QSPI flash size and erase size for the Intel Stratix 10 RSU driver, using the existing service layer SMC path.

Patch 1 documents the new sysfs attributes (size0-size3 and erase_size0-erase_size3).

Patch 2 implements COMMAND_RSU_GET_DEVICE_INFO in the RSU and service drivers, caches up to four devices in the driver, and adds the sysfs files.

Patch 3 fixes remove() teardown after the async client is registered:
call stratix10_svc_remove_async_client() before stratix10_svc_free_channel() so async state is not leaked.

Changes in v4:
- Rebased onto dinguyen/socfpga_svc_fixes_for_v7.2 (for v7.2
integration), instead of torvalds/master.
- Probe error-path teardown from v3 patch 3/3 is dropped; that is
already in dinguyen's tree in commit
bfd2eb9bba54 ("firmware: stratix10-rsu: Fix NULL deref on rsu_send_msg() timeout in probe"), which centralizes probe cleanup with goto labels.
- Patch 3/3 is narrowed to stratix10_rsu_remove() only (1 line); probe
paths and return 0 on success are no longer in this series.
- Patch 2/3 wires COMMAND_RSU_GET_DEVICE_INFO probe errors into the
rebased goto remove_async_client path.

Changes in v3:
- No code changes in all patches, only put Cc: [email protected] # 6.19+ in the sign-off block for the Fixes: tag in Patch 3.

Changes in v2:
- No code changes in all patches, only documentation updates to fix commit title and description in Patch 3.

Tze Yee Ng (3):
Documentation: ABI: add stratix10-rsu QSPI size and erase_size sysfs
firmware: stratix10-rsu: Add flash device info retrieval via SMC
firmware: stratix10-rsu: remove async client before freeing channel in
remove()

 .../sysfs-devices-platform-stratix10-rsu      |  58 +++++
 drivers/firmware/stratix10-rsu.c              | 201 +++++++++++++++++-
 drivers/firmware/stratix10-svc.c              |  94 +++++++-
 include/linux/firmware/intel/stratix10-smc.h  |  25 ++-
 .../firmware/intel/stratix10-svc-client.h     |  12 +-
 5 files changed, 373 insertions(+), 17 deletions(-)
Signature · 1 line
2.43.7