Skip to content

ice: fix DFLT Rx rule handling for promisc and switchdev

Petr Oros intel-wired-lan lkml netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesIn review
  2. v32 patches 4 repliesSuperseded
  3. v22 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Patch 1: reworded the ice_clear_promisc() and the per-VID cleanup comments, and flipped the ice_vsi_clear_vlan_mc_promisc() guard to an early return (noting the clear is best-effort). No functional change.
- Patch 2: no change, added Marcin's and Aleksandr's Reviewed-by.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ice: skip per-VLAN promisc rules when default VSI Rx rule is setdrivers/net/ethernet/intel/ice/ice_main.c+88 -212 replies
2/2ice: preserve uplink DFLT Rx rule on switchdev releasedrivers/net/ethernet/intel/ice/ice_eswitch.c+14 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMarcin SzycikAleksandr LoktionovPatryk HoldaRinitha S
1/2R-b T-b
2/2R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH iwl-net v4 0/2] ice: fix DFLT Rx rule handling for promisc and switchdev

Two fixes for the uplink default VSI Rx rule (DFLT) on E810 when the netdev is in IFF_PROMISC.

Patch 1 drops the redundant per-VLAN promisc expansion that exhausts the FLU pool on a wide VLAN trunk across several PFs.

Patch 2 keeps the DFLT Rx rule across a switchdev teardown instead of clobbering the promisc state the operator asked for.

Changes since v3 (review comments from Marcin Szycik):
- Patch 1: reworded the ice_clear_promisc() and the per-VID cleanup comments, and flipped the ice_vsi_clear_vlan_mc_promisc() guard to an early return (noting the clear is best-effort). No functional change.
- Patch 2: no change, added Marcin's and Aleksandr's Reviewed-by.

Link to v3:
https://lore.kernel.org/all/[email protected]/

Link to v2:
https://lore.kernel.org/all/[email protected]/

Link to v1:
https://lore.kernel.org/all/[email protected]/

Petr Oros (2):
ice: skip per-VLAN promisc rules when default VSI Rx rule is set
ice: preserve uplink DFLT Rx rule on switchdev release

 drivers/net/ethernet/intel/ice/ice_eswitch.c |  18 ++-
 drivers/net/ethernet/intel/ice/ice_main.c    | 109 +++++++++++++++----
 2 files changed, 102 insertions(+), 25 deletions(-)
Signature · 1 line
2.54.0