Skip to content

Add basic Rockchip rk3128 DT support

Johan Jonker linux-arm-kernel linux-devicetree linux-rockchip lkml soc 2 versions – Applied

Status from this message: The following commit has been merged into the timers/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyApplied
  2. v14 patches 9 repliesSuperseded

Changes in v2 from the cover letter

rk3128.dtsi:
remove aliases
add gic interrupts mask defines
add virtual timer interrupts

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: arm: rockchip: Add Rockchip RK3128 Evaluation boardDocumentation/devicetree/bindings/arm/rockchip.yaml+5 -00 replies
2/4dt-bindings: timer: rockchip: add rockchip,rk3128-timerDocumentation/devicetree/bindings/timer/rockchip,rk-timer.yaml+1 -00 replies
3/4ARM: dts: rockchip: add rk3128.dtsiarch/arm/boot/dts/rk3128.dtsi+916 -00 replies
4/4ARM: dts: rockchip: add rk3128-evb.dtsarch/arm/boot/dts/Makefile arch/arm/boot/dts/rk3128-evb.dts+111 -00 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiHeiko Stuebner
1/4A-b
2/4A-b R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Add basic Rockchip rk3128 DT support

Add basic Rockchip rk3128 DT support.

Features:
Quad-core ARM Cortex-A7MP Core processor
Clock & reset unit
Power management unit
Interrupt controller
DMAC
6x 64 bits Timers
4x PWMs
1x 32 bits watchdog

Internal memory:
Internal BootRom
Internal SRAM 8KB

External memory:
Dynamic Memory Interface (DDR3/DDR3L/LPDDR2)
Nand Flash Interface
eMMC Interface
SD/MMC Interface

Connectivity:
SDIO interface
SPI Controller
3x UART controller
4x I2C controllers
4x groups of GPIO (GPIO0~GPIO3), 32 GPIOs per group USB Host2.0
USB OTG2.0

===

The Linux kernel has added a rk3128 clock driver in the past, but the DT is still missing.

In U-boot the rk3128 DT doesn't conform the latest bindings and also the pin definition don't match the TRM.

On request from the U-boot maintainers I submit a basic rk3128 DT.
https://lore.kernel.org/u-boot/[email protected]/

Based on:
https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/rk3128.dtsi
https://github.com/rockchip-linux/kernel/blob/develop-4.4/arch/arm/boot/dts/rk312x.dtsi

rk3128 TRM:
https://rockchip.fr/RK312X%20TRM/

rk3128 datasheet:
https://rockchip.fr/RK3128%20datasheet%20V1.2.pdf

===

NOT TESTED WITH HARDWARE
NO THERMAL PROTECTION

===

Request:
Help with testing on hardware.

===

Changed V2:
rk3128.dtsi:
remove aliases
add gic interrupts mask defines
add virtual timer interrupts

rk3128-evb.dts:
use generic node names
remove underscores in node names
add more aliases
sort

===

Johan Jonker (4):
dt-bindings: arm: rockchip: Add Rockchip RK3128 Evaluation board
dt-bindings: timer: rockchip: add rockchip,rk3128-timer
ARM: dts: rockchip: add rk3128.dtsi
ARM: dts: rockchip: add rk3128-evb.dts

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 .../bindings/timer/rockchip,rk-timer.yaml     |   1 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/rk3128-evb.dts              | 110 +++
 arch/arm/boot/dts/rk3128.dtsi                 | 916 ++++++++++++++++++
 5 files changed, 1033 insertions(+)
 create mode 100644 arch/arm/boot/dts/rk3128-evb.dts
 create mode 100644 arch/arm/boot/dts/rk3128.dtsi

--
2.20.1