Skip to contentSkip to conversation

f2fs: remove unneeded write checkpoint in recover_fsync_data

PATCH Superseded Chao Yu 2 participants 3 messages Sep 22, 2013 – Sep 24, 2013

Subsystems (2)
lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 1/1 f2fs: remove unneeded write checkpoint in recover_fsync_data

Previously, recover_fsync_data still to write checkpoint when there is nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove it.

---
 fs/f2fs/recovery.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/f2fs/recovery.c +4 -1
index 51ef5ee..6988e1b 100644
@@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
 {
 	struct list_head inode_list;
 	int err;
+	int is_writecp = 0;
 
 	fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry",
 			sizeof(struct fsync_inode_entry), NULL);
@@ -436,6 +437,8 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
 	if (list_empty(&inode_list))
 		goto out;
 
+	is_writecp = 1;
+
 	/* step #2: recover data */
 	err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
 	BUG_ON(!list_empty(&inode_list));
@@ -443,7 +446,7 @@ out:
 	destroy_fsync_dnodes(&inode_list);
 	kmem_cache_destroy(fsync_entry_slab);
 	sbi->por_doing = 0;
-	if (!err)
+	if (!err && is_writecp)
 		write_checkpoint(sbi, false);
 	return err;
 }

---

#1 lore raw
Quoted 16 lines · Chao Yu

Previously, recover_fsync_data still to write checkpoint when there is nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove it.

---
 fs/f2fs/recovery.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/f2fs/recovery.c +0 -0
index 51ef5ee..6988e1b 100644

fs/f2fs/recovery.c int recover_fsync_data(struct f2fs_sb_info *sbi) · line 422

Quoted 4 lines
fs/f2fs/recovery.c +1 -0
@@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
 {
 	struct list_head inode_list;
 	int err;
+	int is_writecp = 0;

"need_writecp" may be more suitable.

Thanks,
Gu

Quoted 29 lines
fs/f2fs/recovery.c +3 -3
 	fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry",
 			sizeof(struct fsync_inode_entry), NULL);
@@ -436,6 +437,8 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
 	if (list_empty(&inode_list))
 		goto out;
 
+	is_writecp = 1;
+
 	/* step #2: recover data */
 	err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
 	BUG_ON(!list_empty(&inode_list));
@@ -443,7 +446,7 @@ out:
 	destroy_fsync_dnodes(&inode_list);
 	kmem_cache_destroy(fsync_entry_slab);
 	sbi->por_doing = 0;
-	if (!err)
+	if (!err && is_writecp)
 		write_checkpoint(sbi, false);
 	return err;
 }
---
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

author
#2 lore raw

Hi Gu

Quoted 22 lines

-----Original Message-----
From: Gu Zheng [mailto:[email protected]]
Sent: Monday, September 23, 2013 9:54 AM
To: Chao Yu
Cc: Kim Jaegeuk; [email protected]; [email protected]; [email protected]; 谭姝
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded write checkpoint in recover_fsync_data

Quoted 11 lines · Chao Yu

Previously, recover_fsync_data still to write checkpoint when there is nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove it.

---
 fs/f2fs/recovery.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 11 lines

fs/f2fs/recovery.c int recover_fsync_data(struct f2fs_sb_info *sbi) · line 422

Quoted 9 lines
fs/f2fs/recovery.c index renamed from fs/f2fs/recovery.c +0 -0

51ef5ee..6988e1b 100644

fs/f2fs/recovery.c +1 -0
@@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
 {
 	struct list_head inode_list;
 	int err;
+	int is_writecp = 0;

"need_writecp" may be more suitable.

Okay, it increase readability. I will change it.

Thanks.

Quoted 7 lines

Thanks,
Gu

Quoted 3 lines
fs/f2fs/recovery.c +0 -0
 	fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry",
 			sizeof(struct fsync_inode_entry), NULL); @@ -436,6

+437,8

Quoted 21 lines

@@ int

Quoted 20 lines
fs/f2fs/recovery.c +0 -0
 recover_fsync_data(struct f2fs_sb_info *sbi)
fs/f2fs/recovery.c +3 -2
 	if (list_empty(&inode_list))
 		goto out;
 
+	is_writecp = 1;
+
 	/* step #2: recover data */
 	err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
 	BUG_ON(!list_empty(&inode_list));
@@ -443,7 +446,7 @@ out:
 	destroy_fsync_dnodes(&inode_list);
 	kmem_cache_destroy(fsync_entry_slab);
 	sbi->por_doing = 0;
-	if (!err)
+	if (!err && is_writecp)
 		write_checkpoint(sbi, false);
 	return err;
 }
---
Quoted 6 lines
Quoted 6 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel