f2fs: remove unneeded write checkpoint in recover_fsync_data
Subsystems (2)
PATCH RESEND 1/1 f2fs: remove unneeded write checkpoint in recover_fsync_data
Previously, recover_fsync_data still to write checkpoint when there is nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove it.
---fs/f2fs/recovery.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
fs/f2fs/recovery.c +4 -1
@@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) {struct list_head inode_list;int err; +int need_writecp =0 ; fsync_entry_slab =f2fs_kmem_cache_create ("f2fs_fsync_inode_entry" ,sizeof (struct fsync_inode_entry ),NULL );
@@ -436,6 +437,8 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)if (list_empty (&inode_list)) goto out; + need_writecp =1 ; +/* step #2: recover data */ err =recover_data (sbi, &inode_list,CURSEG_WARM_NODE );BUG_ON (!list_empty (&inode_list));
@@ -443,7 +446,7 @@ out:destroy_fsync_dnodes (&inode_list);kmem_cache_destroy (fsync_entry_slab); sbi->por_doing =0 ; -if (!err) +if (!err && need_writecp)write_checkpoint (sbi, false);return err; }
---
Quoted 7 lines · Chao Yu
Previously,
recover_fsync_datastill to write checkpoint when there is nothing to recover with normal umount image.
It may reduce mount performance and flash memory lifetime, so let's remove it.Signed-off-by Tan Shu <[email protected]>Signed-off-by Yu Chao <[email protected]>
Quoted 42 lines
---
fs/f2fs/recovery.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)fs/f2fs/recovery.c +4
-3@@ -419,6 +419,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) {struct list_head inode_list;int err; +int need_writecp =0 ; fsync_entry_slab =f2fs_kmem_cache_create ("f2fs_fsync_inode_entry" ,sizeof (struct fsync_inode_entry ),NULL );@@ -436,6 +437,8 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)if (list_empty (&inode_list)) goto out; + need_writecp =1 ; +/* step #2: recover data */ err =recover_data (sbi, &inode_list,CURSEG_WARM_NODE );BUG_ON (!list_empty (&inode_list));@@ -443,7 +446,7 @@ out:destroy_fsync_dnodes (&inode_list);kmem_cache_destroy (fsync_entry_slab); sbi->por_doing =0 ; -if (!err) +if (!err && need_writecp)write_checkpoint (sbi, false);return err; } --- --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/