backlight: lms283gf05: use GPIOF_INIT flags when using devm_gpio_request_one()
Subsystems (2)
PATCH 1/1 backlight: lms283gf05: use GPIOF_INIT flags when using devm_gpio_request_one()
GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:
GPIOF_DIR_OUT (0 << 0)
GPIOF_DIR_IN (1 << 0)
So, when !pdata->reset_inverted is 1, the gpio pin can be set as input, instead of output.
To provent this problem, GPIOF_INIT flag should be used when using devm_gpio_request_one().
Signed-off-by Jingoo Han <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Richard Purdie <[email protected]>
--- drivers/video/backlight/lms283gf05.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/video/backlight/lms283gf05.c +2 -1
@@ -159,7 +159,8 @@ static int __devinit lms283gf05_probe(struct spi_device *spi)if (pdata !=NULL ) { ret =devm_gpio_request_one (&spi->dev, pdata->reset_gpio, -GPIOF_DIR_OUT | !pdata->reset_inverted, +GPIOF_DIR_OUT | (!pdata->reset_inverted ? +GPIOF_INIT_HIGH :GPIOF_INIT_LOW ),"LMS285GF05 RESET" );if (ret)return ret;
Signature · 1 line
1.7.2.5