Skip to contentSkip to conversation

MPC83xx SPI driver

U-Boot-Users Ben Warren 5 participants 6 messages Dec 7, 2006

lore
Share & tools
lore

Ben Warren

author
#0 lore raw

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx family of CPUs, but am unsure where to put it. While designed for the MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Suggestions?

regards,
Ben

#1 lore raw
Quoted 19 lines

-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Ben Warren
Sent: den 7 december 2006 22:56
To: uboot
Subject: [U-Boot-Users] MPC83xx SPI driver

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx
family of CPUs, but am unsure where to put it. While designed for the MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Quoted 1 line

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/qe_spi.c perhaps?

Jocke

author
#2 lore raw
Quoted 19 lines · Joakim Tjernlund
Quoted 19 lines

-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Ben Warren
Sent: den 7 december 2006 22:56
To: uboot
Subject: [U-Boot-Users] MPC83xx SPI driver

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx
family of CPUs, but am unsure where to put it. While designed for the MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Quoted 6 lines
Quoted 1 line

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/qe_spi.c perhaps?

Jocke

Doubtful, since the 834x and 8313 don't have QUICC engines. While the control registers appear to be common among all 83xx chips, on these ones transmit and receive are handled by dedicated 32-bit registers rather than the RAM-based descriptor types found in CPMs.

regards,
Ben

#3 lore raw
In reply to Joakim Tjernlund
Quoted 21 lines · Joakim Tjernlund
Quoted 21 lines

-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Ben Warren
Sent: den 7 december 2006 22:56
To: uboot
Subject: [U-Boot-Users] MPC83xx SPI driver

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx
family of CPUs, but am unsure where to put it. While designed for the
MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip
compatibilities, what should the file be called?

Quoted 4 lines
Quoted 1 line

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/ qe_spi.c perhaps?

QE drivers should be drivers/ as well since QE will be on 83xx and 85xx.

- k

#4 lore raw
Quoted 7 lines · On Thu, 7 Dec 2006 16:24:48 -0600 Kumar Gala <[email protected]> wrote:
Quoted 4 lines · Joakim Tjernlund
Quoted 4 lines

cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip
compatibilities, what should the file be called?

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Suggestions?

Does it work on a 8321 in QUICC mode? If so then cpu/mpc83xx/ qe_spi.c perhaps?

QE drivers should be drivers/ as well since QE will be on 83xx and 85xx.

- k

to be specific, the qe driver should belong in drivers/qe/spi.c, and the non-qe driver should be something like drivers/fsl_spi.c.

Kim

#5 lore raw
In reply to Ben Warren
Quoted 9 lines · Ben Warren

Hello,

I'm ready to re-submit a hard SPI driver for some members of the MPC83xx family of CPUs, but am unsure where to put it. While designed for the MPC834x chips, it should also work with the upcoming MPC8313, if the online datasheet is accurate. The other 83xx chips handle SPI with a CPM, so this driver won't work there. Should I put it in cpu/mpc83xx/, drivers/, or somewhere else? And given the unusual chip compatibilities, what should the file be called?

Definitely drivers/. Use fsl_i2c.c as an example of a driver that supports multiple families.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale