timer_stats slimmed down: statistics prereq, cleanup

RFC PATCH In review Martin Peschke 1 participant 1 message Apr 14, 2007

Subsystems (2)

Library code s390

lore

Share & tools

lore

Martin Peschke

author

2007-04-14 10:09 UTC #0 lore raw

RFC PATCH 1/4 timer_stats slimmed down: statistics prereq, cleanup

Small cleanup

Signed-off-by Martin Peschke <[email protected]>

---

 include/linux/statistic.h |    6 +++---
 lib/statistic.c           |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

include/linux/statistic.h +3 -3

Index: linux/include/linux/statistic.h
===================================================================
@@ -106,7 +106,7 @@ struct statistic {
  * @info: a struct statistic_info array describing the struct statistic array
  * @number: number of entries in both arrays
  * @pull: an optional function called when user reads data from file
- * @pull_private: optional data pointer passed to pull function
+ * @private: optional data pointer reserved for use by clients
  *
  * Exploiters must setup a struct statistic_interface prior to calling
  * statistic_create().

@@ -121,8 +121,8 @@ struct statistic_interface {
 	struct statistic	*stat;
 	struct statistic_info	*info;
 	int			 number;
-	int			(*pull)(void*);
-	void			*pull_private;
+	int			(*pull)(struct statistic_interface *interface);
+	void			*private;
 };
 
 #ifdef CONFIG_STATISTICS

lib/statistic.c +1 -1

Index: linux/lib/statistic.c
===================================================================
@@ -663,7 +663,7 @@ static int statistic_open_data(struct in
 	int size, i, j, retval = -ENOMEM;
 
 	if (interface->pull)
-		interface->pull(interface->pull_private);
+		interface->pull(interface);
 
 	size = interface->number * sizeof(struct statistic);
 	seq_priv = kzalloc(sizeof(struct statistic_seq_private), GFP_KERNEL);