Skip to contentSkip to conversation

Char: mxser, remove tty_port_tty_get from mxser_check_modem_status

PATCH New Jiri Slaby 1 participant 1 message Mar 16, 2009

Subsystems (2)
lore
Share & tools
lore

Jiri Slaby

author
#0 lore raw

PATCH 1/1 Char: mxser, remove tty_port_tty_get from mxser_check_modem_status

mxser_check_modem_status is called with tty parameter, so the reference should be increased by callers already -- for ioctl syscall it is held whole time gap since open to close, for interrupt, the reference count is increased in the irq handler.

There is no tty_kref_put in that function, so this also fixes a refcounting bug.

---
 drivers/char/mxser.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/char/mxser.c +0 -1
index 402c9f2..a420e8d 100644
@@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty,
 			wake_up_interruptible(&port->port.open_wait);
 	}
 
-	tty = tty_port_tty_get(&port->port);
 	if (port->port.flags & ASYNC_CTS_FLOW) {
 		if (tty->hw_stopped) {
 			if (status & UART_MSR_CTS) {
Signature · 1 line
1.6.2