Char: mxser, remove tty_port_tty_get from mxser_check_modem_status
Subsystems (2)
PATCH 1/1 Char: mxser, remove tty_port_tty_get from mxser_check_modem_status
mxser_check_modem_status is called with tty parameter, so the reference should be increased by callers already -- for ioctl syscall it is held whole time gap since open to close, for interrupt, the reference count is increased in the irq handler.
There is no tty_kref_put in that function, so this also fixes a refcounting bug.
Signed-off-by Jiri Slaby <[email protected]>
Cc Alan Cox <[email protected]>
--- drivers/char/mxser.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/char/mxser.c +0 -1
@@ -820,7 +820,6 @@ static void mxser_check_modem_status(struct tty_struct *tty,wake_up_interruptible (&port->port.open_wait); } - tty =tty_port_tty_get (&port->port);if (port->port.flags &ASYNC_CTS_FLOW ) {if (tty->hw_stopped) {if (status &UART_MSR_CTS ) {
Signature · 1 line
1.6.2