fsl-ddr: Fix power-down timing settings

PATCH New Kumar Gala 2 participants 10 messages Dec 16, 2009 – Jan 4, 2010

lore

Share & tools

lore

Kumar Gala

author

2009-12-16 16:24 UTC #0 lore raw

PATCH 1/4 fsl-ddr: Fix power-down timing settings

From: Dave Liu <[email protected]>

1. TIMING_CFG_0[ACT_PD_EXIT] was set to 6 clocks, but
It should be set to tXP parameter, tXP=max(3CK, 7.5ns)
2. TIMING_CFG_0[PRE_PD_EXIT] was set to 6 clocks, but
It should be set to tXP (if MR0[A12]=1) else to tXPDLL parameter We are setting the mode register MR0[A12]='1'

Signed-off-by Dave Liu <[email protected]>

---
 cpu/mpc8xxx/ddr/ctrl_regs.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

cpu/mpc8xxx/ddr/ctrl_regs.c +4 -3

index 2505041..a92f1a3 100644
@@ -188,12 +188,13 @@ static void set_timing_cfg_0(fsl_ddr_cfg_regs_t *ddr)
 	 * The DDR3 spec has not tXARD,
 	 * we use the tXP instead of it.
 	 * tXP=max(3nCK, 7.5ns) for DDR3.
-	 * we use the tXP=6
 	 * spec has not the tAXPD, we use
 	 * tAXPD=8, need design to confirm.
 	 */
-	act_pd_exit_mclk = 6;
-	pre_pd_exit_mclk = 6;
+	int tXP = max((get_memory_clk_period_ps() * 3), 7500); /* unit=ps */
+	act_pd_exit_mclk = picos_to_mclk(tXP);
+	/* Mode register MR0[A12] is '1' - fast exit */
+	pre_pd_exit_mclk = act_pd_exit_mclk;
 	taxpd_mclk = 8;
 	tmrd_mclk = 4;
 #else /* CONFIG_FSL_DDR2 */

Signature · 1 line

1.6.0.6

Kumar Gala

author Applied

2009-12-16 16:27 UTC #1 lore raw

PATCH 1/4 fsl-ddr: Fix power-down timing settings

Quoted 8 lines · Kumar Gala

From: Dave Liu <[email protected]>
1. TIMING_CFG_0[ACT_PD_EXIT] was set to 6 clocks, but It should be set to tXP parameter, tXP=max(3CK, 7.5ns)
2. TIMING_CFG_0[PRE_PD_EXIT] was set to 6 clocks, but It should be set to tXP (if MR0[A12]=1) else to tXPDLL parameter We are setting the mode register MR0[A12]='1'

Quoted 4 lines

Signed-off-by Dave Liu <[email protected]>
---
cpu/mpc8xxx/ddr/ctrl_regs.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

applied to 85xx

- k

Kumar Gala

author

2009-12-16 16:24 UTC #2 lore raw

PATCH 2/4 fsl-ddr: add the override for write leveling

In reply to Kumar Gala

From: Dave Liu <[email protected]>

add the override for write leveling sampling and
start time according to specific board.

Signed-off-by Dave Liu <[email protected]>

---
 cpu/mpc8xxx/ddr/ctrl_regs.c     |   20 ++++++++++++++------
 cpu/mpc8xxx/ddr/options.c       |    1 +
 include/asm-ppc/fsl_ddr_sdram.h |    7 ++++++-
 3 files changed, 21 insertions(+), 7 deletions(-)

cpu/mpc8xxx/ddr/ctrl_regs.c +14 -6

index a92f1a3..5e37ca6 100644
@@ -1002,8 +1002,8 @@ static void set_ddr_zq_cntl(fsl_ddr_cfg_regs_t *ddr, unsigned int zq_en)
 }
 
 /* DDR Write Leveling Control (DDR_WRLVL_CNTL) */
-static void set_ddr_wrlvl_cntl(fsl_ddr_cfg_regs_t *ddr,
-			       unsigned int wrlvl_en)
+static void set_ddr_wrlvl_cntl(fsl_ddr_cfg_regs_t *ddr, unsigned int wrlvl_en,
+				const memctl_options_t *popts)
 {
 	/*
 	 * First DQS pulse rising edge after margining mode

@@ -1030,8 +1030,9 @@ static void set_ddr_wrlvl_cntl(fsl_ddr_cfg_regs_t *ddr,
 		/* tWL_DQSEN min = 25 nCK, we set it 32 */
 		wrlvl_dqsen = 0x5;
 		/*
-		 * Write leveling sample time at least need 14 clocks
-		 * due to tWLO = 9, we set it 15 clocks
+		 * Write leveling sample time at least need 6 clocks
+		 * higher than tWLO to allow enough time for progagation
+		 * delay and sampling the prime data bits.
 		 */
 		wrlvl_smpl = 0xf;
 		/*

@@ -1044,9 +1045,16 @@ static void set_ddr_wrlvl_cntl(fsl_ddr_cfg_regs_t *ddr,
 		 * Write leveling start time
 		 * The value use for the DQS_ADJUST for the first sample
 		 * when write leveling is enabled.
-		 * we set it 1 clock delay
 		 */
 		wrlvl_start = 0x8;
+		/*
+		 * Override the write leveling sample and start time
+		 * according to specific board
+		 */
+		if (popts->wrlvl_override) {
+			wrlvl_smpl = popts->wrlvl_sample;
+			wrlvl_start = popts->wrlvl_start;
+		}
 	}
 
 	ddr->ddr_wrlvl_cntl = (0

@@ -1332,7 +1340,7 @@ compute_fsl_memctl_config_regs(const memctl_options_t *popts,
 	set_timing_cfg_5(ddr);
 
 	set_ddr_zq_cntl(ddr, zq_en);
-	set_ddr_wrlvl_cntl(ddr, wrlvl_en);
+	set_ddr_wrlvl_cntl(ddr, wrlvl_en, popts);
 
 	set_ddr_sr_cntr(ddr, sr_it);

cpu/mpc8xxx/ddr/options.c +1 -0

index 2e030c1..3dcd33d 100644
@@ -198,6 +198,7 @@ unsigned int populate_memctl_options(int all_DIMMs_registered,
 	 * meet the tQDSS under different loading.
 	 */
 	popts->wrlvl_en = 1;
+	popts->wrlvl_override = 0;
 #endif
 
 	/*

include/asm-ppc/fsl_ddr_sdram.h +6 -1

index 69b857b..15ab675 100644
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008 Freescale Semiconductor, Inc.
+ * Copyright 2008-2009 Freescale Semiconductor, Inc.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License

@@ -177,6 +177,11 @@ typedef struct memctl_options_s {
 	unsigned int clk_adjust;		/* */
 	unsigned int cpo_override;
 	unsigned int write_data_delay;		/* DQS adjust */
+
+	unsigned int wrlvl_override;
+	unsigned int wrlvl_sample;		/* Write leveling */
+	unsigned int wrlvl_start;
+
 	unsigned int half_strength_driver_enable;
 	unsigned int twoT_en;
 	unsigned int threeT_en;

Signature · 1 line

1.6.0.6

Kumar Gala

author Applied

2009-12-16 16:29 UTC #3 lore raw

PATCH 2/4 fsl-ddr: add the override for write leveling

Quoted 11 lines · Kumar Gala

From: Dave Liu <[email protected]>
add the override for write leveling sampling and
start time according to specific board.
Signed-off-by Dave Liu <[email protected]>
---
cpu/mpc8xxx/ddr/ctrl_regs.c     |   20 ++++++++++++++------
cpu/mpc8xxx/ddr/options.c       |    1 +
include/asm-ppc/fsl_ddr_sdram.h |    7 ++++++-
3 files changed, 21 insertions(+), 7 deletions(-)

applied to 85xx

- k

Kumar Gala

author

2009-12-16 16:24 UTC #4 lore raw

PATCH 3/4 fsl-ddr: add override for the Rtt_WR

In reply to Kumar Gala

From: Dave Liu <[email protected]>

It may be different settings of Rtt_nom and Rtt_WR for different boards, adding the override provide the capability.

Signed-off-by Dave Liu <[email protected]>

---
 cpu/mpc8xxx/ddr/ctrl_regs.c     |   10 +++++++---
 include/asm-ppc/fsl_ddr_sdram.h |    1 +
 2 files changed, 8 insertions(+), 3 deletions(-)

cpu/mpc8xxx/ddr/ctrl_regs.c +7 -3

index 5e37ca6..3be7e22 100644
@@ -576,18 +576,22 @@ static void set_ddr_sdram_cfg_2(fsl_ddr_cfg_regs_t *ddr,
 }
 
 /* DDR SDRAM Mode configuration 2 (DDR_SDRAM_MODE_2) */
-static void set_ddr_sdram_mode_2(fsl_ddr_cfg_regs_t *ddr)
+static void set_ddr_sdram_mode_2(fsl_ddr_cfg_regs_t *ddr,
+				const memctl_options_t *popts)
 {
 	unsigned short esdmode2 = 0;	/* Extended SDRAM mode 2 */
 	unsigned short esdmode3 = 0;	/* Extended SDRAM mode 3 */
 
 #if defined(CONFIG_FSL_DDR3)
-	unsigned int rtt_wr = 2;	/* 120 ohm Rtt_WR */
+	unsigned int rtt_wr = 0;	/* Rtt_WR - dynamic ODT off */
 	unsigned int srt = 0;	/* self-refresh temerature, normal range */
 	unsigned int asr = 0;	/* auto self-refresh disable */
 	unsigned int cwl = compute_cas_write_latency() - 5;
 	unsigned int pasr = 0;	/* partial array self refresh disable */
 
+	if (popts->rtt_override)
+		rtt_wr = popts->rtt_wr_override_value;
+
 	esdmode2 = (0
 		| ((rtt_wr & 0x3) << 9)
 		| ((srt & 0x1) << 7)

@@ -1330,7 +1334,7 @@ compute_fsl_memctl_config_regs(const memctl_options_t *popts,
 	set_ddr_sdram_cfg_2(ddr, popts);
 	set_ddr_sdram_mode(ddr, popts, common_dimm,
 				cas_latency, additive_latency);
-	set_ddr_sdram_mode_2(ddr);
+	set_ddr_sdram_mode_2(ddr, popts);
 	set_ddr_sdram_interval(ddr, popts, common_dimm);
 	set_ddr_data_init(ddr);
 	set_ddr_sdram_clk_cntl(ddr, popts);

include/asm-ppc/fsl_ddr_sdram.h +1 -0

index 15ab675..3216a50 100644
@@ -192,6 +192,7 @@ typedef struct memctl_options_s {
 	/* Rtt impedance */
 	unsigned int rtt_override;		/* rtt_override enable */
 	unsigned int rtt_override_value;	/* that is Rtt_Nom for DDR3 */
+	unsigned int rtt_wr_override_value;	/* this is Rtt_WR for DDR3 */
 
 	/* Automatic self refresh */
 	unsigned int auto_self_refresh_en;

Signature · 1 line

1.6.0.6

Kumar Gala

author Applied

2009-12-16 16:29 UTC #5 lore raw

PATCH 3/4 fsl-ddr: add override for the Rtt_WR

Quoted 11 lines · Kumar Gala

From: Dave Liu <[email protected]>
It may be different settings of Rtt_nom and Rtt_WR for different boards, adding the override provide the capability.
Signed-off-by Dave Liu <[email protected]>
---
cpu/mpc8xxx/ddr/ctrl_regs.c | 10 +++++++---
include/asm-ppc/fsl_ddr_sdram.h | 1 +
2 files changed, 8 insertions(+), 3 deletions(-)

applied to 85xx

- k

Kumar Gala

author

2009-12-16 16:24 UTC #6 lore raw

PATCH 4/4 fsl-ddr: setup ODT_RD_CFG & ODT_WR_CFG when we interleave

In reply to Kumar Gala

From: Dave Liu <[email protected]>

In chip-select interleaving case, we also need set the ODT_RD_CFG and ODT_WR_CFG in cs1_config register.

Signed-off-by Dave Liu <[email protected]>

---
 cpu/mpc8xxx/ddr/ctrl_regs.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

cpu/mpc8xxx/ddr/ctrl_regs.c +3 -0

index 3be7e22..adc4f6e 100644
@@ -1197,7 +1197,10 @@ compute_fsl_memctl_config_regs(const memctl_options_t *popts,
 			/* Don't set up boundaries for other CS
 			 * other than CS0, if bank interleaving
 			 * is enabled and not CS2+CS3 interleaved.
+			 * But we need to set the ODT_RD_CFG and
+			 * ODT_WR_CFG for CS1_CONFIG here.
 			 */
+			set_csn_config(i, ddr, popts, dimm_params);
 			break;
 		}

Signature · 1 line

1.6.0.6

Kumar Gala

author Applied

2009-12-16 16:29 UTC #7 lore raw

PATCH 4/4 fsl-ddr: setup ODT_RD_CFG & ODT_WR_CFG when we interleave

Quoted 9 lines · Kumar Gala

From: Dave Liu <[email protected]>
In chip-select interleaving case, we also need set the ODT_RD_CFG and ODT_WR_CFG in cs1_config register.
Signed-off-by Dave Liu <[email protected]>
---
cpu/mpc8xxx/ddr/ctrl_regs.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

applied to 85xx

- k

Wolfgang Denk

2009-12-17 21:20 UTC #8 lore raw

PATCH 3/4 fsl-ddr: add override for the Rtt_WR

In reply to Kumar Gala

Dear Kumar Gala,

Quoted 5 lines · In message <[email protected]> you…

From: Dave Liu <[email protected]>
It may be different settings of Rtt_nom and Rtt_WR for different boards, adding the override provide the capability.

I don't understand what this commit message is supposed to say. Can you please explain what this commit is supposed to do?

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Give a man a fish, and you feed him for a day. Teach a man  to  fish,
and he'll invite himself over for dinner.             - Calvin Keegan

Kumar Gala

author

2010-01-04 17:37 UTC #9 lore raw

PATCH 3/4 fsl-ddr: add override for the Rtt_WR

Quoted 11 lines · Wolfgang Denk

Dear Kumar Gala,
Quoted 5 lines · In message <[email protected]> you…
From: Dave Liu <[email protected]>
It may be different settings of Rtt_nom and Rtt_WR for different boards, adding the override provide the capability.
I don't understand what this commit message is supposed to say. Can you please explain what this commit is supposed to do?

I'll rewrite it. Does the following make sense:

Different boards may require different settings of Dynamic ODT (Rtt_Wr). We provide a means to allow the board specific code to provide its own value of Rtt_wr.

- k