Skip to contentSkip to conversation

drm:drm_gem Fix warning: variable 'dev' set but not used

PATCH New Justin P. Mattock 1 participant 1 message Jun 21, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 5/8 drm:drm_gem Fix warning: variable 'dev' set but not used

This is a redu due to the original being completly wrong (better to leave a warning than shut it off).
I've removed the "dev =" variable but then receive a drm_gem.c:207:2: warning: statement with no effect telling me this thing is not doing anything according to gcc

so the below patch fixes a warning from gcc:
CC [M] drivers/gpu/drm/drm_gem.o
drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete':
drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used have a look if you have the time, and if theres something else to do then let me know(i'll test it out!!)

---
 drivers/gpu/drm/drm_gem.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_gem.c +0 -2
index 33dad3f..d1648bf 100644
@@ -185,7 +185,6 @@ EXPORT_SYMBOL(drm_gem_object_alloc);
 static int
 drm_gem_handle_delete(struct drm_file *filp, u32 handle)
 {
-	struct drm_device *dev;
 	struct drm_gem_object *obj;
 
 	/* This is gross. The idr system doesn't let us try a delete and
@@ -205,7 +204,6 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle)
 		spin_unlock(&filp->table_lock);
 		return -EINVAL;
 	}
-	dev = obj->dev;
 
 	/* Release reference and decrement refcount. */
 	idr_remove(&filp->object_idr, handle);
Signature · 1 line
1.7.1.rc1.21.gf3bd6