arm: mach-pnx4008: fix sign bug
Subsystems (3)
PATCH 2/5 arm: mach-pnx4008: fix sign bug
'ret' is unsigned, so this code is wrong:
ret = gpio_read_bit(...);
...
if (ret > 0)If gpio_read_bit() returns -EFAULT then (ret > 0) would be true. Make 'ret' signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by Kulikov Vasiliy <[email protected]>
--- arch/arm/mach-pnx4008/gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-pnx4008/gpio.c +1 -1
@@ -199,7 +199,7 @@ EXPORT_SYMBOL(pnx4008_gpio_unregister_pin);unsigned long pnx4008_gpio_read_pin (unsigned short pin) { -unsigned long ret = -EFAULT ; +int ret = -EFAULT ;int gpio =GPIO_BIT_MASK (pin);gpio_lock ();if (GPIO_ISOUT (pin)) {
Signature · 1 line
1.7.0.4