Skip to contentSkip to conversation

regulator: lp3971 - remove redundant checking for count in lp3971_i2c_read()

PATCH RESEND Superseded Axel Lin 1 participant 1 message Aug 6, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 2/2 regulator: lp3971 - remove redundant checking for count in lp3971_i2c_read()

We already check count value before calling i2c_smbus_read_byte_data(), no need to check it again.

---
This resend adds regulator: prefix in the subject line.

 drivers/regulator/lp3971.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/lp3971.c +1 -1
index d4d9822..3bb82b6 100644
@@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
 	if (count != 1)
 		return -EIO;
 	ret = i2c_smbus_read_byte_data(i2c, reg);
-	if (ret < 0 || count != 1)
+	if (ret < 0)
 		return -EIO;
 
 	*dest = ret;
Signature · 1 line
1.5.4.3