Skip to contentSkip to conversation

APM821xx: Add bluestone board support

PATCH Superseded tmarri at apm.com 2 participants 2 messages Sep 8, 2010 – Sep 9, 2010

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 2/2 APM821xx: Add bluestone board support

From: Tirumala Marri <[email protected]>

Add support code for bluestone board wth APM821XX processor based. This patch includes early board init, misc init, configure EBC, initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.

---
V2:
* Missing space before "<".
* SDR_AHB_CFG not used, remove.
* boot device dfinitions are board specific ? removed.
* APM82161_MASK not used, remove
* set_mcsr() is already called in ddr init, no need to call here.
* removed finding bootdevice function which is not used.
* Add spaces in tlbentry() function.
* Board early init function is empty remove.
* Remove CONFIG_SYS_EXTSRAM_BASE.
* Set CONFIG_SYS_FLASH_SIZE to 4MB
* Remove CONFIG_SIZE_REDUCE & CONFIG_SECTOR_REDUCE.
* Spaces around " >> " .
* Correct the phy name CONFIG_M88E1111_PHY to CONFIG_RTL8211CL_PHY.
V3:
* Missing TLB entry for CONFIG_SYS_BOOT_BASE_ADDR.
* Move CONFIG_SYS_EBC_PB0AP etc to EBC area in the config file.
* remove unused CONFIG_RTL8211CL_PHY.
* Replace hard coded valued for CONFIG_SYS_EBC_CFG with macro definitions.
* Change APM82XXX to APM821XX
* board.cfg add the entry in sorted.
* use puts() if there is no formating needed.

---
 MAINTAINERS                      |    3 +
 MAKEALL                          |    1 +
 board/amcc/bluestone/Makefile    |   52 +++++++++++
 board/amcc/bluestone/bluestone.c |  111 ++++++++++++++++++++++++
 board/amcc/bluestone/config.mk   |   40 +++++++++
 board/amcc/bluestone/init.S      |   59 +++++++++++++
 boards.cfg                       |    1 +
 include/configs/bluestone.h      |  175 ++++++++++++++++++++++++++++++++++++++
 8 files changed, 442 insertions(+), 0 deletions(-)
MAINTAINERS +3 -0
index 4b91b0f..284d136 100644
@@ -253,6 +253,9 @@ Feng Kan <[email protected]>
 
 	redwood			PPC4xx
 
+Tirumala Marri <[email protected]>
+	bluestone	APM821XX
+
 Brad Kemp <[email protected]>
 
 	ppmc8260	MPC8260
MAKEALL +1 -0
index b34ae33..02d5c17 100755
@@ -191,6 +191,7 @@ LIST_4xx="		\
 	ASH405		\
 	bamboo		\
 	bamboo_nand	\
+	bluestone	\
 	bubinga		\
 	CANBT		\
 	canyonlands	\
board/amcc/bluestone/Makefile new file +52 -0

52 lines not on this page · raw message

board/amcc/bluestone/bluestone.c new file +111 -0

111 lines not on this page · raw message

board/amcc/bluestone/config.mk new file +40 -0
new file mode 100644
index 0000000..e2194e4
@@ -0,0 +1,40 @@
+#
+# Copyright (c) 2010, Applied Micro Circuits Corporation
+# Author: Tirumala R Marri <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+# Applied Micro APM821XX Evaluation board.
+#
+
+sinclude $(OBJTREE)/board/$(BOARDDIR)/config.tmp
+
+ifndef TEXT_BASE
+TEXT_BASE = 0xFFFA0000
+endif
+
+PLATFORM_CPPFLAGS += -DCONFIG_440=1
+
+ifeq ($(debug),1)
+PLATFORM_CPPFLAGS += -DDEBUG
+endif
+
+ifeq ($(dbcr),1)
+PLATFORM_CPPFLAGS += -DCONFIG_SYS_INIT_DBCR=0x8cff0000
+endif
board/amcc/bluestone/init.S new file +59 -0

59 lines not on this page · raw message

boards.cfg +1 -0
index 69c6897..f436c66 100644
@@ -186,6 +186,7 @@ t3corp		powerpc	ppc4xx
 zeus		powerpc	ppc4xx
 acadia		powerpc	ppc4xx		-		amcc
 bamboo		powerpc	ppc4xx		-		amcc
+bluestone 	powerpc ppc4xx		-		amcc
 bubinga		powerpc	ppc4xx		-		amcc
 ebony		powerpc	ppc4xx		-		amcc
 katmai		powerpc	ppc4xx		-		amcc
include/configs/bluestone.h new file +175 -0

175 lines not on this page · raw message

Signature · 1 line
1.6.1.rc3
#1 lore raw

PATCH v3 2/2 APM821xx: Add bluestone board support

Hi Marri,

Quoted 5 lines · On Wednesday 08 September 2010 04:06:27 tmarri at apm.com wrote:

From: Tirumala Marri <[email protected]>

Add support code for bluestone board wth APM821XX processor based. This patch includes early board init, misc init, configure EBC, initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.

One nitpicking comment below.

<snip>

include/configs/bluestone.h line 139

Quoted 11 lines
include/configs/bluestone.h new file +11 -0
+/*
+ * Ethernet
+ */
+#define CONFIG_IBM_EMAC4_V4    1
+#define CONFIG_EMAC_PHY_MODE  EMAC_PHY_MODE_NONE_RGMII
+#define CONFIG_HAS_ETH0
+/* PHY address, See schematics  */
+#define CONFIG_PHY_ADDR			0x1f
+/* reset phy upon startup       */
+#define CONFIG_PHY_RESET		1
+#define CONFIG_PHY_RESET_R

CONFIG_PHY_RESET_R is not referenced anywhere. Please remove it.

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de