Skip to contentSkip to conversation

Seagate FreeAgent DockStar support

PATCH Superseded Eric Cooper 2 participants 4 messages Nov 21, 2010 – Nov 23, 2010

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Seagate FreeAgent DockStar support

start with sheevaplug configuration
add modifications by Alexander Holler <[email protected]>
change RAM definitions to one bank (128 MB) change ident string and prompt
change environment to 0xA0000
define MTD partitions and default environment variables add support for LEDs

---
Changes for v2:
- rebased on master, post ARM and kirkwood relocation changes
- squashed into single commit

Changes for v3:
- moved files to board/Seagate/dockstar/ and updated copyright notices
- removed dockstar entry from MAKEALL
- moved CONFIG_SYS_TEXT_BASE from config.mk to include/configs/dockstar.h
- corrected comment in board/Seagate/dockstar/kwbimage.cfg

 MAINTAINERS                         |    4 +
 board/Seagate/dockstar/Makefile     |   54 +++++++++++
 board/Seagate/dockstar/dockstar.c   |  181 +++++++++++++++++++++++++++++++++++
 board/Seagate/dockstar/dockstar.h   |   44 +++++++++
 board/Seagate/dockstar/kwbimage.cfg |  165 +++++++++++++++++++++++++++++++
 boards.cfg                          |    1 +
 include/configs/dockstar.h          |  125 ++++++++++++++++++++++++
 7 files changed, 574 insertions(+), 0 deletions(-)
 create mode 100644 board/Seagate/dockstar/Makefile
 create mode 100644 board/Seagate/dockstar/dockstar.c
 create mode 100644 board/Seagate/dockstar/dockstar.h
 create mode 100644 board/Seagate/dockstar/kwbimage.cfg
 create mode 100644 include/configs/dockstar.h
MAINTAINERS +4 -0
index 9258cb1..9bf52fa 100644
@@ -591,6 +591,10 @@ Po-Yu Chuang <[email protected]>
 
 	a320evb		FA526 (ARM920T-like) (a320 SoC)
 
+Eric Cooper <[email protected]>
+
+	dockstar	ARM926EJS (Kirkwood SoC)
+
 George G. Davis <[email protected]>
 
 	assabet		SA1100
board/Seagate/dockstar/Makefile new file +54 -0

54 lines not on this page · raw message

board/Seagate/dockstar/dockstar.c new file +181 -0

181 lines not on this page · raw message

board/Seagate/dockstar/dockstar.h new file +44 -0

44 lines not on this page · raw message

board/Seagate/dockstar/kwbimage.cfg new file +165 -0

165 lines not on this page · raw message

boards.cfg +1 -0
index 08e531e..50e9d1b 100644
@@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell		kirkwood
 mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
 openrd_base	arm	arm926ejs	-		Marvell		kirkwood
 sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
+dockstar	arm	arm926ejs	-		Seagate		kirkwood
 imx27lite	arm	arm926ejs	imx27lite	logicpd		mx27
 magnesium	arm	arm926ejs	imx27lite	logicpd		mx27
 omap5912osk	arm	arm926ejs	-		ti		omap
include/configs/dockstar.h new file +125 -0

125 lines not on this page · raw message

Signature · 1 line
1.7.2.3
#1 lore raw

PATCH v3 1/1 Seagate FreeAgent DockStar support

Quoted 46 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Eric Cooper
Sent: Monday, November 22, 2010 2:59 AM
To: u-boot at lists.denx.de
Subject: [U-Boot] [PATCH v3] Seagate FreeAgent DockStar support

start with sheevaplug configuration
add modifications by Alexander Holler <[email protected]>
change RAM definitions to one bank (128 MB) change ident string and prompt
change environment to 0xA0000
define MTD partitions and default environment variables add support for LEDs

---
Changes for v2:
- rebased on master, post ARM and kirkwood relocation changes
- squashed into single commit

Changes for v3:
- moved files to board/Seagate/dockstar/ and updated copyright notices
- removed dockstar entry from MAKEALL
- moved CONFIG_SYS_TEXT_BASE from config.mk to
include/configs/dockstar.h
- corrected comment in board/Seagate/dockstar/kwbimage.cfg

 MAINTAINERS                         |    4 +
 board/Seagate/dockstar/Makefile     |   54 +++++++++++
 board/Seagate/dockstar/dockstar.c   |  181
+++++++++++++++++++++++++++++++++++
 board/Seagate/dockstar/dockstar.h   |   44 +++++++++
 board/Seagate/dockstar/kwbimage.cfg |  165
+++++++++++++++++++++++++++++++
 boards.cfg                          |    1 +
 include/configs/dockstar.h          |  125 ++++++++++++++++++++++++
 7 files changed, 574 insertions(+), 0 deletions(-)
 create mode 100644 board/Seagate/dockstar/Makefile
 create mode 100644 board/Seagate/dockstar/dockstar.c
 create mode 100644 board/Seagate/dockstar/dockstar.h
 create mode 100644 board/Seagate/dockstar/kwbimage.cfg
 create mode 100644 include/configs/dockstar.h

...snip...

Quoted 31 lines
board/Seagate/dockstar/kwbimage.cfg new file +24 -0
new file mode 100644
index 0000000..98b514d
@@ -0,0 +1,165 @@
+#
+# Copyright (C) 2010  Eric C. Cooper <[email protected]>
+#
+# Based on sheevaplug/kwbimage.cfg originally written by
+# Prafulla Wadaskar <[email protected]>
+# (C) Copyright 2009
+# Marvell Semiconductor <www.marvell.com>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,

board/Seagate/dockstar/kwbimage.cfg line 34

Quoted 10 lines
board/Seagate/dockstar/kwbimage.cfg new file +10 -0
+# MA 02110-1301 USA
+#
+# Refer docs/README.kwimage for more details about how-to configure
+# and create kirkwood boot image
+#
+
+# Boot Media configurations
+BOOT_FROM	nand
+NAND_ECC_MODE	default
+NAND_PAGE_SIZE	0x0800

Are the contents for this file exactly same as sheevaplug/kwbimage.cfg?
If yes then you can reuse that file and avoid adding this file here by using configuration in board config file.

...snip...

boards.cfg guruplug arm arm926ejs - Marvell · line 380

Quoted 10 lines
boards.cfg +1 -0
index 08e531e..50e9d1b 100644
@@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell
 	kirkwood
 mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
 openrd_base	arm	arm926ejs	-		Marvell		kirkwood
 sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
+dockstar	arm	arm926ejs	-		Seagate		Kirkwood

Please check if you have missed to maintain this in order

Quoted 79 lines
boards.cfg +0 -0
 imx27lite	arm	arm926ejs	imx27lite	logicpd		mx27
 magnesium	arm	arm926ejs	imx27lite	logicpd		mx27

omap5912osk arm arm926ejs - ti omap

include/configs/dockstar.h new file +70 -0
new file mode 100644
index 0000000..5a058b6
@@ -0,0 +1,125 @@
+/*
+ * Copyright (C) 2010  Eric C. Cooper <[email protected]>
+ *
+ * Based on sheevaplug.h originally written by
+ * Prafulla Wadaskar <[email protected]>
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CONFIG_DOCKSTAR_H
+#define _CONFIG_DOCKSTAR_H
+
+/*
+ * Version number information
+ */
+#define CONFIG_IDENT_STRING	"\nSeagate FreeAgent DockStar"
+
+/*
+ * High Level Configuration Options (easy to change)
+ */
+#define CONFIG_FEROCEON_88FR131	1	/* CPU Core subversion */
+#define CONFIG_KIRKWOOD		1	/* SOC Family Name */
+#define CONFIG_KW88F6281	1	/* SOC Name */
+#define CONFIG_MACH_DOCKSTAR	/* Machine type */
+#define CONFIG_SKIP_LOWLEVEL_INIT	/* disable board lowlevel_init */
+
+/*
+ * Commands configuration
+ */
+#define CONFIG_SYS_NO_FLASH		/* Declare no flash (NOR/SPI) */
+#include <config_cmd_default.h>
+#define CONFIG_CMD_DHCP
+#define CONFIG_CMD_ENV
+#define CONFIG_CMD_MII
+#define CONFIG_CMD_NAND
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_USB
+/*
+ * mv-common.h should be defined after CMD configs since it used them
+ * to enable certain macros
+ */
+#include "mv-common.h"
+
+#undef CONFIG_SYS_PROMPT	/* previously defined in mv-common.h */
+#define CONFIG_SYS_PROMPT	"DockStar> "	/* Command Prompt */
+
+/*
+ *  Environment variables configurations
+ */
+#ifdef CONFIG_CMD_NAND
+#define CONFIG_ENV_IS_IN_NAND		1
+#define CONFIG_ENV_SECT_SIZE		0x20000	/* 128K */

include/configs/dockstar.h line 80

Quoted 10 lines
include/configs/dockstar.h new file +10 -0
+#else
+#define CONFIG_ENV_IS_NOWHERE		1	/* if env in SDRAM */
+#endif
+/*
+ * max 4k env size is enough, but in case of nand
+ * it has to be rounded to sector size
+ */
+#define CONFIG_ENV_SIZE			0x20000	/* 128k */
+#define CONFIG_ENV_ADDR			0xA0000
+#define CONFIG_ENV_OFFSET		0xA0000	/* env starts here */

u-boot.bin is not more than 0x60000, its better to use env offset at 0x60000 to pack u-boot+env in first 512kb

Regards..
Prafulla . .

#2 lore raw

PATCH v3 1/1 Seagate FreeAgent DockStar support

Quoted 7 lines · Prafulla Wadaskar

board/Seagate/dockstar/kwbimage.cfg

Quoted 2 lines
board/Seagate/dockstar/kwbimage.cfg +0 -0

[...]
Are the contents for this file exactly same as sheevaplug/kwbimage.cfg? If yes then you can reuse that file and avoid adding this file here by using configuration in board config file.

No, they're different (DockStar has 128M of RAM vs. SheevaPlug's 256M.)

Quoted 4 lines
Quoted 4 lines
boards.cfg +0 -0
index 08e531e..50e9d1b 100644
Quoted 8 lines

boards.cfg guruplug arm arm926ejs - Marvell · line 380

Quoted 6 lines
boards.cfg +1 -0
@@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell
 	kirkwood
 mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
 openrd_base	arm	arm926ejs	-		Marvell		kirkwood
 sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
+dockstar	arm	arm926ejs	-		Seagate		Kirkwood

Please check if you have missed to maintain this in order

I couldn't figure out the intended sort order of the current file. The comment at the top (about using a sort command) doesn't seem to match the contents at all, and there are already several arm926ejs and kirkwood boards in various places.

I'm happy to move this, but please specify exactly where :-)

Quoted 6 lines

boards.cfg guruplug arm arm926ejs - Marvell

Quoted 3 lines
boards.cfg +3 -0
+#define CONFIG_ENV_SIZE			0x20000	/* 128k */
+#define CONFIG_ENV_ADDR			0xA0000
+#define CONFIG_ENV_OFFSET		0xA0000	/* env starts here */

u-boot.bin is not more than 0x60000, its better to use env offset at 0x60000 to pack u-boot+env in first 512kb

The factory partitioning uses 1M for u-boot, so I wasn't paying attention to saving space. But I'll move it down as you suggest.

Thanks for the feedback.

Signature · 1 line
Eric Cooper             e c c @ c m u . e d u
#3 lore raw

PATCH v3 1/1 Seagate FreeAgent DockStar support

Quoted 18 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Eric Cooper
Sent: Monday, November 22, 2010 7:27 PM
To: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH v3] Seagate FreeAgent DockStar support

Quoted 7 lines · Prafulla Wadaskar

board/Seagate/dockstar/kwbimage.cfg

Quoted 2 lines
board/Seagate/dockstar/kwbimage.cfg +0 -0

[...]
Are the contents for this file exactly same as sheevaplug/kwbimage.cfg? If yes then you can reuse that file and avoid adding this file here by using configuration in board config file.

Quoted 1 line

No, they're different (DockStar has 128M of RAM vs. SheevaPlug's 256M.)

Okay

Quoted 14 lines
Quoted 13 lines

boards.cfg guruplug arm arm926ejs - Marvell · line 380

Quoted 11 lines
boards.cfg +1 -0
index 08e531e..50e9d1b 100644
@@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell
 	kirkwood
 mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
 openrd_base	arm	arm926ejs	-		Marvell		kirkwood
 sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
+dockstar	arm	arm926ejs	-		Seagate		Kirkwood

Please check if you have missed to maintain this in order

Quoted 6 lines

I couldn't figure out the intended sort order of the current file. The comment at the top (about using a sort command) doesn't seem to match the contents at all, and there are already several arm926ejs and kirkwood boards in various places.

I'm happy to move this, but please specify exactly where :-)

Yes I know, it would be good if you can re-order them together (separate patch), or just add your board just above suen3.

Regards..
Prafulla . .