Skip to contentSkip to conversation

linux-omap-psp: Fix the user button GPIO to the correct value for a BeagleBoard-xM

PATCH Superseded Joel A Fernandes 2 participants 3 messages Jul 6, 2011

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-omap-psp: Fix the user button GPIO to the correct value for a BeagleBoard-xM

---
 ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
index 513a101..fb91cb6 100644
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
  	omap3_beagle_i2c_init();
  
 -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  		gpio_buttons[0].gpio = 4;
  	}
  
Signature · 1 line
1.7.0.4
#1 lore raw

Dear Joel,

Am Dienstag, den 05.07.2011, 20:48 -0500 schrieb Joel A Fernandes:

1. What has changed in this patch iteration? (You can put that below the ---.)
2. Could you elaborate a bit more what the problem was, i. e. how the situation was before, and how the fix works? For example pointing to the thread on the BeagleBoard list.(?)
3. Is a similar patch also needed for 2.6.39?

Quoted 10 lines
---
 ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +0 -0
index 513a101..fb91cb6 100644

recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch index 4bde54b..664a9c6 100644 · line 149

Quoted 9 lines
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
  	omap3_beagle_i2c_init();
 
 -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  		gpio_buttons[0].gpio = 4;
  	}

Thanks,

Paul

#2 lore raw

Hi Paul,

Thanks for your suggestions.

Quoted 7 lines · Paul Menzel

Dear Joel,

Am Dienstag, den 05.07.2011, 20:48 -0500 schrieb Joel A Fernandes:

1. What has changed in this patch iteration? (You can put that below the ---.)

Thanks, will do.

Quoted 3 lines

2. Could you elaborate a bit more what the problem was, i. e. how the situation was before, and how the fix works? For example pointing to the thread on the BeagleBoard list.(?)

I am not aware of any thread that showed concern about the incorrect value. It so happened that the user-button wasn't working for me.

Quoted 1 line

3. Is a similar patch also needed for 2.6.39?

A similar patch is already included in 2.6.39 and has the correct value.
(line 109 in linux/linux-omap-2.6.39/beagle/0001-OMAP3-beagle-add-support-for-beagleboard-xM-revision.patch)

Thanks,
Joel