Skip to contentSkip to conversation

linux-omap-psp: Fix the user button GPIO to the correct value for a BeagleBoard-xM

PATCH In review Joel A Fernandes 2 participants 3 messages Jul 6, 2011 – Jul 11, 2011

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 linux-omap-psp: Fix the user button GPIO to the correct value for a BeagleBoard-xM

The user-button wasn't working for me with the the linux-omap-psp-2.6.32 kernel, this change fixes it. I noticed the correct value in the linux-omap-2.6.39 sources

---
Changes since v2:
* Bumped PR
* Made the commit summary more descriptive, removed full stop

 conf/machine/include/omap3.inc                     |    2 +-
 ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
conf/machine/include/omap3.inc +1 -1
index c762d41..f806a32 100644
@@ -4,7 +4,7 @@ TARGET_ARCH = "arm"
 require conf/machine/include/tune-cortexa8.inc
 PREFERRED_PROVIDER_virtual/kernel = "linux-omap"
 # Increase this everytime you change something in the kernel
-MACHINE_KERNEL_PR = "r102"
+MACHINE_KERNEL_PR = "r103"
 
 KERNEL_IMAGETYPE = "uImage"
 
recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -2
index 513a101..fb91cb6 100644
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
  	omap3_beagle_i2c_init();
  
 -	if (cpu_is_omap3630()) {
-+	if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+		(omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++	if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++		(omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
  		gpio_buttons[0].gpio = 4;
  	}
  
Signature · 1 line
1.7.0.4
#1 lore raw

Hi,

conf/machine/include/omap3.inc

Quoted 13 lines · Joel A Fernandes

The user-button wasn't working for me with the the linux-omap-psp-2.6.32 kernel, this change fixes it. I noticed the correct value in the linux-omap-2.6.39 sources

---
Changes since v2:
* Bumped PR
* Made the commit summary more descriptive, removed full stop

 conf/machine/include/omap3.inc                     |    2 +- ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--

 2 files changed, 3 insertions(+), 3 deletions(-)
conf/machine/include/omap3.inc +0 -0

Could this patch be ACKed and/or applied to the dev and maintenance trees?

Thanks
Joel

Acked-by on v3 1/1
#2 lore raw
In reply to Joel A Fernandes
Quoted 7 lines · Joel A Fernandes

The user-button wasn't working for me with the the linux-omap-psp-2.6.32 kernel, this change fixes it. I noticed the correct value in the linux-omap-2.6.39 sources

---
Changes since v2:
* Bumped PR
* Made the commit summary more descriptive, removed full stop

I confirmed by looking at the schematics that this is the correct logic. GPIO4 for BeagleBoard-xM and GPIO7 for BeagleBoard.

Quoted 42 lines

 conf/machine/include/omap3.inc                     |    2 +- ...agle-cleaned-up-board-revision-conditions.patch |    4 ++--

 2 files changed, 3 insertions(+), 3 deletions(-)
conf/machine/include/omap3.inc +0 -0
index c762d41..f806a32 100644
@@ -4,7 +4,7 @@ TARGET_ARCH = "arm"

 require conf/machine/include/tune-cortexa8.inc PREFERRED_PROVIDER_virtual/kernel = "linux-omap"
 # Increase this everytime you change something in the kernel

conf/machine/include/omap3.inc +1 -1
-MACHINE_KERNEL_PR = "r102"
+MACHINE_KERNEL_PR = "r103"

 KERNEL_IMAGETYPE = "uImage"

recipes/linux/linux-omap-psp-2.6.32/beagleboard-xmc/0008-omap3-beagle-cleaned-up-board-revision-conditions.patch +2 -3
index 513a101..fb91cb6 100644
@@ -143,8 +143,8 @@ index 4bde54b..664a9c6 100644
        omap3_beagle_i2c_init();
 
  -      if (cpu_is_omap3630()) {
-+      if ((omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMAB) &&
-+              (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XMC)) {
++      if ((omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMAB) ||
++              (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XMC)) {
                gpio_buttons[0].gpio = 4;
        }
 
--

1.7.0.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel