Skip to contentSkip to conversation

drm/i915:fix the bug that testdisplay can't work with 32 bits depth (bug # 40011)

PATCH In review Hai Lan 2 participants 4 messages Aug 13, 2011

Subsystems (2)
lore
Share & tools
lore

Hai Lan

author
#0 lore raw

PATCH 1/1 drm/i915:fix the bug that testdisplay can't work with 32 bits depth (bug # 40011)

---
 drivers/gpu/drm/i915/intel_display.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/intel_display.c +2 -0
index 35364e6..f743085 100644
@@ -2056,6 +2056,8 @@ static int ironlake_update_plane(struct drm_crtc *crtc,
 	case 32:
 		if (fb->depth == 24)
 			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
+		else if (fb->depth == 32)
+			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
 		else if (fb->depth == 30)
 			dspcntr |= DISPPLANE_32BPP_30BIT_NO_ALPHA;
 		else
Signature · 1 line
1.7.0.1
#1 lore raw

drivers/gpu/drm/i915/intel_display.c static int ironlake_update_plane(struct drm_crtc *crtc, · line 2063

Quoted 8 lines · Hai Lan
drivers/gpu/drm/i915/intel_display.c +2 -0
 	case 32:
 		if (fb->depth == 24)
 			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
+		else if (fb->depth == 32)
+			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
 		else if (fb->depth == 30)
 			dspcntr |= DISPPLANE_32BPP_30BIT_NO_ALPHA;
 		else

There is no hardware support for depth 32 output -- the hardware can only do 24-bits (8-8-8-8) XRGB or 30-bits (2-10-10-10) XRGB. Passing depth 32 to this function is in fact an error which the kernel now correctly reports.

This patch simply assumes that the application programmer created a depth 24 frame buffer and then mistakenly told the kernel that it was depth 32.

Signature · 1 line
[email protected]

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#2 lore raw

Hi Keith
Thanks for your explanation. So bug 40011 can be treated as not-a-bug.

Hai Lan

Quoted 28 lines

-----Original Message-----
From: Keith Packard [mailto:[email protected]]
Sent: Sunday, August 14, 2011 1:47 AM
To: Lan, Hai; [email protected]
Cc: Lan, Hai
Subject: Re: [PATCH] drm/i915:fix the bug that testdisplay can't work with 32 bits depth (bug # 40011)

drivers/gpu/drm/i915/intel_display.c static int ironlake_update_plane(struct drm_crtc *crtc, · line 2063

Quoted 8 lines · Hai Lan
drivers/gpu/drm/i915/intel_display.c +2 -0
 	case 32:
 		if (fb->depth == 24)
 			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
+		else if (fb->depth == 32)
+			dspcntr |= DISPPLANE_32BPP_NO_ALPHA;
 		else if (fb->depth == 30)
 			dspcntr |= DISPPLANE_32BPP_30BIT_NO_ALPHA;
 		else

There is no hardware support for depth 32 output -- the hardware can only do 24-bits (8-8-8-8) XRGB or 30-bits (2-10-10-10) XRGB. Passing depth 32 to this function is in fact an error which the kernel now correctly reports.

This patch simply assumes that the application programmer created a depth 24 frame buffer and then mistakenly told the kernel that it was depth 32.

--
[email protected]