ASoC: Optimise WM8996 no interrupt path
Subsystems (3)
PATCH 1/1 ASoC: Optimise WM8996 no interrupt path
This occurs frequently if we are in edge triggered mode as we must poll the interrupt status register until we get no more interrupts so it's worth the effort - it means we skip writing null acknowledgements to the chip.
Signed-off-by Mark Brown <[email protected]>
--- sound/soc/codecs/wm8996.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
sound/soc/codecs/wm8996.c +4 -4
@@ -2416,6 +2416,9 @@ static irqreturn_t wm8996_irq(int irq, void *data) } irq_val &= ~snd_soc_read (codec,WM8996_INTERRUPT_STATUS_2_MASK ); +if (!irq_val) +return IRQ_NONE ; +snd_soc_write (codec,WM8996_INTERRUPT_STATUS_2 , irq_val);if (irq_val & (WM8996_DCS_DONE_01_EINT |WM8996_DCS_DONE_23_EINT )) {
@@ -2434,10 +2437,7 @@ static irqreturn_t wm8996_irq(int irq, void *data)if (irq_val &WM8996_MICD_EINT )wm8996_micd (codec); -if (irq_val) -return IRQ_HANDLED ; -else -return IRQ_NONE ; +return IRQ_HANDLED ; }static irqreturn_t wm8996_edge_irq (int irq,void *data)
Signature · 1 line
1.7.5.4
Quoted 25 lines · Mark Brown
This occurs frequently if we are in edge triggered mode as we must poll the interrupt status register until we get no more interrupts so it's worth the effort - it means we skip writing null acknowledgements to the chip.
Signed-off-by Mark Brown <[email protected]>--- sound/soc/codecs/wm8996.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)sound/soc/codecs/wm8996.c +3
-0@@ -2416,6 +2416,9 @@ static irqreturn_t wm8996_irq(int irq, void *data) } irq_val &= ~snd_soc_read (codec,WM8996_INTERRUPT_STATUS_2_MASK ); +if (!irq_val) +return IRQ_NONE ; +snd_soc_write (codec,WM8996_INTERRUPT_STATUS_2 , irq_val);if (irq_val & (WM8996_DCS_DONE_01_EINT |WM8996_DCS_DONE_23_EINT )) {@@ -2434,10 +2437,7 @@ static irqreturn_t wm8996_irq(int irq, void *data)if (irq_val &WM8996_MICD_EINT )
sound/soc/codecs/wm8996.c static irqreturn_t wm8996_irq(int irq, void *data) · line 2443
Quoted 10 lines
sound/soc/codecs/wm8996.c +1
-4wm8996_micd (codec); -if (irq_val) -return IRQ_HANDLED ; -else -return IRQ_NONE ; +return IRQ_HANDLED ; }static irqreturn_t wm8996_edge_irq (int irq,void *data)
Acked-by Liam Girdwood <[email protected]>