OMAP3: Overo: Update GPMC timing for ethernet chip.
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
The existing timing does not quite meet the minimum requirements in the LAN9221 datasheet. The timing in this patch solves problems noticed on some parts. The patch also combines the CS configuration for the overo and igep0020 boards per request.
---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile tested only.
arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++ board/isee/igep0020/igep0020.c | 1 + board/isee/igep0020/igep0020.h | 9 --------- board/overo/overo.c | 1 + board/overo/overo.h | 9 --------- 5 files changed, 11 insertions(+), 18 deletions(-)
arch/arm/include/asm/arch-omap3/omap_gpmc.h +9 -0
@@ -80,4 +80,13 @@ }#endif +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */ +#define NET_LAN9221_GPMC_CONFIG1 0x00001000 +#define NET_LAN9221_GPMC_CONFIG2 0x00060700 +#define NET_LAN9221_GPMC_CONFIG3 0x00020201 +#define NET_LAN9221_GPMC_CONFIG4 0x06000700 +#define NET_LAN9221_GPMC_CONFIG5 0x0006090A +#define NET_LAN9221_GPMC_CONFIG6 0x87030000 +#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c +#endif /* __ASM_ARCH_OMAP_GPMC_H */
board/isee/igep0020/igep0020.c +1 -0
@@ -29,6 +29,7 @@#include <asm/arch/mmc_host_def.h> #include <asm/arch/mux.h> #include <asm/arch/sys_proto.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "igep0020.h"
board/isee/igep0020/igep0020.h +0 -9
@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = { "ONENAND", }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -static void setup_net_chip (void );/*
board/overo/overo.c +1 -0
@@ -37,6 +37,7 @@#include <asm/arch/mem.h> #include <asm/arch/sys_proto.h> #include <asm/arch/gpio.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "overo.h"
board/overo/overo.h +0 -9
@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {#endif }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -/* * IEN - Input Enable * IDIS - Input Disable
Signature · 1 line
1.7.4.4
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
2011/9/9 Philip Balister <[email protected]>:
Quoted 96 lines
The existing timing does not quite meet the minimum requirements in the LAN9221 datasheet. The timing in this patch solves problems noticed on some parts. The patch also combines the CS configuration for the overo and igep0020 boards per request.
Signed-off-by Philip Balister <[email protected]>---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile tested only.?arch/arm/include/asm/arch-omap3/omap_gpmc.h | ? ?9 +++++++++ ?board/isee/igep0020/igep0020.c ? ? ? ? ? ? ?| ? ?1 + ?board/isee/igep0020/igep0020.h ? ? ? ? ? ? ?| ? ?9 --------- ?board/overo/overo.c ? ? ? ? ? ? ? ? ? ? ? ? | ? ?1 + ?board/overo/overo.h ? ? ? ? ? ? ? ? ? ? ? ? | ? ?9 ---------?5 files changed, 11 insertions(+), 18 deletions(-)
arch/arm/include/asm/arch-omap3/omap_gpmc.h +0
-0@@ -80,4 +80,13 @@ ?}?#endif
arch/arm/include/asm/arch-omap3/omap_gpmc.h +9
-0+/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */ +#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 +#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00060700 +#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 +#define NET_LAN9221_GPMC_CONFIG4 ? ?0x06000700 +#define NET_LAN9221_GPMC_CONFIG5 ? ?0x0006090A +#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 +#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c +?#endif /*
__ASM_ARCH_OMAP_GPMC_H*/board/isee/igep0020/igep0020.c +0
-0@@ -29,6 +29,7 @@?#include <
asm/arch/mmc_host_def.h>
?#include <asm/arch/mux.h>
?#include <asm/arch/sys_proto.h>
+#include <asm/arch/omap_gpmc.h>
?#include <asm/mach-types.h>
?#include "igep0020.h"board/isee/igep0020/igep0020.h +0
-9@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = { ? ? ? ?"ONENAND", ?}; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c - ?static void setup_net_chip(void);?/*
board/overo/overo.c +0
-0@@ -37,6 +37,7 @@?#include <
asm/arch/mem.h>
?#include <asm/arch/sys_proto.h>
?#include <asm/arch/gpio.h>
+#include <asm/arch/omap_gpmc.h>
?#include <asm/mach-types.h>
?#include "overo.h"board/overo/overo.h +0
-0@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {?#endif
?};board/overo/overo.h +0
-9-/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c -
Quoted 7 lines
?/*
?* IEN ?- Input Enable
?* IDIS - Input Disable
--
1.7.4.4
Tested on igep0020 machine (aka IGEP v2). Thanks Philip
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
I see I should have copied a maintainer on this patch. Which tree will this sort of path go upstream via? It seems like my choices are ARM of OMAP3.
I've got a number of other patches that should go upstream that are Overo centric. In general, what route should they take upstream?
Philip
Quoted 113 lines · Enric Balletb? i Serra
2011/9/9 Philip Balister<[email protected]>:
Quoted 100 lines
The existing timing does not quite meet the minimum requirements in the LAN9221 datasheet. The timing in this patch solves problems noticed on some parts. The patch also combines the CS configuration for the overo and igep0020 boards per request.
Signed-off-by Philip Balister<[email protected]>---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile tested only.arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++ board/isee/igep0020/igep0020.c | 1 + board/isee/igep0020/igep0020.h | 9 --------- board/overo/overo.c | 1 + board/overo/overo.h | 9 --------- 5 files changed, 11 insertions(+), 18 deletions(-)arch/arm/include/asm/arch-omap3/omap_gpmc.h +9
-0@@ -80,4 +80,13 @@ }#endif +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */ +#define NET_LAN9221_GPMC_CONFIG1 0x00001000 +#define NET_LAN9221_GPMC_CONFIG2 0x00060700 +#define NET_LAN9221_GPMC_CONFIG3 0x00020201 +#define NET_LAN9221_GPMC_CONFIG4 0x06000700 +#define NET_LAN9221_GPMC_CONFIG5 0x0006090A +#define NET_LAN9221_GPMC_CONFIG6 0x87030000 +#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c +#endif /* __ASM_ARCH_OMAP_GPMC_H */ board/isee/igep0020/igep0020.c +1
-0@@ -29,6 +29,7 @@#include <asm/arch/mmc_host_def.h> #include <asm/arch/mux.h> #include <asm/arch/sys_proto.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "igep0020.h" board/isee/igep0020/igep0020.h +0
-9@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = { "ONENAND", }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -static void setup_net_chip (void );/* board/overo/overo.c +1
-0@@ -37,6 +37,7 @@#include <asm/arch/mem.h> #include <asm/arch/sys_proto.h> #include <asm/arch/gpio.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "overo.h" board/overo/overo.h +0
-10@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {#endif }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -/* * IEN - Input Enable * IDIS - Input Disable -- Quoted 3 lines
1.7.4.4
Tested on igep0020 machine (aka IGEP v2). Thanks Philip
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
Quoted 6 lines · Philip Balister
I see I should have copied a maintainer on this patch. Which tree will this sort of path go upstream via? It seems like my choices are ARM of OMAP3.
I've got a number of other patches that should go upstream that are Overo centric. In general, what route should they take upstream?
Ping? Any tips for getting patched committed would be helpful, I'm sure I'm doing something wrong.
Philip
Quoted 122 lines
Philip
Quoted 107 lines · Enric Balletb? i Serra
2011/9/9 Philip Balister<[email protected]>:
Quoted 100 lines
The existing timing does not quite meet the minimum requirements in the LAN9221 datasheet. The timing in this patch solves problems noticed on some parts. The patch also combines the CS configuration for the overo and igep0020 boards per request.
Signed-off-by Philip Balister<[email protected]>---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile tested only.arch/arm/include/asm/arch-omap3/omap_gpmc.h | 9 +++++++++ board/isee/igep0020/igep0020.c | 1 + board/isee/igep0020/igep0020.h | 9 --------- board/overo/overo.c | 1 + board/overo/overo.h | 9 --------- 5 files changed, 11 insertions(+), 18 deletions(-)arch/arm/include/asm/arch-omap3/omap_gpmc.h +9
-0@@ -80,4 +80,13 @@ }#endif +/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */ +#define NET_LAN9221_GPMC_CONFIG1 0x00001000 +#define NET_LAN9221_GPMC_CONFIG2 0x00060700 +#define NET_LAN9221_GPMC_CONFIG3 0x00020201 +#define NET_LAN9221_GPMC_CONFIG4 0x06000700 +#define NET_LAN9221_GPMC_CONFIG5 0x0006090A +#define NET_LAN9221_GPMC_CONFIG6 0x87030000 +#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c +#endif /* __ASM_ARCH_OMAP_GPMC_H */ board/isee/igep0020/igep0020.c +1
-0@@ -29,6 +29,7 @@#include <asm/arch/mmc_host_def.h> #include <asm/arch/mux.h> #include <asm/arch/sys_proto.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "igep0020.h" board/isee/igep0020/igep0020.h +0
-9@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = { "ONENAND", }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -static void setup_net_chip (void );/* board/overo/overo.c +1
-0@@ -37,6 +37,7 @@#include <asm/arch/mem.h> #include <asm/arch/sys_proto.h> #include <asm/arch/gpio.h> +#include <asm/arch/omap_gpmc.h> #include <asm/mach-types.h> #include "overo.h" board/overo/overo.h +0
-10@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {#endif }; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 0x00000f6c -/* * IEN - Input Enable * IDIS - Input Disable -- Quoted 3 lines
1.7.4.4
Tested on igep0020 machine (aka IGEP v2). Thanks Philip
Quoted 6 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
Quoted 10 lines · Philip Balister
Quoted 6 lines · Philip Balister
I see I should have copied a maintainer on this patch. Which tree will this sort of path go upstream via? It seems like my choices are ARM of OMAP3.
I've got a number of other patches that should go upstream that are Overo centric. In general, what route should they take upstream?
Ping? Any tips for getting patched committed would be helpful, I'm sure I'm doing something wrong.
Sandeep, is this a patch you can pull into either u-boot-ti/master or u-boot-ti/next? I believe it is just a bug fix and might be suitable to pull into the existing -rcX.
Quoted 131 lines
Philip
Quoted 118 lines
Philip
Quoted 107 lines · Enric Balletb? i Serra
2011/9/9 Philip Balister<[email protected]>:
Quoted 96 lines
The existing timing does not quite meet the minimum requirements in the LAN9221 datasheet. The timing in this patch solves problems noticed on some parts. The patch also combines the CS configuration for the overo and igep0020 boards per request.
Signed-off-by Philip Balister<[email protected]>---
Changes for v2: Added igep0020 board per Enric Balletb? i Serra. Compile tested only.? ?arch/arm/include/asm/arch-omap3/omap_gpmc.h | ? ?9 +++++++++ ? ?board/isee/igep0020/igep0020.c ? ? ? ? ? ? ?| ? ?1 + ? ?board/isee/igep0020/igep0020.h ? ? ? ? ? ? ?| ? ?9 --------- ? ?board/overo/overo.c ? ? ? ? ? ? ? ? ? ? ? ? | ? ?1 + ? ?board/overo/overo.h ? ? ? ? ? ? ? ? ? ? ? ? | ? ?9 ---------? ?5 files changed, 11 insertions(+), 18 deletions(-)
arch/arm/include/asm/arch-omap3/omap_gpmc.h +0
-0@@ -80,4 +80,13 @@ ? ?}? ?#endif
arch/arm/include/asm/arch-omap3/omap_gpmc.h +9
-0+/* GPMC CS configuration for an SMSC LAN9221 ethernet controller */ +#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 +#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00060700 +#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 +#define NET_LAN9221_GPMC_CONFIG4 ? ?0x06000700 +#define NET_LAN9221_GPMC_CONFIG5 ? ?0x0006090A +#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 +#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c +? ?#endif /*
__ASM_ARCH_OMAP_GPMC_H*/board/isee/igep0020/igep0020.c +0
-0@@ -29,6 +29,7 @@? ?#include<asm/arch/mmc_host_def.h>
? ?#include<asm/arch/mux.h>
? ?#include<asm/arch/sys_proto.h>
+#include<asm/arch/omap_gpmc.h>
? ?#include<asm/mach-types.h>
? ?#include "igep0020.h"board/isee/igep0020/igep0020.h +0
-9@@ -29,15 +29,6 @@ const omap3_sysinfo sysinfo = { ? ? ? ? ?"ONENAND", ? ?}; -/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c - ? ?static void setup_net_chip(void);? ?/*
board/overo/overo.c +0
-0@@ -37,6 +37,7 @@? ?#include<asm/arch/mem.h>
? ?#include<asm/arch/sys_proto.h>
? ?#include<asm/arch/gpio.h>
+#include<asm/arch/omap_gpmc.h>
? ?#include<asm/mach-types.h>
? ?#include "overo.h"board/overo/overo.h +0
-0@@ -33,15 +33,6 @@ const omap3_sysinfo sysinfo = {? ?#endif
? ?};board/overo/overo.h +0
-9-/* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */ -#define NET_LAN9221_GPMC_CONFIG1 ? ?0x00001000 -#define NET_LAN9221_GPMC_CONFIG2 ? ?0x00080701 -#define NET_LAN9221_GPMC_CONFIG3 ? ?0x00020201 -#define NET_LAN9221_GPMC_CONFIG4 ? ?0x08030703 -#define NET_LAN9221_GPMC_CONFIG5 ? ?0x00060908 -#define NET_LAN9221_GPMC_CONFIG6 ? ?0x87030000 -#define NET_LAN9221_GPMC_CONFIG7 ? ?0x00000f6c -Quoted 7 lines
? ?/*
? ?* IEN ?- Input Enable
? ?* IDIS - Input Disable
--
1.7.4.4Tested on igep0020 machine (aka IGEP v2). Thanks Philip
Quoted 6 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-bootQuoted 4 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Paulraj
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
Quoted 13 lines
Quoted 8 lines · Philip Balister
Quoted 6 lines · Philip Balister
I see I should have copied a maintainer on this patch. Which tree will this sort of path go upstream via? It seems like my choices are ARM of OMAP3.
I've got a number of other patches that should go upstream that are Overo centric. In general, what route should they take upstream?
Quoted 7 lines
Quoted 2 lines
Ping? Any tips for getting patched committed would be helpful, I'm sure I'm doing something wrong.
Sandeep, is this a patch you can pull into either u-boot-ti/master or u-boot-ti/next? I believe it is just a bug fix and might be suitable to pull into the existing -rcX.
u-boot-ti/next
Paulraj
PATCH v2 1/1 OMAP3: Overo: Update GPMC timing for ethernet chip.
In reply to Philip BalisterQuoted 8 lines · Philip Balister
Quoted 6 lines
I see I should have copied a maintainer on this patch. Which tree will this sort of path go upstream via? It seems like my choices are ARM of OMAP3.
I've got a number of other patches that should go upstream that are Overo centric. In general, what route should they take upstream?
You can send them as soon as you are ready.
Quoted 3 lines
Ping? Any tips for getting patched committed would be helpful, I'm sure I'm doing something wrong.
I'll apply it to u-boot-ti/next
I'll setup a next branch soon.
--Sandeep