m68knommu: make persistent clock code consistent with m68k
Subsystems (2)
PATCH 1/3 m68knommu: make persistent clock code consistent with m68k
From: Greg Ungerer <[email protected]>
The read_persistent_clock() code is different on m68knommu, for really no reason. With a few changes to support function names and some code re-organization the code can be made the same.
This will make it easier to merge the arch/m68k/kernel/time.c for m68k and m68knommu in a future patch.
--- arch/m68k/include/asm/machdep.h | 2 - arch/m68k/kernel/setup_no.c | 2 + arch/m68k/kernel/time_no.c | 36 +++++++++++----------------------- arch/m68k/platform/68328/config.c | 5 ++- arch/m68k/platform/68328/timers.c | 18 ++++++++++------ arch/m68k/platform/68360/config.c | 8 +------ arch/m68k/platform/68EZ328/config.c | 5 ++- arch/m68k/platform/68VZ328/config.c | 5 ++- 8 files changed, 35 insertions(+), 46 deletions(-)
arch/m68k/include/asm/machdep.h +0 -2
@@ -22,8 +22,6 @@ extern unsigned int (*mach_get_ss)(void);extern int (*mach_get_rtc_pll)(struct rtc_pll_info *);extern int (*mach_set_rtc_pll)(struct rtc_pll_info *);extern int (*mach_set_clock_mmss)(unsigned long ); -extern void (*mach_gettod)(int *year,int *mon,int *day,int *hour, -int *min,int *sec);extern void (*mach_reset)(void );extern void (*mach_halt)(void );extern void (*mach_power_off)(void );
arch/m68k/kernel/setup_no.c +2 -0
@@ -31,6 +31,7 @@#include <linux/init.h> #include <linux/initrd.h> #include <linux/root_dev.h> +#include <linux/rtc.h> #include <asm/setup.h> #include <asm/irq.h>
@@ -48,6 +49,7 @@ char __initdata command_line[COMMAND_LINE_SIZE];/* machine dependent timer functions */ int (*mach_set_clock_mmss)(unsigned long ); +int (*mach_hwclk) (int ,struct rtc_time *);/* machine dependent reboot functions */ void (*mach_reset)(void );
arch/m68k/kernel/time_no.c +12 -24
@@ -20,15 +20,11 @@#include <linux/profile.h> #include <linux/time.h> #include <linux/timex.h> +#include <linux/rtc.h> #include <asm/machdep.h> #include <asm/irq_regs.h> -#define TICK_SIZE (tick_nsec / 1000) - -/* machine dependent timer functions */ -void (*mach_gettod)(int *,int *,int *,int *,int *,int *); -static inline int set_rtc_mmss (unsigned long nowtime) {if (mach_set_clock_mmss)
@@ -55,28 +51,20 @@ irqreturn_t arch_timer_interrupt(int irq, void *dummy) }#endif -static unsigned long read_rtc_mmss (void ) -{ -unsigned int year, mon, day, hour, min, sec; - -if (mach_gettod) { -mach_gettod (&year, &mon, &day, &hour, &min, &sec); -if ((year +=1900 ) <1970 ) - year +=100 ; - }else { - year =1970 ; - mon = day =1 ; - hour = min = sec =0 ; - } - - -return mktime (year, mon, day, hour, min, sec); -} -void read_persistent_clock (struct timespec *ts) { - ts->tv_sec =read_rtc_mmss (); +struct rtc_time time; + ts->tv_sec =0 ; ts->tv_nsec =0 ; + +if (mach_hwclk) { +mach_hwclk (0 , &time); + +if ((time.tm_year +=1900 ) <1970 ) + time.tm_year +=100 ; + ts->tv_sec =mktime (time.tm_year, time.tm_mon, time.tm_mday, + time.tm_hour, time.tm_min, time.tm_sec); + } }int update_persistent_clock (struct timespec now)
arch/m68k/platform/68328/config.c +3 -2
@@ -17,6 +17,7 @@#include <linux/types.h> #include <linux/kernel.h> +#include <linux/rtc.h> #include <asm/system.h> #include <asm/machdep.h> #include <asm/MC68328.h>
@@ -26,7 +27,7 @@/***************************************************************************/ -void m68328_timer_gettod (int *year,int *mon,int *day,int *hour,int *min,int *sec); +int m68328_hwclk (int set,struct rtc_time *t);/***************************************************************************/
@@ -48,7 +49,7 @@ void config_BSP(char *command, int len)printk (KERN_INFO "68328 support Kenneth Albanowski <[email protected]>\n" );printk (KERN_INFO "68328/Pilot support Bernhard Kuhn <[email protected]>\n" ); - mach_gettod = m68328_timer_gettod; + mach_hwclk = m68328_hwclk; mach_reset = m68328_reset; }
arch/m68k/platform/68328/timers.c +11 -7
@@ -20,6 +20,7 @@#include <linux/interrupt.h> #include <linux/irq.h> #include <linux/clocksource.h> +#include <linux/rtc.h> #include <asm/setup.h> #include <asm/system.h> #include <asm/pgtable.h>
@@ -119,14 +120,17 @@ void hw_timer_init(void)/***************************************************************************/ -void m68328_timer_gettod (int *year,int *mon,int *day,int *hour,int *min,int *sec) +int m68328_hwclk (int set,struct rtc_time *t) { -long now =RTCTIME ; - - *year = *mon = *day =1 ; - *hour = (now >>24 ) %24 ; - *min = (now >>16 ) %60 ; - *sec = now %60 ; +if (!set) { +long now =RTCTIME ; + t->tm_year = t->tm_mon = t->tm_mday =1 ; + t->tm_hour = (now >>24 ) %24 ; + t->tm_min = (now >>16 ) %60 ; + t->tm_sec = now %60 ; + } + +return 0 ; }/***************************************************************************/
arch/m68k/platform/68360/config.c +1 -7
@@ -103,11 +103,6 @@ void hw_timer_init(void) pquicc->timer_tgcr = tgcr_save; } -void BSP_gettod (int *yearp,int *monp,int *dayp, -int *hourp,int *minp,int *secp) -{ -} -int BSP_set_clock_mmss (unsigned long nowtime) {#if 0
@@ -181,6 +176,5 @@ void config_BSP(char *command, int len) scc1_hwaddr ="\00\01\02\03\04\05" ;#endif - mach_gettod = BSP_gettod; - mach_reset = BSP_reset; + mach_reset = BSP_reset; }
arch/m68k/platform/68EZ328/config.c +3 -2
@@ -15,6 +15,7 @@#include <linux/types.h> #include <linux/kernel.h> +#include <linux/rtc.h> #include <asm/system.h> #include <asm/pgtable.h> #include <asm/machdep.h>
@@ -25,7 +26,7 @@/***************************************************************************/ -void m68328_timer_gettod (int *year,int *mon,int *day,int *hour,int *min,int *sec); +int m68328_hwclk (int set,struct rtc_time *t);/***************************************************************************/
@@ -69,7 +70,7 @@ void config_BSP(char *command, int len) else command[0] = 0;#endif - mach_gettod = m68328_timer_gettod; + mach_hwclk = m68328_hwclk; mach_reset = m68ez328_reset; }
arch/m68k/platform/68VZ328/config.c +3 -2
@@ -20,6 +20,7 @@#include <linux/netdevice.h> #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/rtc.h> #include <asm/system.h> #include <asm/pgtable.h>
@@ -33,7 +34,7 @@/***************************************************************************/ -void m68328_timer_gettod (int *year,int *mon,int *day,int *hour,int *min,int *sec); +int m68328_hwclk (int set,struct rtc_time *t);/***************************************************************************/ /* Init Drangon Engine hardware */
@@ -181,7 +182,7 @@ void config_BSP(char *command, int size)init_hardware (command, size); - mach_gettod = m68328_timer_gettod; + mach_hwclk = m68328_hwclk; mach_reset = m68vz328_reset; }
Signature · 1 line
1.7.0.4
PATCH 2/3 m68knommu: modify timer init code to make it consistent with m68k code
From: Greg Ungerer <[email protected]>
With a few small changes we can make the m68knommu timer init code the same as the m68k code. By using the mach_sched_init function pointer and reworking the current timer initializers to keep track of the common m68k timer_interrupt() handler we end up with almost identical code for m68knommu.
This will allow us to more easily merge the mmu and non-mmu m68k time.c in future patches.
--- arch/m68k/include/asm/machdep.h | 3 +-- arch/m68k/kernel/setup_no.c | 1 + arch/m68k/kernel/time_no.c | 8 +++----- arch/m68k/platform/5206/config.c | 1 + arch/m68k/platform/520x/config.c | 1 + arch/m68k/platform/523x/config.c | 1 + arch/m68k/platform/5249/config.c | 1 + arch/m68k/platform/5272/config.c | 1 + arch/m68k/platform/527x/config.c | 1 + arch/m68k/platform/528x/config.c | 1 + arch/m68k/platform/5307/config.c | 1 + arch/m68k/platform/532x/config.c | 2 ++ arch/m68k/platform/5407/config.c | 1 + arch/m68k/platform/54xx/config.c | 1 + arch/m68k/platform/coldfire/pit.c | 2 +- arch/m68k/platform/coldfire/sltimers.c | 7 +++++-- arch/m68k/platform/coldfire/timers.c | 7 +++++-- 17 files changed, 28 insertions(+), 12 deletions(-)
arch/m68k/include/asm/machdep.h +1 -2
@@ -33,9 +33,8 @@ extern void (*mach_l2_flush) (int);extern void (*mach_beep) (unsigned int ,unsigned int );/* Hardware clock functions */ -extern void hw_timer_init (void ); +extern void hw_timer_init (irq_handler_t handler);extern unsigned long hw_timer_offset (void ); -extern irqreturn_t arch_timer_interrupt (int irq,void *dummy);extern void config_BSP (char *command,int len);
arch/m68k/kernel/setup_no.c +1 -0
@@ -48,6 +48,7 @@ EXPORT_SYMBOL(memory_end);char __initdata command_line[COMMAND_LINE_SIZE ];/* machine dependent timer functions */ +void (*mach_sched_init)(irq_handler_t handler)__initdata =NULL ;int (*mach_set_clock_mmss)(unsigned long );int (*mach_hwclk) (int ,struct rtc_time *);
arch/m68k/kernel/time_no.c +3 -5
@@ -32,12 +32,11 @@ static inline int set_rtc_mmss(unsigned long nowtime)return -1 ; } -#ifndef CONFIG_GENERIC_CLOCKEVENTS /* * timer_interrupt() needs to keep up the real-time clock, * as well as call the "xtime_update()" routine every clocktick */ -irqreturn_t arch_timer_interrupt (int irq,void *dummy) +static irqreturn_t timer_interrupt (int irq,void *dummy) {if (current->pid)
@@ -49,7 +48,6 @@ irqreturn_t arch_timer_interrupt(int irq, void *dummy)return (IRQ_HANDLED ); } -#endif void read_persistent_clock (struct timespec *ts) {
@@ -72,7 +70,7 @@ int update_persistent_clock(struct timespec now)return set_rtc_mmss (now.tv_sec); } -void time_init (void ) +void __init time_init (void ) { -hw_timer_init (); +mach_sched_init (timer_interrupt); }
arch/m68k/platform/5206/config.c +1 -0
@@ -105,6 +105,7 @@ void __init config_BSP(char *commandp, int size)#endif /* CONFIG_NETtel */ mach_reset = m5206_cpu_reset; + mach_sched_init = hw_timer_init;m5206_timers_init ();m5206_uarts_init ();
arch/m68k/platform/520x/config.c +1 -0
@@ -291,6 +291,7 @@ static void m520x_cpu_reset(void)void __init config_BSP (char *commandp,int size) { mach_reset = m520x_cpu_reset; + mach_sched_init = hw_timer_init;m520x_uarts_init ();m520x_fec_init ();#if defined(CONFIG_SPI_COLDFIRE_QSPI ) || defined(CONFIG_SPI_COLDFIRE_QSPI_MODULE )
arch/m68k/platform/523x/config.c +1 -0
@@ -274,6 +274,7 @@ static void m523x_cpu_reset(void)void __init config_BSP (char *commandp,int size) { mach_reset = m523x_cpu_reset; + mach_sched_init = hw_timer_init; }/***************************************************************************/
arch/m68k/platform/5249/config.c +1 -0
@@ -307,6 +307,7 @@ void m5249_cpu_reset(void)void __init config_BSP (char *commandp,int size) { mach_reset = m5249_cpu_reset; + mach_sched_init = hw_timer_init;m5249_timers_init ();m5249_uarts_init ();#ifdef CONFIG_M5249C3
arch/m68k/platform/5272/config.c +1 -0
@@ -146,6 +146,7 @@ void __init config_BSP(char *commandp, int size)#endif mach_reset = m5272_cpu_reset; + mach_sched_init = hw_timer_init; }/***************************************************************************/
arch/m68k/platform/527x/config.c +1 -0
@@ -364,6 +364,7 @@ static void m527x_cpu_reset(void)void __init config_BSP (char *commandp,int size) { mach_reset = m527x_cpu_reset; + mach_sched_init = hw_timer_init;m527x_uarts_init ();m527x_fec_init ();#if defined(CONFIG_SPI_COLDFIRE_QSPI ) || defined(CONFIG_SPI_COLDFIRE_QSPI_MODULE )
arch/m68k/platform/528x/config.c +1 -0
@@ -306,6 +306,7 @@ void __init config_BSP(char *commandp, int size)static int __init init_BSP (void ) { mach_reset = m528x_cpu_reset; + mach_sched_init = hw_timer_init;m528x_uarts_init ();m528x_fec_init ();#if defined(CONFIG_SPI_COLDFIRE_QSPI ) || defined(CONFIG_SPI_COLDFIRE_QSPI_MODULE )
arch/m68k/platform/5307/config.c +1 -0
@@ -115,6 +115,7 @@ void __init config_BSP(char *commandp, int size)#endif mach_reset = m5307_cpu_reset; + mach_sched_init = hw_timer_init;m5307_timers_init ();m5307_uarts_init ();
arch/m68k/platform/532x/config.c +2 -0
@@ -263,6 +263,8 @@ void __init config_BSP(char *commandp, int size) }#endif + mach_sched_init = hw_timer_init; +#ifdef CONFIG_BDM_DISABLE /* * Disable the BDM clocking. This also turns off most of the rest of
arch/m68k/platform/5407/config.c +1 -0
@@ -99,6 +99,7 @@ void m5407_cpu_reset(void)void __init config_BSP (char *commandp,int size) { mach_reset = m5407_cpu_reset; + mach_sched_init = hw_timer_init;m5407_timers_init ();m5407_uarts_init ();
arch/m68k/platform/54xx/config.c +1 -0
@@ -145,6 +145,7 @@ void __init config_BSP(char *commandp, int size)mmu_context_init ();#endif mach_reset = mcf54xx_reset; + mach_sched_init = hw_timer_init;m54xx_uarts_init (); }
arch/m68k/platform/coldfire/pit.c +1 -1
@@ -149,7 +149,7 @@ static struct clocksource pit_clk = {/***************************************************************************/ -void hw_timer_init (void ) +void hw_timer_init (irq_handler_t handler) { cf_pit_clockevent.cpumask =cpumask_of (smp_processor_id ()); cf_pit_clockevent.mult =div_sc (FREQ ,NSEC_PER_SEC ,32 );
arch/m68k/platform/coldfire/sltimers.c +5 -2
@@ -81,12 +81,14 @@ void mcfslt_profile_init(void)static u32 mcfslt_cycles_per_jiffy;static u32 mcfslt_cnt; +static irq_handler_t timer_interrupt; +static irqreturn_t mcfslt_tick (int irq,void *dummy) {/* Reset Slice Timer 0 */ __raw_writel (MCFSLT_SSR_BE |MCFSLT_SSR_TE ,TA (MCFSLT_SSR )); mcfslt_cnt += mcfslt_cycles_per_jiffy; -return arch_timer_interrupt (irq, dummy); +return timer_interrupt (irq, dummy); }static struct irqaction mcfslt_timer_irq = {
@@ -121,7 +123,7 @@ static struct clocksource mcfslt_clk = { .flags = CLOCK_SOURCE_IS_CONTINUOUS, }; -void hw_timer_init (void ) +void hw_timer_init (irq_handler_t handler) { mcfslt_cycles_per_jiffy =MCF_BUSCLK /HZ ;/*
@@ -136,6 +138,7 @@ void hw_timer_init(void)/* initialize mcfslt_cnt knowing that slice timers count down */ mcfslt_cnt = mcfslt_cycles_per_jiffy; + timer_interrupt = handler;setup_irq (MCF_IRQ_TIMER , &mcfslt_timer_irq);clocksource_register_hz (&mcfslt_clk,MCF_BUSCLK );
arch/m68k/platform/coldfire/timers.c +5 -2
@@ -47,6 +47,8 @@ void coldfire_profile_init(void);static u32 mcftmr_cycles_per_jiffy;static u32 mcftmr_cnt; +static irq_handler_t timer_interrupt; +/***************************************************************************/ static irqreturn_t mcftmr_tick (int irq,void *dummy)
@@ -55,7 +57,7 @@ static irqreturn_t mcftmr_tick(int irq, void *dummy)__raw_writeb (MCFTIMER_TER_CAP |MCFTIMER_TER_REF ,TA (MCFTIMER_TER )); mcftmr_cnt += mcftmr_cycles_per_jiffy; -return arch_timer_interrupt (irq, dummy); +return timer_interrupt (irq, dummy); }/***************************************************************************/
@@ -94,7 +96,7 @@ static struct clocksource mcftmr_clk = {/***************************************************************************/ -void hw_timer_init (void ) +void hw_timer_init (irq_handler_t handler) {__raw_writew (MCFTIMER_TMR_DISABLE ,TA (MCFTIMER_TMR )); mcftmr_cycles_per_jiffy =FREQ /HZ ;
@@ -110,6 +112,7 @@ void hw_timer_init(void)clocksource_register_hz (&mcftmr_clk,FREQ ); + timer_interrupt = handler;setup_irq (MCF_IRQ_TIMER , &mcftmr_timer_irq);#ifdef CONFIG_HIGHPROFILE
Signature · 1 line
1.7.0.4
PATCH 3/3 m68k: merge mmu and non-mmu versions of time.c
In reply to [email protected]From: Greg Ungerer <[email protected]>
There is only trivial differences between the mmu time_mm.c and non-mmu time_no.c files. Merge them back into a single time.c.
--- arch/m68k/kernel/time.c | 128 ++++++++++++++++++++++++++++++++++++++++++-- arch/m68k/kernel/time_mm.c | 114 --------------------------------------- arch/m68k/kernel/time_no.c | 76 -------------------------- 3 files changed, 123 insertions(+), 195 deletions(-) delete mode 100644 arch/m68k/kernel/time_mm.c delete mode 100644 arch/m68k/kernel/time_no.c
arch/m68k/kernel/time.c +123 -5
@@ -1,5 +1,123 @@ -#if defined(CONFIG_MMU ) && !defined(CONFIG_COLDFIRE ) -#include "time_mm.c" -#else -#include "time_no.c" -#endif +/* +* linux/arch/m68k/kernel/time.c +* +* Copyright (C) 1991, 1992, 1995 Linus Torvalds +* +* This file contains the m68k-specific time handling details. +* Most of the stuff is located in the machine specific files. +* +* 1997-09-10 Updated NTP code according to technical memorandum Jan '96 +* "A Kernel Model for Precision Timekeeping" by Dave Mills +*/ + +#include <linux/errno.h> +#include <linux/module.h> +#include <linux/sched.h> +#include <linux/kernel.h> +#include <linux/param.h> +#include <linux/string.h> +#include <linux/mm.h> +#include <linux/rtc.h> +#include <linux/platform_device.h> + +#include <asm/machdep.h> +#include <asm/io.h> +#include <asm/irq_regs.h> + +#include <linux/time.h> +#include <linux/timex.h> +#include <linux/profile.h> + +static inline int set_rtc_mmss (unsigned long nowtime) +{ +if (mach_set_clock_mmss) +return mach_set_clock_mmss (nowtime); +return -1 ; +} + +/* +* timer_interrupt() needs to keep up the real-time clock, +* as well as call the "xtime_update()" routine every clocktick +*/ +static irqreturn_t timer_interrupt (int irq,void *dummy) +{ +xtime_update (1 ); +update_process_times (user_mode (get_irq_regs ())); +profile_tick (CPU_PROFILING ); + +#ifdef CONFIG_HEARTBEAT +/* use power LED as a heartbeat instead -- much more useful +for debugging -- based on the version for PReP by Cort */ +/* acts like an actual heart beat -- ie thump-thump-pause... */ +if (mach_heartbeat) { +static unsigned cnt =0 , period =0 , dist =0 ; + +if (cnt ==0 || cnt == dist) +mach_heartbeat (1 ); +else if (cnt ==7 || cnt == dist+7 ) +mach_heartbeat (0 ); + +if (++cnt > period) { + cnt =0 ; +/* The hyperbolic function below modifies the heartbeat period +* length in dependency of the current (5min) load. It goes +* through the points f(0)=126, f(1)=86, f(5)=51, +* f(inf)->30. */ + period = ((672 <<FSHIFT )/(5 *avenrun[0 ]+(7 <<FSHIFT ))) +30 ; + dist = period /4 ; + } + } +#endif /* CONFIG_HEARTBEAT */ +return IRQ_HANDLED ; +} + +void read_persistent_clock (struct timespec *ts) +{ +struct rtc_time time; + ts->tv_sec =0 ; + ts->tv_nsec =0 ; + +if (mach_hwclk) { +mach_hwclk (0 , &time); + +if ((time.tm_year +=1900 ) <1970 ) + time.tm_year +=100 ; + ts->tv_sec =mktime (time.tm_year, time.tm_mon, time.tm_mday, + time.tm_hour, time.tm_min, time.tm_sec); + } +} + +int update_persistent_clock (struct timespec now) +{ +return set_rtc_mmss (now.tv_sec); +} + +void __init time_init (void ) +{ +mach_sched_init (timer_interrupt); +} + +#ifdef CONFIG_M68KCLASSIC + +u32 arch_gettimeoffset (void ) +{ +return mach_gettimeoffset () *1000 ; +} + +static int __init rtc_init (void ) +{ +struct platform_device *pdev; + +if (!mach_hwclk) +return -ENODEV ; + + pdev =platform_device_register_simple ("rtc-generic" ,-1 ,NULL ,0 ); +if (IS_ERR (pdev)) +return PTR_ERR (pdev); + +return 0 ; +} + +module_init (rtc_init); + +#endif /* CONFIG_M68KCLASSIC */
arch/m68k/kernel/time_mm.c deleted +0 -114
114 lines not on this page · raw message
arch/m68k/kernel/time_no.c deleted +0 -76
76 lines not on this page · raw message
Signature · 1 line
1.7.0.4
Geert Uytterhoeven
maintainerRe: [PATCH 3/3] m68k: merge mmu and non-mmu versions of time.c
arch/m68k/kernel/time.c line 93
Quoted 4 lines · On Tue, Feb 7, 2012 at 04:09, <[email protected]> wrote:
arch/m68k/kernel/time.c +4
-0+int update_persistent_clock (struct timespec now) +{ + return set_rtc_mmss(now.tv_sec); +}
This adds update_persistent_clock() for MMU, which was not present before. It's only called if CONFIG_GENERIC_CMOS_UPDATE is set, but arch/m68k/Kconfig has:
config GENERIC_CMOS_UPDATE
def_bool !MMU
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH 3/3] m68k: merge mmu and non-mmu versions of time.c
Hi Geert,
Quoted 10 lines · Geert Uytterhoeven
arch/m68k/kernel/time.c line 93
Quoted 4 lines · On Tue, Feb 7, 2012 at 04:09,<[email protected]> wrote:
arch/m68k/kernel/time.c +4
-0+int update_persistent_clock (struct timespec now) +{ +return set_rtc_mmss (now.tv_sec); +}This adds
update_persistent_clock()for MMU, which was not present before. It's only called ifCONFIG_GENERIC_CMOS_UPDATEis set, butarch/m68k/Kconfighas:
Quoted 2 lines
config
GENERIC_CMOS_UPDATE
def_bool!MMU
Yep. Again I was trying to just have fewer #ifdefs.
But looking at this further, I don't think there is any point having CONFIG_GENERIC_CMOS_UPDATE defined for the non-MMU case. The code for update_persistent_clock() calls set_rtc_mmss() which relies on the sub-arch code having set mach_set_clock_mmss to do the real work. But that is not set for any non-MMU code paths. Seems like we can remove it for everyone m68k type. Or did I miss something :-)
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected] SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com