Skip to contentSkip to conversation

iommu/tegra-gart: fix spin_unlock in map failure path

PATCH Applied Lucas Stach 3 participants 3 messages Mar 12, 2012 – Mar 13, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu/tegra-gart: fix spin_unlock in map failure path

This must have been messed up while merging, the intention was clearly to unlock there.

---
 drivers/iommu/tegra-gart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/iommu/tegra-gart.c +1 -1
index b21598f..779306e 100644
@@ -246,7 +246,7 @@ static int gart_iommu_map(struct iommu_domain *domain, unsigned long iova,
 	pfn = __phys_to_pfn(pa);
 	if (!pfn_valid(pfn)) {
 		dev_err(gart->dev, "Invalid page: %08x\n", pa);
-		spin_lock_irqsave(&gart->pte_lock, flags);
+		spin_unlock_irqrestore(&gart->pte_lock, flags);
 		return -EINVAL;
 	}
 	gart_set_pte(gart, iova, GART_PTE(pfn));
Signature · 1 line
1.7.7.6
#1 lore raw

Hi Lucas,

Quoted 4 lines · On Mon, 12 Mar 2012 20:15:01 +0100 Lucas Stach…

This must have been messed up while merging, the intention was clearly to unlock there.

Good catch. Thanks.
Joerg, Could you put this one on your queue?