iio: dac: ad5446: Don't set error code to voltage_uv

PATCH Superseded Axel Lin 1 participant 1 message Dec 18, 2012

Subsystems (3)

IIO Analog Devices IIO drivers AD5446 Analog devices inc AD5446 DAC driver

lore

Share & tools

lore

Axel Lin

author

2012-12-18 01:50 UTC #0 lore raw

PATCH 1/1 iio: dac: ad5446: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/iio/dac/ad5446.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

drivers/iio/dac/ad5446.c +5 -1

index 3310cbb..607378f 100644
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(reg);
+		ret = regulator_get_voltage(reg);
+		if (ret)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	indio_dev = iio_device_alloc(sizeof(*st));

Signature · 1 line

1.7.9.5