iio: dac: ad5446: Don't set error code to voltage_uv
PATCH v2 1/1 iio: dac: ad5446: Don't set error code to voltage_uv
regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.
Signed-off-by Axel Lin <[email protected]>
---
Sorry. Just found I made the same mistake again. Here is v2, should check if ret is negative value.
drivers/iio/dac/ad5446.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iio/dac/ad5446.c +5 -1
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,if (ret) goto error_put_reg; - voltage_uv =regulator_get_voltage (reg); + ret =regulator_get_voltage (reg); +if (ret <0 ) + goto error_disable_reg; + + voltage_uv = ret; } indio_dev =iio_device_alloc (sizeof (*st));
Signature · 1 line
1.7.9.5
Jonathan Cameron
maintainerQuoted 4 lines · Axel Lin
regulator_get_voltage()may return negative error code. Add error checking to avoid setting error code tovoltage_uv.Signed-off-by Axel Lin <[email protected]>
added to fixes-togreg branch of iio.git
Quoted 24 lines
---
Sorry. Just found I made the same mistake again. Here is v2, should check if ret is negative value.drivers/iio/dac/ad5446.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/iio/dac/ad5446.c +5
-1@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,if (ret) goto error_put_reg; - voltage_uv =regulator_get_voltage (reg); + ret =regulator_get_voltage (reg); +if (ret <0 ) + goto error_disable_reg; + + voltage_uv = ret; } indio_dev =iio_device_alloc (sizeof (*st));