Skip to contentSkip to conversation

iio: dac: ad5446: Don't set error code to voltage_uv

PATCH In review Axel Lin 2 participants 2 messages Dec 18, 2012

Subsystems (3)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 iio: dac: ad5446: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.

---
Sorry. Just found I made the same mistake again. Here is v2, should check if ret is negative value.

 drivers/iio/dac/ad5446.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iio/dac/ad5446.c +5 -1
index 3310cbb..607378f 100644
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(reg);
+		ret = regulator_get_voltage(reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	indio_dev = iio_device_alloc(sizeof(*st));
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 4 lines · Axel Lin

regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.

added to fixes-togreg branch of iio.git

Quoted 24 lines

---
Sorry. Just found I made the same mistake again. Here is v2, should check if ret is negative value.

 drivers/iio/dac/ad5446.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iio/dac/ad5446.c +5 -1
index 3310cbb..607378f 100644
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(reg);
+		ret = regulator_get_voltage(reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	indio_dev = iio_device_alloc(sizeof(*st));