gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

PATCH Superseded Cong Ding 2 participants 5 messages Jan 15, 2013

Subsystems (3)

DRM drivers DRM misc nouveau

lore

Share & tools

lore

Cong Ding

author

2013-01-15 00:38 UTC #0 lore raw

PATCH 1/1 gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.

Signed-off-by Cong Ding <[email protected]>

---
 drivers/gpu/drm/nouveau/nouveau_fence.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

drivers/gpu/drm/nouveau/nouveau_fence.c +3 -5

index 1d049be..b6b8e49 100644
@@ -195,11 +195,9 @@ nouveau_fence_new(struct nouveau_channel *chan, struct nouveau_fence **pfence)
 		return -ENOMEM;
 	kref_init(&fence->kref);
 
-	if (chan) {
-		ret = nouveau_fence_emit(fence, chan);
-		if (ret)
-			nouveau_fence_unref(&fence);
-	}
+	ret = nouveau_fence_emit(fence, chan);
+	if (ret)
+		nouveau_fence_unref(&fence);
 
 	*pfence = fence;
 	return ret;

Signature · 1 line

1.7.10.4

David Howells

2013-01-15 10:39 UTC #1 lore raw

Quoted 2 lines · Cong Ding

the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.

Did you mean "The variable 'chan'"?

David

Cong Ding

author

2013-01-15 11:14 UTC #2 lore raw

Quoted 6 lines · David Howells

Quoted 2 lines · Cong Ding
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Did you mean "The variable 'chan'"?

sorry, my fault. so should I send a new version to correct the typo?
- cong

David Howells

2013-01-15 17:00 UTC #3 lore raw

Quoted 5 lines · Cong Ding

Quoted 4 lines
Quoted 2 lines
the variable sender is dereferenced in line 190, so it is no reason to check null again in line 198.
Did you mean "The variable 'chan'"?
sorry, my fault. so should I send a new version to correct the typo?

Yep.

David

Cong Ding

author

2013-01-15 17:19 UTC #4 lore raw

PATCH v2 1/1 gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check

the variable chan is dereferenced in line 190, so it is no reason to check null again in line 198.

Signed-off-by Cong Ding <[email protected]>

---
 drivers/gpu/drm/nouveau/nouveau_fence.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

drivers/gpu/drm/nouveau/nouveau_fence.c +3 -5

index 1d049be..b6b8e49 100644
@@ -195,11 +195,9 @@ nouveau_fence_new(struct nouveau_channel *chan, struct nouveau_fence **pfence)
 		return -ENOMEM;
 	kref_init(&fence->kref);
 
-	if (chan) {
-		ret = nouveau_fence_emit(fence, chan);
-		if (ret)
-			nouveau_fence_unref(&fence);
-	}
+	ret = nouveau_fence_emit(fence, chan);
+	if (ret)
+		nouveau_fence_unref(&fence);
 
 	*pfence = fence;
 	return ret;

Signature · 1 line

1.7.10.4