drm/i915: Fix missing variable initilization
Subsystems (2)
PATCH 1/1 drm/i915: Fix missing variable initilization
Need to initialize the variable wait to false.
Signed-off-by Syam Sidhardhan <[email protected]>
--- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_ddi.c +1 -1
@@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)struct intel_dp *intel_dp = &intel_dig_port->dp;struct drm_i915_private *dev_priv = encoder->dev->dev_private;enum port port = intel_dig_port->port; -bool wait;uint32_t val; +bool wait = false;if (I915_READ (DP_TP_CTL (port)) &DP_TP_CTL_ENABLE ) { val =I915_READ (DDI_BUF_CTL (port));
Signature · 1 line
1.7.9.5
Quoted 3 lines · Syam Sidhardhan
Need to initialize the variable wait to false.
Signed-off-by Syam Sidhardhan <[email protected]>
Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed something.
-Daniel
Quoted 21 lines
--- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_ddi.c +1
-1@@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)struct intel_dp *intel_dp = &intel_dig_port->dp;struct drm_i915_private *dev_priv = encoder->dev->dev_private;enum port port = intel_dig_port->port; -bool wait;uint32_t val; +bool wait = false;if (I915_READ (DP_TP_CTL (port)) &DP_TP_CTL_ENABLE ) { val =I915_READ (DDI_BUF_CTL (port));Signature · 1 line
1.7.9.5
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Damien Lespiau
Reviewed-byQuoted 7 lines · Daniel Vetter
Quoted 3 lines · Syam Sidhardhan
Need to initialize the variable wait to false.
Signed-off-by Syam Sidhardhan <[email protected]>Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed something.
FWIW, I posted a similar patch (without moving the variable around) on intel-gfx yesterday, so:
Reviewed-by Damien Lespiau <[email protected]>
Signature · 1 line
Damien