Skip to contentSkip to conversation

gpio: samsung: Add terminating entry for exynos_pinctrl_ids

PATCH RESEND In review Axel Lin 3 participants 3 messages Mar 16, 2013 – Mar 27, 2013 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 gpio: samsung: Add terminating entry for exynos_pinctrl_ids

The of_device_id table is supposed to be zero-terminated.

---
This patch was sent on https://lkml.org/lkml/2012/12/9/135
Re-generate the patch against linux-next and resend.

 drivers/gpio/gpio-samsung.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-samsung.c +1 -0
index 99e0fa4..b22ca79 100644
@@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
 		{ .compatible = "samsung,exynos4x12-pinctrl", },
 		{ .compatible = "samsung,exynos5250-pinctrl", },
 		{ .compatible = "samsung,exynos5440-pinctrl", },
+		{ }
 	};
 	for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
 		if (pctrl_np && of_device_is_available(pctrl_np))
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Axel Lin

The of_device_id table is supposed to be zero-terminated.

I think, would be better if this could be sent to upstream via gpio tree now.

Thanks.

- Kukjin

Quoted 21 lines

---
This patch was sent on https://lkml.org/lkml/2012/12/9/135
Re-generate the patch against linux-next and resend.

 drivers/gpio/gpio-samsung.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-samsung.c +1 -1
index 99e0fa4..b22ca79 100644
@@ -3030,6 +3030,7 @@ static __init int samsung_gpiolib_init(void)
 		{ .compatible = "samsung,exynos4x12-pinctrl", },
 		{ .compatible = "samsung,exynos5250-pinctrl", },
 		{ .compatible = "samsung,exynos5440-pinctrl", },
+		{ }
 	};
 	for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
 		if (pctrl_np && of_device_is_available(pctrl_np))
--

1.7.9.5