Add initial support for AQUILA-CYGNUS
cover Add initial support for AQUILA-CYGNUS
From: Enric Balletbo i Serra <[email protected]>
IGEP COM AQUILA and CYGNUS are two computer-on-module based on AM3354 and AM3352 processors. Both use SODIMM from factor and are designed for industrial range purpose.
Enric Balletbo i Serra (2):
Add DDR3 support for IGEP COM AQUILA/CYGNUS.
ARM: Add support for IGEP COM AQUILA/CYGNUS
MAINTAINERS | 1 + arch/arm/include/asm/arch-am33xx/ddr_defs.h | 17 ++ board/isee/igep0033/Makefile | 46 ++++ board/isee/igep0033/board.c | 232 +++++++++++++++++++++ board/isee/igep0033/board.h | 27 +++ board/isee/igep0033/mux.c | 89 ++++++++ boards.cfg | 1 + include/configs/igep0033.h | 300 +++++++++++++++++++++++++++ 8 files changed, 713 insertions(+) create mode 100644 board/isee/igep0033/Makefile create mode 100644 board/isee/igep0033/board.c create mode 100644 board/isee/igep0033/board.h create mode 100644 board/isee/igep0033/mux.c create mode 100644 include/configs/igep0033.h
Signature · 1 line
1.7.10.4
PATCH 1/2 Add DDR3 support for IGEP COM AQUILA/CYGNUS.
From: Enric Balletbo i Serra <[email protected]>
These boards uses Samsung K4B2G1646E-BIH9 a 2Gb E-die DDR3 SDRAM.
--- arch/arm/include/asm/arch-am33xx/ddr_defs.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
arch/arm/include/asm/arch-am33xx/ddr_defs.h +17 -0
@@ -117,6 +117,23 @@#define MT41J512M8RH125_PHY_WR_DATA 0x74#define MT41J512M8RH125_IOCTRL_VALUE 0x18B +/* Samsung K4B2G1646E-BIH9 */ +#define K4B2G1646EBIH9_EMIF_READ_LATENCY 0x06 +#define K4B2G1646EBIH9_EMIF_TIM1 0x0888A39B +#define K4B2G1646EBIH9_EMIF_TIM2 0x2A04011A +#define K4B2G1646EBIH9_EMIF_TIM3 0x501F820F +#define K4B2G1646EBIH9_EMIF_SDCFG 0x61C24AB2 +#define K4B2G1646EBIH9_EMIF_SDREF 0x0000093B +#define K4B2G1646EBIH9_ZQ_CFG 0x50074BE4 +#define K4B2G1646EBIH9_DLL_LOCK_DIFF 0x1 +#define K4B2G1646EBIH9_RATIO 0x40 +#define K4B2G1646EBIH9_INVERT_CLKOUT 0x1 +#define K4B2G1646EBIH9_RD_DQS 0x3B +#define K4B2G1646EBIH9_WR_DQS 0x85 +#define K4B2G1646EBIH9_PHY_FIFO_WE 0x100 +#define K4B2G1646EBIH9_PHY_WR_DATA 0xC1 +#define K4B2G1646EBIH9_IOCTRL_VALUE 0x18B +/** * Configure DMM */
Signature · 1 line
1.7.10.4
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
In reply to Enric Balletbo i SerraFrom: Enric Balletbo i Serra <[email protected]>
The IGEP COM AQUILA and CYGNUS are industrial processors modules with following highlights:
o AM3352/AM3354 Texas Instruments processor
o Cortex-A8 ARM CPU
o 3.3 volts Inputs / Outputs use industrial
o 256 MB DDR3 SDRAM / 128 Megabytes FLASH
o MicroSD card reader on-board
o Ethernet controller on-board
o JTAG debug connector available
o Designed for industrial range purposes
--- MAINTAINERS | 1 + board/isee/igep0033/Makefile | 46 +++++++ board/isee/igep0033/board.c | 232 ++++++++++++++++++++++++++++++++ board/isee/igep0033/board.h | 27 ++++ board/isee/igep0033/mux.c | 89 +++++++++++++ boards.cfg | 1 + include/configs/igep0033.h | 300 ++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 696 insertions(+) create mode 100644 board/isee/igep0033/Makefile create mode 100644 board/isee/igep0033/board.c create mode 100644 board/isee/igep0033/board.h create mode 100644 board/isee/igep0033/mux.c create mode 100644 include/configs/igep0033.h
MAINTAINERS +1 -0
@@ -607,6 +607,7 @@ Enric Balletbo i Serra <[email protected]> igep0020 ARM ARMV7 (OMAP3xx SoC) igep0030 ARM ARMV7 (OMAP3xx SoC) igep0032 ARM ARMV7 (OMAP3xx SoC) + igep0033 ARM ARMV7 (AM33xx Soc) Eric Benard <[email protected]>
board/isee/igep0033/Makefile new file +46 -0
46 lines not on this page · raw message
board/isee/igep0033/board.c new file +232 -0
232 lines not on this page · raw message
board/isee/igep0033/board.h new file +27 -0
@@ -0,0 +1,27 @@ +/* +* IGEP COM AQUILA/CYGNUS boards information header +* +* Copyright (C) 2013, ISEE 2007 SL - http://www.isee.biz/ +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR /PURPOSE. See the +* GNU General Public License for more details. +*/ + +#ifndef _BOARD_H_ +#define _BOARD_H_ + +/* +* We must be able to enable uart0, for initial output. We then have a +* main pinmux function that can be overridden to enable all other pinmux that +* is required on the board. +*/ +void enable_uart0_pin_mux (void ); +void enable_board_pin_mux (void ); +#endif
board/isee/igep0033/mux.c new file +89 -0
89 lines not on this page · raw message
boards.cfg +1 -0
@@ -273,6 +273,7 @@ igep0020_nand arm armv7 igep00x0 isee igep0030 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND igep0030_nand arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND igep0032 arm armv7 igep00x0 isee omap3 igep00x0:MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND +igep0033 arm armv7 igep0033 isee am33xx am3517_evm arm armv7 am3517evm logicpd omap3 mt_ventoux arm armv7 mt_ventoux teejet omap3 omap3_zoom1 arm armv7 zoom1 logicpd omap3
include/configs/igep0033.h new file +300 -0
300 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
Quoted 14 lines · Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM AQUILA and CYGNUS are industrial processors modules with following highlights:
o AM3352/AM3354 Texas Instruments processor
o Cortex-A8 ARM CPU
o 3.3 volts Inputs / Outputs use industrial
o 256 MB DDR3 SDRAM / 128 Megabytes FLASH
o MicroSD card reader on-board
o Ethernet controller on-board
o JTAG debug connector available
o Designed for industrial range purposes
Quoted 1 line
Signed-off-by Enric Balletbo i Serra <[email protected]>
In general, yay. But some specific comments that I know you inherited:
[snip]
include/configs/igep0033.h line 47
Quoted 8 lines
include/configs/igep0033.h new file +8
-0+/* Display cpuinfo */ +#define CONFIG_DISPLAY_CPUINFO +/* Add libfdt-based support */ +#define CONFIG_OF_LIBFDT +/* Enable passing of ATAGs */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS +#define CONFIG_INITRD_TAG
Do you really have to support ATAGS and FDT? Just confirming.
include/configs/igep0033.h line 59
Quoted 11 lines
include/configs/igep0033.h new file +11
-0+/* Commands to include */ +#include <config_cmd_default.h> + +#define CONFIG_CMD_ASKENV +#define CONFIG_CMD_BOOTZ +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_ECHO +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT4 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_FS_GENERIC
With CONFIG_CMD_FS_GENERIC and CMD_EXT4 do you really need CMD_EXT2 set?
[snip]
include/configs/igep0033.h line 77
Quoted 9 lines
include/configs/igep0033.h new file +9
-0+#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG +#define CONFIG_EXTRA_ENV_SETTINGS \ + "loadaddr=0x80200000\0" \ + "fdtaddr=0x80F80000\0" \ + "fdt_high=0xffffffff\0" \ + "rdaddr=0x81000000\0" \ + "bootfile=/boot/uImage\0" \ + "fdtfile=\0" \
You're setting the config options to get an easy run-time way to set fdtfile but not providing a script command to set it nor a C function. If you don't need run-time detection, just set fdtfile :)
include/configs/igep0033.h line 144
Quoted 7 lines
include/configs/igep0033.h new file +7
-0+/* +* memtest works on 8 MB in DRAM after skipping 32MB from +* start addr of ram disk +*/ +#define CONFIG_SYS_MEMTEST_START (PHYS_DRAM_1 + (64 * 1024 * 1024)) +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START \ + + (8 * 1024 * 1024))
The comment is wrong, and you can do any of:
- Opt-out of mtest (and see Wolfgang's readme on why that's probably a good idea)
- Correct this to be all of RAM, minus a bit for a reasonably-sized U-Boot to be running in.
[snip]
include/configs/igep0033.h line 219
Quoted 4 lines
include/configs/igep0033.h new file +4
-0+#define MTDIDS_DEFAULT "nand0=nand" +#define MTDPARTS_DEFAULT "mtdparts=nand:512k(SPL),"\ + "1920k(U-Boot),128k(U-Boot Env),"\ + "5m(Kernel),-(File System)"
Setting aside such a large space for U-Boot is something else you inherited, do you want to re-evaluate this or too late?
include/configs/igep0033.h line 248
Quoted 3 lines
include/configs/igep0033.h new file +3
-0+#define CONFIG_SPL_NET_SUPPORT +#define CONFIG_SPL_NET_VCI_STRING "AM335x U-Boot SPL" +#define CONFIG_SPL_ETH_SUPPORT
Keeping in mind the errata involved, does your board support CPSW SPL without needed the erratad-out mode?
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130403/e4bccc70/attachment.pgp>
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
Hi Tom,
Thanks for your comments.
2013/4/4 Tom Rini <[email protected]>
Quoted 21 lines · Enric Balletbo i Serra
Quoted 15 lines
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM AQUILA and CYGNUS are industrial processors modules with following highlights:
o AM3352/AM3354 Texas Instruments processor
o Cortex-A8 ARM CPU
o 3.3 volts Inputs / Outputs use industrial
o 256 MB DDR3 SDRAM / 128 Megabytes FLASH
o MicroSD card reader on-board
o Ethernet controller on-board
o JTAG debug connector available
o Designed for industrial range purposesQuoted 1 line
Signed-off-by Enric Balletbo i Serra <[email protected]>In general, yay. But some specific comments that I know you inherited:
[snip]
Quoted 11 lines
include/configs/igep0033.h line 47
Quoted 8 lines
include/configs/igep0033.h new file +8
-0+/* Display cpuinfo */ +#define CONFIG_DISPLAY_CPUINFO +/* Add libfdt-based support */ +#define CONFIG_OF_LIBFDT +/* Enable passing of ATAGs */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS +#define CONFIG_INITRD_TAG Do you really have to support ATAGS and FDT? Just confirming.
No, I'll remove.
Quoted 15 lines
include/configs/igep0033.h line 59
Quoted 12 lines
include/configs/igep0033.h new file +11
-0+/* Commands to include */ +#include <config_cmd_default.h> + +#define CONFIG_CMD_ASKENV +#define CONFIG_CMD_BOOTZ +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_ECHO +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT4 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_FS_GENERIC With
CONFIG_CMD_FS_GENERICandCMD_EXT4do you really needCMD_EXT2set?
You have reason, has no sense, I'll remove too.
Quoted 17 lines
[snip]
include/configs/igep0033.h line 77
Quoted 9 lines
include/configs/igep0033.h new file +9
-0+#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG +#define CONFIG_EXTRA_ENV_SETTINGS \ + "loadaddr=0x80200000\0" \ + "fdtaddr=0x80F80000\0" \ + "fdt_high=0xffffffff\0" \ + "rdaddr=0x81000000\0" \ + "bootfile=/boot/uImage\0" \ + "fdtfile=\0" \You're setting the config options to get an easy run-time way to set fdtfile but not providing a script command to set it nor a C function. If you don't need run-time detection, just set fdtfile :)
I'll remove ftd related variables until fdt support is not tested.
Quoted 12 lines
include/configs/igep0033.h line 144
Quoted 7 lines
include/configs/igep0033.h new file +7
-0+/* +* memtest works on 8 MB in DRAM after skipping 32MB from +* start addr of ram disk +*/ +#define CONFIG_SYS_MEMTEST_START (PHYS_DRAM_1 + (64 * 1024 * 1024)) +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START \ + + (8 * 1024 * 1024))The comment is wrong, and you can do any of:
- Opt-out of mtest (and see Wolfgang's readme on why that's probably a good idea)
Readed and convinced. Thanks for this point.
Quoted 13 lines
- Correct this to be all of RAM, minus a bit for a reasonably-sized U-Boot to be running in.
[snip]
include/configs/igep0033.h line 219
Quoted 4 lines
include/configs/igep0033.h new file +4
-0+#define MTDIDS_DEFAULT "nand0=nand" +#define MTDPARTS_DEFAULT "mtdparts=nand:512k(SPL),"\ + "1920k(U-Boot),128k(U-Boot Env),"\ + "5m(Kernel),-(File System)"Setting aside such a large space for U-Boot is something else you inherited, do you want to re-evaluate this or too late?
Is not too late, I'll reduce the U-Boot space, do you think 512k is sufficient ?
Quoted 7 lines
include/configs/igep0033.h line 248
Quoted 3 lines
include/configs/igep0033.h new file +3
-0+#define CONFIG_SPL_NET_SUPPORT +#define CONFIG_SPL_NET_VCI_STRING "AM335x U-Boot SPL" +#define CONFIG_SPL_ETH_SUPPORT Keeping in mind the errata involved, does your board support CPSW SPL without needed the erratad-out mode?
We'll change the default bootmode in production boards so has no sense define this. I'll remove.
I'll send version 2, thanks again.
Cheers,
Enric
Quoted 4 lines
--
Tom
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
Tom,
One more question...
2013/4/4 Enric Balletbo Serra <[email protected]>
Quoted 91 lines
Hi Tom,
Thanks for your comments.
2013/4/4 Tom Rini <[email protected]>
Quoted 21 lines · Enric Balletbo i Serra
Quoted 15 lines
From: Enric Balletbo i Serra <[email protected]>
The IGEP COM AQUILA and CYGNUS are industrial processors modules with following highlights:
o AM3352/AM3354 Texas Instruments processor
o Cortex-A8 ARM CPU
o 3.3 volts Inputs / Outputs use industrial
o 256 MB DDR3 SDRAM / 128 Megabytes FLASH
o MicroSD card reader on-board
o Ethernet controller on-board
o JTAG debug connector available
o Designed for industrial range purposesQuoted 1 line
Signed-off-by Enric Balletbo i Serra <[email protected]>In general, yay. But some specific comments that I know you inherited:
[snip]
Quoted 11 lines
include/configs/igep0033.h line 47
Quoted 8 lines
include/configs/igep0033.h new file +8
-0+/* Display cpuinfo */ +#define CONFIG_DISPLAY_CPUINFO +/* Add libfdt-based support */ +#define CONFIG_OF_LIBFDT +/* Enable passing of ATAGs */ +#define CONFIG_CMDLINE_TAG +#define CONFIG_SETUP_MEMORY_TAGS +#define CONFIG_INITRD_TAG Do you really have to support ATAGS and FDT? Just confirming.
No, I'll remove.
Quoted 15 lines
include/configs/igep0033.h line 59
Quoted 12 lines
include/configs/igep0033.h new file +11
-0+/* Commands to include */ +#include <config_cmd_default.h> + +#define CONFIG_CMD_ASKENV +#define CONFIG_CMD_BOOTZ +#define CONFIG_CMD_DHCP +#define CONFIG_CMD_ECHO +#define CONFIG_CMD_EXT2 +#define CONFIG_CMD_EXT4 +#define CONFIG_CMD_FAT +#define CONFIG_CMD_FS_GENERIC With
CONFIG_CMD_FS_GENERICandCMD_EXT4do you really needCMD_EXT2set?You have reason, has no sense, I'll remove too.
Quoted 17 lines
[snip]
include/configs/igep0033.h line 77
Quoted 9 lines
include/configs/igep0033.h new file +9
-0+#define CONFIG_ENV_VARS_UBOOT_CONFIG +#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG +#define CONFIG_EXTRA_ENV_SETTINGS \ + "loadaddr=0x80200000\0" \ + "fdtaddr=0x80F80000\0" \ + "fdt_high=0xffffffff\0" \ + "rdaddr=0x81000000\0" \ + "bootfile=/boot/uImage\0" \ + "fdtfile=\0" \You're setting the config options to get an easy run-time way to set fdtfile but not providing a script command to set it nor a C function. If you don't need run-time detection, just set fdtfile :)
I'll remove ftd related variables until fdt support is not tested.
Quoted 7 lines
include/configs/igep0033.h
Quoted 6 lines
include/configs/igep0033.h new file +6
-0+/* +* memtest works on 8 MB in DRAM after skipping 32MB from +* start addr of ram disk +*/ +#define CONFIG_SYS_MEMTEST_START (PHYS_DRAM_1 + (64 * 1024 * 1024)) +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START\
Quoted 9 lines
Quoted 6 lines
Quoted 1 line
+ + (8 * 1024 * 1024))
The comment is wrong, and you can do any of:
- Opt-out of mtest (and see Wolfgang's readme on why that's probably a good idea)Readed and convinced. Thanks for this point.
As explained in Wolfgang's readme shouldn't remove CONFIG_CMD_MEMTEST from config_cmd_default.h ?
Quoted 44 lines
Quoted 5 lines
- Correct this to be all of RAM, minus a bit for a reasonably-sized U-Boot to be running in.
Quoted 10 lines
[snip]
include/configs/igep0033.h line 219
Quoted 4 lines
include/configs/igep0033.h new file +4
-0+#define MTDIDS_DEFAULT "nand0=nand" +#define MTDPARTS_DEFAULT "mtdparts=nand:512k(SPL),"\ + "1920k(U-Boot),128k(U-Boot Env),"\ + "5m(Kernel),-(File System)"Setting aside such a large space for U-Boot is something else you inherited, do you want to re-evaluate this or too late?
Is not too late, I'll reduce the U-Boot space, do you think 512k is sufficient ?
Quoted 7 lines
include/configs/igep0033.h line 248
Quoted 3 lines
include/configs/igep0033.h new file +3
-0+#define CONFIG_SPL_NET_SUPPORT +#define CONFIG_SPL_NET_VCI_STRING "AM335x U-Boot SPL" +#define CONFIG_SPL_ETH_SUPPORT Keeping in mind the errata involved, does your board support CPSW SPL without needed the erratad-out mode?
We'll change the default bootmode in production boards so has no sense define this. I'll remove.
I'll send version 2, thanks again.
Cheers,
EnricQuoted 4 lines
--
Tom
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
On Thu, Apr 04, 2013 at 09:51:05AM +0200, Enric Balletbo Serra wrote:
[snip]
Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
include/configs/igep0033.h
Quoted 6 lines
include/configs/igep0033.h new file +6
-0+/* +* memtest works on 8 MB in DRAM after skipping 32MB from +* start addr of ram disk +*/ +#define CONFIG_SYS_MEMTEST_START (PHYS_DRAM_1 + (64 * 1024 * 1024)) +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START\
Quoted 1 line
+ + (8 * 1024 * 1024))
The comment is wrong, and you can do any of:
- Opt-out of mtest (and see Wolfgang's readme on why that's probably a good idea)
Quoted 5 lines
Quoted 2 lines
Readed and convinced. Thanks for this point.
As explained in Wolfgang's readme shouldn't remove
CONFIG_CMD_MEMTESTfromconfig_cmd_default.h?
When the time comes, as stated in doc/feature-removal-schedule.txt :) For now, #undef it.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/810dd067/attachment.pgp>
PATCH 2/2 ARM: Add support for IGEP COM AQUILA/CYGNUS
In reply to Enric Balletbo SerraQuoted 3 lines · Enric Balletbo Serra
2013/4/4 Tom Rini <[email protected]>
Quoted 1 line · Enric Balletbo i Serra
[snip]
Quoted 13 lines
Quoted 13 lines
- Correct this to be all of RAM, minus a bit for a reasonably-sized U-Boot to be running in.
[snip]
include/configs/igep0033.h line 219
Quoted 4 lines
include/configs/igep0033.h new file +4
-0+#define MTDIDS_DEFAULT "nand0=nand" +#define MTDPARTS_DEFAULT "mtdparts=nand:512k(SPL),"\ + "1920k(U-Boot),128k(U-Boot Env),"\ + "5m(Kernel),-(File System)"Setting aside such a large space for U-Boot is something else you inherited, do you want to re-evaluate this or too late?
Quoted 2 lines
Is not too late, I'll reduce the U-Boot space, do you think 512k is sufficient ?
Well, what redudancy are you doing? A single image within 512KiB is fine, sure. Two images wouldn't be, most likely :)
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/5a5430e9/attachment.pgp>