Skip to contentSkip to conversation

mxs: Explain why some mx23 DDR registers are not configured

PATCH New Fabio Estevam 2 participants 2 messages May 6, 2013

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 mxs: Explain why some mx23 DDR registers are not configured

From: Fabio Estevam <[email protected]>

Put an explanation in the source code as to why some DDR registers do not need to be configured.

---
 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +9 -0
index 41fb803..060fdb7 100644
@@ -127,6 +127,15 @@ static void initialize_dram_values(void)
 
 	mxs_adjust_memory_params(dram_vals);
 
+	/*
+	 * HW_DRAM_CTL27, HW_DRAM_CTL28 and HW_DRAM_CTL35 are not initialized as
+	 * per FSL bootlets code.
+	 *
+	 * mx23 Reference Manual marks HW_DRAM_CTL27 and HW_DRAM_CTL28 as
+	 * "reserved".
+	 * HW_DRAM_CTL8 is setup as the last element.
+	 * So skip the initialization of these HW_DRAM_CTL registers.
+	 */
 	for (i = 0; i < ARRAY_SIZE(dram_vals); i++) {
 		if (i == 8 || i == 27 || i == 28 || i == 35)
 			continue;
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mxs: Explain why some mx23 DDR registers are not configured

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Put an explanation in the source code as to why some DDR registers do not need to be configured.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================