Skip to contentSkip to conversation

ARM: bcm: Add DEBUG_LL console support

PATCH In review Christian Daudt 4 participants 6 messages Oct 5, 2013 – Dec 13, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ARM: bcm: Add DEBUG_LL console support

This patch adds low level debug uart support to Broadcom
mobile based SOCs.

Changes from V2:
- Changed to follow hex ordering on entries
- Dropped defconfig changes

Changes from V1:
- Switched to use the common 8250 debug introduced in 3.12-rc1

arch/arm/Kconfig.debug +15 -1
index 9762c84..0391691 100644
@@ -94,6 +94,17 @@ choice
 		depends on ARCH_BCM2835
 		select DEBUG_UART_PL01X
 
+	config DEBUG_BCM_KONA_UART
+		bool "Kernel low-level debugging messages via BCM KONA UART"
+		depends on ARCH_BCM
+		select DEBUG_UART_8250
+		help
+		  Say Y here if you want kernel low-level debugging support
+		  on Broadcom SoC platforms.
+		  This low level debug works for Broadcom
+		  mobile SoCs in the Kona family of chips (e.g. bcm28155,
+		  bcm11351, etc...)
+
 	config DEBUG_CLPS711X_UART1
 		bool "Kernel low-level debugging messages via UART1"
 		depends on ARCH_CLPS711X
@@ -951,6 +962,7 @@ config DEBUG_UART_PHYS
 	default 0x20064000 if DEBUG_RK29_UART1 || DEBUG_RK3X_UART2
 	default 0x20068000 if DEBUG_RK29_UART2 || DEBUG_RK3X_UART3
 	default 0x20201000 if DEBUG_BCM2835
+	default 0x3e000000 if DEBUG_BCM_KONA_UART
 	default 0x40090000 if ARCH_LPC32XX
 	default 0x40100000 if DEBUG_PXA_UART1
 	default 0x42000000 if ARCH_GEMINI
@@ -1010,6 +1022,7 @@ config DEBUG_UART_VIRT
 	default 0xfe018000 if DEBUG_MMP_UART3
 	default 0xfe100000 if DEBUG_IMX23_UART || DEBUG_IMX28_UART
 	default 0xfe230000 if DEBUG_PICOXCELL_UART
+	default 0xfe300000 if DEBUG_BCM_KONA_UART
 	default 0xfe800000 if ARCH_IOP32X
 	default 0xfeb00000 if DEBUG_HI3620_UART || DEBUG_HI3716_UART
 	default 0xfeb24000 if DEBUG_RK3X_UART0
@@ -1052,7 +1065,8 @@ config DEBUG_UART_8250_WORD
 	default y if DEBUG_PICOXCELL_UART || DEBUG_SOCFPGA_UART || \
 		ARCH_KEYSTONE || \
 		DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
-		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1
+		DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_DAVINCI_TNETV107X_UART1 || \
+		DEBUG_BCM_KONA_UART
 
 config DEBUG_UART_8250_FLOW_CONTROL
 	bool "Enable flow control for 8250 UART"
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 12 lines · Christian Daudt

This patch adds low level debug uart support to Broadcom
mobile based SOCs.

Changes from V2:
- Changed to follow hex ordering on entries
- Dropped defconfig changes

Changes from V1:
- Switched to use the common 8250 debug introduced in 3.12-rc1

Hi Russell,
Does V3 look ok ?

Thanks,
csd

#2 lore raw
Quoted 14 lines · Christian Daudt
Quoted 12 lines · Christian Daudt

This patch adds low level debug uart support to Broadcom
mobile based SOCs.

Changes from V2:
- Changed to follow hex ordering on entries
- Dropped defconfig changes

Changes from V1:
- Switched to use the common 8250 debug introduced in 3.12-rc1

Quoted 5 lines

Hi Russell,
Does V3 look ok ?

Thanks,
csd

Hi,
Can anyone provide an ack on this mod ?

Thanks,
csd

Tested-by
#3 lore raw
Quoted 18 lines · Christian Daudt
Quoted 17 lines · Christian Daudt
Quoted 12 lines · Christian Daudt

This patch adds low level debug uart support to Broadcom
mobile based SOCs.

Changes from V2:
- Changed to follow hex ordering on entries
- Dropped defconfig changes

Changes from V1:
- Switched to use the common 8250 debug introduced in 3.12-rc1

Hi Russell,
Does V3 look ok ?

Quoted 7 lines
Quoted 2 lines

Thanks,
csd

Hi,
Can anyone provide an ack on this mod ?

Thanks,
csd

[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Initializing cgroup subsys cpu
[    0.000000] Initializing cgroup subsys cpuacct
[    0.000000] Linux version 3.12.0+ (mmayer at lbrmn-lnxub70.ric.broadcom.com)
[    0.000000] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=10c53c7d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing
instruction cache
[    0.000000] Machine: BCM281xx Broadcom Application Processor,
model: BCM28155 AP board
[    0.000000] bootconsole [earlycon0] enabled
[    0.000000] Truncating RAM at 90000000-bfffffff to -bf7fffff
(vmalloc region overlap).
[    0.000000] Memory policy: ECC disabled, Data cache writeback
[    0.000000] CPU: All CPU(s) started in SVC mode.
[    0.000000] Built 1 zonelists in Zone order, mobility grouping on.
Total pages: 193040
[    0.000000] Kernel command line: console=ttyS0,115200n8
root=/dev/mmcblk0p8 rootwait rootfstype=ext4 earlyprintk
[...]
[    0.200000] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[    0.210000] 3e000000.uart: ttyS0 at MMIO 0x3e000000 (irq = 99,
base_baud = 812500) is a 16550A
[    0.220000] console [ttyS0] enabled, bootconsole disabled
[    0.220000] console [ttyS0] enabled, bootconsole disabled
[    0.230000] mousedev: PS/2 mouse device common for all mice

[...]

Signature · 2 lines
Markus Mayer
Broadcom Landing Team
Tested-by on v3 1/1
#5 lore raw
In reply to Christian Daudt
Quoted 12 lines · Christian Daudt

This patch adds low level debug uart support to Broadcom
mobile based SOCs.

Changes from V2:
- Changed to follow hex ordering on entries
- Dropped defconfig changes

Changes from V1:
- Switched to use the common 8250 debug introduced in 3.12-rc1

Also working for me on my Capri board.

-Matt