Skip to contentSkip to conversation

drm/i915: print connector mode list in display_info

PATCH Applied Jesse Barnes 3 participants 5 messages Feb 20, 2014 – Mar 5, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: print connector mode list in display_info

Useful for bug reports.

---
 drivers/gpu/drm/i915/i915_debugfs.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +4 -0
index b737583..1cb56f7 100644
@@ -2177,6 +2177,7 @@ static void intel_connector_info(struct seq_file *m,
 {
 	struct intel_connector *intel_connector = to_intel_connector(connector);
 	struct intel_encoder *intel_encoder = intel_connector->encoder;
+	struct drm_display_mode *mode;
 
 	seq_printf(m, "connector %d: type %s, status: %s\n",
 		   connector->base.id, drm_get_connector_name(connector),
@@ -2199,6 +2200,9 @@ static void intel_connector_info(struct seq_file *m,
 	else if (intel_encoder->type == INTEL_OUTPUT_LVDS)
 		intel_lvds_info(m, intel_connector);
 
+	seq_printf(m, "\tmodes:\n");
+	list_for_each_entry(mode, &connector->modes, head)
+		intel_seq_print_mode(m, 2, mode);
 }
 
 static int i915_display_info(struct seq_file *m, void *unused)
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 1 line · Jesse Barnes

Useful for bug reports.

Hey, this would be useful for error state as well :) -Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 4 lines · Chris Wilson
Quoted 1 line · Jesse Barnes

Useful for bug reports.

Hey, this would be useful for error state as well :)

I seem to have pissed of Jesse yesterday, so not going to insist here ;-)

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#3 lore raw
Quoted 9 lines · On Wed, 5 Mar 2014 13:55:00 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 4 lines · Chris Wilson
Quoted 1 line · Jesse Barnes

Useful for bug reports.

Hey, this would be useful for error state as well :)

I seem to have pissed of Jesse yesterday, so not going to insist here ;-)

Queued for -next, thanks for the patch.

Move along, nothing to see here. :)

But yeah, adding this to error state might be useful just so things get bundled up I guess?

It's a bunch more refactoring to get the printouts into a buffer for use in either case though. Not sure it's worth it since we can just ask for both files.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#4 lore raw
Quoted 13 lines · Jesse Barnes
Quoted 9 lines · On Wed, 5 Mar 2014 13:55:00 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 4 lines · Chris Wilson
Quoted 1 line · Jesse Barnes

Useful for bug reports.

Hey, this would be useful for error state as well :)

I seem to have pissed of Jesse yesterday, so not going to insist here ;-)

Queued for -next, thanks for the patch.

Quoted 8 lines

Move along, nothing to see here. :)

But yeah, adding this to error state might be useful just so things get bundled up I guess?

It's a bunch more refactoring to get the printouts into a buffer for use in either case though. Not sure it's worth it since we can just ask for both files.

On 2nd though we should have the stuff which can change and yeah just asking for all the debugfs files should be ok. So sounds like the current code is Good Enough.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch