Skip to contentSkip to conversation

arm: am335x: DXR2: Move unconditional LAN9303 reset into command

PATCH In review Stefan Roese 2 participants 2 messages Mar 12, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: am335x: DXR2: Move unconditional LAN9303 reset into command

The switch HW reset results in a disconnection of the switch port daisy- chain for a few seconds. This is not desired in the normal field use case. So lets remove this switch reset from the normal bootup sequence and move it into a board specific command. This way it can be executed in the development environment when really needed.

Cc Roger Meier <[email protected]>
Cc Lukas Stockmann <[email protected]>
Cc Tom Rini <[email protected]>
---
 board/siemens/dxr2/board.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)
board/siemens/dxr2/board.c +19 -7
index 2172379..38ac93d 100644
@@ -232,13 +232,6 @@ int board_eth_init(bd_t *bis)
 
 	factoryset_setenv();
 
-	/* Reset SMSC LAN9303 switch for default configuration */
-	gpio_request(GPIO_LAN9303_NRST, "nRST");
-	gpio_direction_output(GPIO_LAN9303_NRST, 0);
-	/* assert active low reset for 200us */
-	udelay(200);
-	gpio_set_value(GPIO_LAN9303_NRST, 1);
-
 	/* Set rgmii mode and enable rmii clock to be sourced from chip */
 	writel((RMII_MODE_ENABLE | RMII_CHIPCKL_ENABLE), &cdev->miisel);
 
@@ -249,6 +242,25 @@ int board_eth_init(bd_t *bis)
 		n += rv;
 	return n;
 }
+
+static int do_switch_reset(cmd_tbl_t *cmdtp, int flag, int argc,
+			   char *const argv[])
+{
+	/* Reset SMSC LAN9303 switch for default configuration */
+	gpio_request(GPIO_LAN9303_NRST, "nRST");
+	gpio_direction_output(GPIO_LAN9303_NRST, 0);
+	/* assert active low reset for 200us */
+	udelay(200);
+	gpio_set_value(GPIO_LAN9303_NRST, 1);
+
+	return 0;
+};
+
+U_BOOT_CMD(
+	switch_rst, CONFIG_SYS_MAXARGS, 1,	do_switch_reset,
+	"Reset LAN9303 switch via its reset pin",
+	""
+);
 #endif /* #if defined(CONFIG_DRIVER_TI_CPSW) */
 #endif /* #if (defined(CONFIG_DRIVER_TI_CPSW) && !defined(CONFIG_SPL_BUILD)) */
 
Signature · 1 line
1.8.5.5
#1 lore raw
Quoted 10 lines · Stefan Roese

The switch HW reset results in a disconnection of the switch port daisy- chain for a few seconds. This is not desired in the normal field use case. So lets remove this switch reset from the normal bootup sequence and move it into a board specific command. This way it can be executed in the development environment when really needed.

Cc Roger Meier <[email protected]>
Cc Lukas Stockmann <[email protected]>
Cc Tom Rini <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140312/3ab6e566/attachment.pgp>