Skip to contentSkip to conversation

board:tricorder: late fixups for 2014.04

PATCH New Andreas Bießmann 2 participants 5 messages Apr 10, 2014 – Apr 11, 2014

lore
Share & tools
lore
#0 lore raw

cover board:tricorder: late fixups for 2014.04

These fixups are required for tricorder board to run with 2014.04.

One big change is a different ecc layout which came in by Pekon Gupta's changes to the omap_gpmc driver. Another point was changed behaviour of omap_gpio driver, we need to switch the clocks now explicitely.

Thomas, could you please chack the patches and send your ACK ASAP?

Best regards

Andreas Bie?mann

Andreas Bie?mann (3):
board:tricorder: always work with valid eeprom data board:tricorder: enable omap_gpio clocks board:tricorder: fixup SPL OOB layout

 board/corscience/tricorder/tricorder.c |    2 ++
 include/configs/tricorder.h            |   14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/3 board:tricorder: always work with valid eeprom data

From: Andreas Bie?mann <[email protected]>

Commit 890880583d84607e36b52a785a96b167728bbf73 introduced EEPROM parsing and board detection but faild to return a valid tricorder_eeprom struct for backup case. When pressing S200 while reading EEPROM we ignore the value. We returned falsely a tricorder_eeprom struct with uninitialized data which is just garbage.
Initialize it by zeroing the whole structure.

---

 board/corscience/tricorder/tricorder.c |    2 ++
 1 file changed, 2 insertions(+)
board/corscience/tricorder/tricorder.c +2 -0
index 2dfcb27..9e81bf3 100644
@@ -79,6 +79,8 @@ static void get_eeprom(struct tricorder_eeprom *eeprom)
 		} else {
 			panic("Could not get board revision\n");
 		}
+	} else {
+		memset(eeprom, 0, TRICORDER_EEPROM_SIZE);
 	}
 }
 
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/3 board:tricorder: enable omap_gpio clocks

In reply to Andreas Bießmann

From: Andreas Bie?mann <[email protected]>

---

 include/configs/tricorder.h |    3 +++
 1 file changed, 3 insertions(+)
include/configs/tricorder.h +3 -0
index 62f97d2..a609861 100644
@@ -63,6 +63,9 @@
 /* GPIO support */
 #define CONFIG_OMAP_GPIO
 
+/* GPIO banks */
+#define CONFIG_OMAP3_GPIO_2		/* GPIO32..63 are in GPIO bank 2 */
+
 /* LED support */
 #define CONFIG_STATUS_LED
 #define CONFIG_BOARD_SPECIFIC_LED
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH 3/3 board:tricorder: fixup SPL OOB layout

In reply to Andreas Bießmann

From: Andreas Bie?mann <[email protected]>

Commit d016dc42cedbf6102e100fa9ecb58462edfb14f8 changed the layout of BCH8 SW on omap3 boards. We need to adopt the ecc layout for the nand_spl_simle driver to avoid wrong ecc errors.

---

 include/configs/tricorder.h |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
include/configs/tricorder.h +6 -5
index a609861..80985a2 100644
@@ -368,11 +368,12 @@
 #define CONFIG_SYS_NAND_OOBSIZE		64
 #define CONFIG_SYS_NAND_BLOCK_SIZE	(128*1024)
 #define CONFIG_SYS_NAND_BAD_BLOCK_POS	NAND_LARGE_BADBLOCK_POS
-#define CONFIG_SYS_NAND_ECCPOS		{12, 13, 14, 15, 16, 17, 18, 19, 20,\
-			21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33,\
-			34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46,\
-			47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59,\
-			60, 61, 62, 63}
+#define CONFIG_SYS_NAND_ECCPOS		{2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, \
+					 13, 14, 16, 17, 18, 19, 20, 21, 22, \
+					 23, 24, 25, 26, 27, 28, 30, 31, 32, \
+					 33, 34, 35, 36, 37, 38, 39, 40, 41, \
+					 42, 44, 45, 46, 47, 48, 49, 50, 51, \
+					 52, 53, 54, 55, 56}
 
 #define CONFIG_SYS_NAND_ECCSIZE		512
 #define CONFIG_SYS_NAND_ECCBYTES	13
Signature · 1 line
1.7.10.4
#4 lore raw

cover board:tricorder: late fixups for 2014.04

In reply to Andreas Bießmann
Quoted 7 lines · Andreas Bie?mann

These fixups are required for tricorder board to run with 2014.04.

One big change is a different ecc layout which came in by Pekon Gupta's changes to the omap_gpmc driver. Another point was changed behaviour of omap_gpio driver, we need to switch the clocks now explicitely.

Thomas, could you please chack the patches and send your ACK ASAP?

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140411/3b518bea/attachment.pgp>