Skip to contentSkip to conversation

finderInfo of the Spotlight directory files.

PATCH Hin-Tak Leung 2 participants 2 messages Apr 14, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Vyacheslav,

I have a few files which don't seem to have valid finderinfo data:

/mnt/.Spotlight-V100/.journalHistoryLog
/mnt/.Spotlight-V100/.store.db
/mnt/.Spotlight-V100/_rules.plist
/mnt/.Spotlight-V100/ContentIndex.db
/mnt/.Spotlight-V100/store.db

But since they are spotlight files, and the spotlight directory is special (it is filtered from fsevent in xnu). Also they don't have meaningful finderinfo anyway, since they aren't created by user nor used by any applications.

The failure is near
"if (found_bit >= (len*8)) res = 0;" in attr.c -

I am thinking of just doing this, to accept entirely empty ones:

fs/hfsplus/xattr.c +0 -1
index 6c0aef0..941a4aa 100644
@@ -777,7 +777,6 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size)
        if (err) {
                if (err == -ENOENT) {
                        if (res == 0)
-                               res = -ENODATA;
                        goto end_listxattr;
                } else {
                        res = err;

I am not sure why you have the "if (found_bit >= (len*8))" check - although not having any meaningful finderinfo is strange, but a fair number of files/directories are special and/or invisible to finder, so it is legitimate not to have them?

Hin-Tak

#1 lore raw

Hi Hin-Tak,

Quoted 10 lines · Hin-Tak Leung

Hi Vyacheslav,

I have a few files which don't seem to have valid finderinfo data:

/mnt/.Spotlight-V100/.journalHistoryLog
/mnt/.Spotlight-V100/.store.db
/mnt/.Spotlight-V100/_rules.plist
/mnt/.Spotlight-V100/ContentIndex.db
/mnt/.Spotlight-V100/store.db

Quoted 7 lines

But since they are spotlight files, and the spotlight directory is special (it is filtered from fsevent in xnu). Also they don't have meaningful finderinfo anyway, since they aren't created by user nor used by any applications.

The failure is near
"if (found_bit >= (len*8)) res = 0;" in attr.c -

Sorry, I don't quite follow your description. What is the essence of the issue? What reproducing path of the issue?

Sorry, but I misunderstand completely the description of the issue. It's really hard to answer something without understanding of the issue's environment. Could you describe how you've achieved the issue?

Thanks,
Vyacheslav Dubeyko.

Quoted 25 lines

I am thinking of just doing this, to accept entirely empty ones:

fs/hfsplus/xattr.c +0 -1
index 6c0aef0..941a4aa 100644
@@ -777,7 +777,6 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size)
        if (err) {
                if (err == -ENOENT) {
                        if (res == 0)
-                               res = -ENODATA;
                        goto end_listxattr;
                } else {
                        res = err;

I am not sure why you have the "if (found_bit >= (len*8))" check - although not having any meaningful finderinfo is strange, but a fair number of files/directories are special and/or invisible to finder, so it is legitimate not to have them?

Hin-Tak
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html