Skip to contentSkip to conversation

drm/i915/vlv: don't wait for vblank after pipe enable

PATCH In review Jesse Barnes 2 participants 4 messages May 12, 2014 – May 13, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/vlv: don't wait for vblank after pipe enable

Like on ILK, the pipe won't be running until later on.

---
 drivers/gpu/drm/i915/intel_display.c |    1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +0 -1
index c65e7f7..c66d2ea 100644
@@ -4344,7 +4344,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
 
 	intel_update_watermarks(crtc);
 	intel_enable_pipe(intel_crtc);
-	intel_wait_for_vblank(dev_priv->dev, pipe);
 	intel_set_cpu_fifo_underrun_reporting(dev, pipe, true);
 
 	intel_enable_primary_hw_plane(dev_priv, plane, pipe);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 1 line · Jesse Barnes

Like on ILK, the pipe won't be running until later on.

Like on ilk?! Since when is vlv display derived from that? "[PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms" from Ville makes a more consistent impression to me. Also, and
Bugzilla: tags for this one?
-Daniel

Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_display.c |    1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +0 -2
index c65e7f7..c66d2ea 100644
@@ -4344,7 +4344,6 @@ static void valleyview_crtc_enable(struct drm_crtc *crtc)
 
        intel_update_watermarks(crtc);
        intel_enable_pipe(intel_crtc);
-       intel_wait_for_vblank(dev_priv->dev, pipe);
        intel_set_cpu_fifo_underrun_reporting(dev, pipe, true);
 
        intel_enable_primary_hw_plane(dev_priv, plane, pipe);
--

1.7.9.5

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 6 lines · On Tue, 13 May 2014 08:08:55 +0200 Daniel Vetter <[email protected]> wrote:
Quoted 1 line · Jesse Barnes

Like on ILK, the pipe won't be running until later on.

Like on ilk?! Since when is vlv display derived from that? "[PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms" from Ville makes a more consistent impression to me. Also, and

Yeah that's fine too. But of course BYT isn't just i915 legacy; it also includes some IBX logic on the port side. So you can't just lump it in with i9xx all the time unfortuantely. Either way it looks like Ville's patch will fix this too.

Quoted 1 line

Bugzilla: tags for this one?

Meh, this particular one only addresses an internal bug, and it looks like Ville didn't include a bz link either... did you add it when you committed?

https://bugs.freedesktop.org/show_bug.cgi?id=77297 looks like the closest.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#3 lore raw
Quoted 6 lines · Jesse Barnes
Quoted 3 lines · On Tue, 13 May 2014 08:08:55 +0200 Daniel Vetter <[email protected]> wrote:
Quoted 1 line · Jesse Barnes

Like on ILK, the pipe won't be running until later on.

Quoted 8 lines
Quoted 3 lines

Like on ilk?! Since when is vlv display derived from that? "[PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms" from Ville makes a more consistent impression to me. Also, and

Yeah that's fine too. But of course BYT isn't just i915 legacy; it also includes some IBX logic on the port side. So you can't just lump it in with i9xx all the time unfortuantely. Either way it looks like Ville's patch will fix this too.

Hm, I've thought the dp/hdmi ports are from g4x and the pll stuff from the cedarview ... it's a frankenstein for sure ;-)

Quoted 7 lines
Quoted 1 line

Bugzilla: tags for this one?

Meh, this particular one only addresses an internal bug, and it looks like Ville didn't include a bz link either... did you add it when you committed?

https://bugs.freedesktop.org/show_bug.cgi?id=77297 looks like the closest.

Yeah, looks like a match, I'll add it. Although the bug also refers to pch-split platforms ... I'll ask for retesting overall. -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch