Skip to contentSkip to conversation

drm/i915: tell the user if both KMS and UMS are disabled

PATCH Superseded Jani Nikula 2 participants 5 messages May 27, 2014 – Jun 2, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: tell the user if both KMS and UMS are disabled

If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might not be aware his setup is not supported. Inform the users (and, by extension, the poor i915 developers having to read their dmesgs in bug reports) why their graphics experience might be lacking.

A similar message was added on the UMS path in
commit e147accbd19f55489dabdcc4dc3551cc3e3f2553

Author: Jani Nikula <[email protected]>
Date:   Thu Oct 10 15:25:37 2013 +0300

drm/i915: tell the user KMS is required for gen6+

but it won't be reached if CONFIG_DRM_I915_UMS=n since commit b30324adaf8d2e5950a602bde63030d15a61826f

Author: Daniel Vetter <[email protected]>
Date:   Wed Nov 13 22:11:25 2013 +0100

drm/i915: Deprecated UMS support

---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +2 -0
index 8949fd26b0ea..f0f690776d45 100644
@@ -1584,6 +1584,8 @@ static int __init i915_init(void)
 	if (!(driver.driver_features & DRIVER_MODESET)) {
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
+		DRM_INFO("Kernel modesetting (KMS) and userspace modesetting (UMS) disabled\n");
+		DRM_INFO("See CONFIG_DRM_I915_UMS, CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n");
 		/* Silently fail loading to not upset userspace. */
 		return 0;
 #endif
Signature · 1 line
1.9.1
#1 lore raw
Quoted 13 lines · Jani Nikula

If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might not be aware his setup is not supported. Inform the users (and, by extension, the poor i915 developers having to read their dmesgs in bug reports) why their graphics experience might be lacking.

A similar message was added on the UMS path in
commit e147accbd19f55489dabdcc4dc3551cc3e3f2553

Author: Jani Nikula <[email protected]>
Date:   Thu Oct 10 15:25:37 2013 +0300

drm/i915: tell the user KMS is required for gen6+

Quoted 8 lines

but it won't be reached if CONFIG_DRM_I915_UMS=n since commit b30324adaf8d2e5950a602bde63030d15a61826f

Author: Daniel Vetter <[email protected]>
Date:   Wed Nov 13 22:11:25 2013 +0100

drm/i915: Deprecated UMS support

Hm, the idea is that this fails _very_ silently so that people only send us regression reports if they actually notice something. Since if there are still people out there which needs UMS, we can't yet rip it out. -Daniel

Quoted 24 lines
---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +2 -0
index 8949fd26b0ea..f0f690776d45 100644
@@ -1584,6 +1584,8 @@ static int __init i915_init(void)
 	if (!(driver.driver_features & DRIVER_MODESET)) {
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
+		DRM_INFO("Kernel modesetting (KMS) and userspace modesetting (UMS) disabled\n");
+		DRM_INFO("See CONFIG_DRM_I915_UMS, CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n");
 		/* Silently fail loading to not upset userspace. */
 		return 0;
 #endif
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 19 lines · Daniel Vetter
Quoted 18 lines · Jani Nikula

If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might not be aware his setup is not supported. Inform the users (and, by extension, the poor i915 developers having to read their dmesgs in bug reports) why their graphics experience might be lacking.

A similar message was added on the UMS path in
commit e147accbd19f55489dabdcc4dc3551cc3e3f2553

Author: Jani Nikula <[email protected]>
Date:   Thu Oct 10 15:25:37 2013 +0300

drm/i915: tell the user KMS is required for gen6+

but it won't be reached if CONFIG_DRM_I915_UMS=n since commit b30324adaf8d2e5950a602bde63030d15a61826f

Author: Daniel Vetter <[email protected]>
Date:   Wed Nov 13 22:11:25 2013 +0100
Quoted 7 lines
Quoted 3 lines

drm/i915: Deprecated UMS support

Hm, the idea is that this fails _very_ silently so that people only send us regression reports if they actually notice something. Since if there are still people out there which needs UMS, we can't yet rip it out.

My gut feeling from bug reports is that, since CONFIG_DRM_I915_UMS now defaults to n, we mostly end up here because users have issues with KMS and try nomodeset as a workaround. Is this silent enough, same commit message:

drivers/gpu/drm/i915/i915_drv.c +1 -0
index 8949fd26b0ea..ca46e6cf4b99 100644
@@ -1585,6 +1585,7 @@ static int __init i915_init(void)
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
 		/* Silently fail loading to not upset userspace. */
+		DRM_DEBUG_DRIVER("KMS and UMS disabled.\n");
 		return 0;
 #endif
 	}

BR,
Jani.

Quoted 31 lines

-Daniel

Quoted 24 lines
---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +2 -0
index 8949fd26b0ea..f0f690776d45 100644
@@ -1584,6 +1584,8 @@ static int __init i915_init(void)
 	if (!(driver.driver_features & DRIVER_MODESET)) {
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
+		DRM_INFO("Kernel modesetting (KMS) and userspace modesetting (UMS) disabled\n");
+		DRM_INFO("See CONFIG_DRM_I915_UMS, CONFIG_DRM_I915_KMS, nomodeset, and i915.modeset parameters\n");
 		/* Silently fail loading to not upset userspace. */
 		return 0;
 #endif
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
#3 lore raw

PATCH v2 1/1 drm/i915: tell the user if both KMS and UMS are disabled

In reply to Daniel Vetter

If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might not be aware his setup is not supported. Inform the users (and, by extension, the poor i915 developers having to read their dmesgs in bug reports) why their graphics experience might be lacking.

A similar message was added on the UMS path in
commit e147accbd19f55489dabdcc4dc3551cc3e3f2553

Author: Jani Nikula <[email protected]>
Date:   Thu Oct 10 15:25:37 2013 +0300

drm/i915: tell the user KMS is required for gen6+

but it won't be reached if CONFIG_DRM_I915_UMS=n since commit b30324adaf8d2e5950a602bde63030d15a61826f

Author: Daniel Vetter <[email protected]>
Date:   Wed Nov 13 22:11:25 2013 +0100

drm/i915: Deprecated UMS support

v2: Use DRM_DEBUG_DRIVER.

---
 drivers/gpu/drm/i915/i915_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.c +1 -0
index b6d2a8f96278..8e58083ffb11 100644
@@ -1576,6 +1576,7 @@ static int __init i915_init(void)
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
 		/* Silently fail loading to not upset userspace. */
+		DRM_DEBUG_DRIVER("KMS and UMS disabled.\n");
 		return 0;
 #endif
 	}
Signature · 1 line
1.9.1
#4 lore raw
Quoted 15 lines · Jani Nikula

If both KMS is disabled (by i915.modeset=0 or nomodeset parameters) and UMS is disabled (by CONFIG_DRM_I915_UMS=n, the default), the user might not be aware his setup is not supported. Inform the users (and, by extension, the poor i915 developers having to read their dmesgs in bug reports) why their graphics experience might be lacking.

A similar message was added on the UMS path in
commit e147accbd19f55489dabdcc4dc3551cc3e3f2553

Author: Jani Nikula <[email protected]>
Date:   Thu Oct 10 15:25:37 2013 +0300

drm/i915: tell the user KMS is required for gen6+

but it won't be reached if CONFIG_DRM_I915_UMS=n since commit b30324adaf8d2e5950a602bde63030d15a61826f

Quoted 8 lines
Author: Daniel Vetter <[email protected]>
Date:   Wed Nov 13 22:11:25 2013 +0100

drm/i915: Deprecated UMS support

v2: Use DRM_DEBUG_DRIVER.

Queued for -next, thanks for the patch. I'll shuffle it into the 3.16 pile when I get around to that.
-Daniel

Quoted 19 lines
---
 drivers/gpu/drm/i915/i915_drv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/i915_drv.c +1 -0
index b6d2a8f96278..8e58083ffb11 100644
@@ -1576,6 +1576,7 @@ static int __init i915_init(void)
 		driver.get_vblank_timestamp = NULL;
 #ifndef CONFIG_DRM_I915_UMS
 		/* Silently fail loading to not upset userspace. */
+		DRM_DEBUG_DRIVER("KMS and UMS disabled.\n");
 		return 0;
 #endif
 	}
Signature · 1 line
1.9.1
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch